Skip to:

Opened 10 years ago

Closed 10 years ago

Last modified 8 months ago

#2615 closed defect (bug) (fixed)

Reply url in topic not correct, after 1000 replies in topic

Reported by: drpepper75's profile DrPepper75 Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.6 Priority: highest omg sweet tea
Severity: normal Version: 2.5.4
Component: General Keywords: needs-patch


Because on line 356 of "includes/replies/functions.php"

'menu_order'     => bbp_get_topic_reply_count( $topic_id, false ) + 1

should be

'menu_order'     => bbp_get_topic_reply_count( $topic_id, true ) + 1

Now the nice version is used, including a thousand separator. Which makes the integer 1000 the string 1,000 and will later on be cast back to an integer with the value 1.

Quite easy fix, isn't it?

Change History (2)

#1 @johnjamesjacoby
10 years ago

  • Milestone changed from Awaiting Review to 2.6
  • Owner set to johnjamesjacoby

#2 @johnjamesjacoby
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In 5392:

Force integer value in bbp_has_topics() for reply position. Fixes bug when there are more than 1,000 replies. Props DrPepper75. Fixes #2615.

Note: See TracTickets for help on using tickets.