Skip to:

Opened 4 years ago

Closed 3 years ago

#2599 closed defect (fixed)

Group forum visibility doesn't seem to change along with group visibility change.

Reported by: jreeve Owned by: John James Jacoby
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.5.3
Component: Extend - BuddyPress Keywords: has-patch


It seems like the visibility of group forums (handled by the bbpress extension for buddypress) should change along with the group visibility. We had several hidden groups staged to be public groups, but when we made them public, we noticed that their associated forums were still hidden. The "forum" button still exists in the group sidebar tabs, but when the user clicks "forum," he is incorrectly informed that the group doesn't have a forum.

To reproduce:

  1. Create a hidden buddypress group and make an associated group forum.
  2. Change the visibility of the group to "public."
  3. Notice that the group forum visibility does not also change.

Attachments (2)

2599.diff (3.2 KB) - added by pareshradadiya 3 years ago.
Forum visibility dropdown added to the 'Group Forum Settings'
2599.2.diff (1.8 KB) - added by Boone Gorges 3 years ago.

Download all attachments as: .zip

Change History (12)

#1 @jreeve
4 years ago

Also, even more disturbingly, after changing the visibility of a group, some group forums report that there are three topics in the forum, then (on the same page), report that there are no topics in the forum. Removing and readding the forum in the admin tab fixes this issue.

#2 @Stephen Edgar
4 years ago

  • Component changed from General to BuddyPress

Running the bbPress repair tool "Recalculate private and hidden forums" should resolve this issue also instead of recreating the forum. Will need to investigate why BuddyPress is currently doing this, the functionality was added in r5017 to support this.

#3 @Stephen Edgar
4 years ago

Still unsure what to do about this...

On the bbPress side we can add bbp_form_forum_visibility_dropdown() to the 'Group Forum Settings' per the mockup image below or something on the BuddyPress side if possible.

#4 @John James Jacoby
4 years ago

  • Milestone changed from Awaiting Review to 2.7

Move from awaiting review to 2.7 milestone.

#5 @Stephen Edgar
3 years ago

#2752 was marked as a duplicate.

3 years ago

Forum visibility dropdown added to the 'Group Forum Settings'

#6 @pareshradadiya
3 years ago

  • Keywords has-patch added

This ticket was mentioned in Slack in #bbpress by netweb. View the logs.

3 years ago

#8 @Stephen Edgar
3 years ago

  • Milestone changed from 2.7 to 2.6

@Boone Gorges
3 years ago

#9 @Boone Gorges
3 years ago

In the vast majority of cases, group forum visibility should match the status of the group. For this reason, I think it's overkill (and ill-advised) to solve the problem by adding an independent dropdown. Such a dropdown will encourage, rather than reduce, the divergence of group/forum status, and it requires action by the group admin.

See 2599.2.diff for a suggested fix, which is totally automated.

#10 @John James Jacoby
3 years ago

  • Owner set to John James Jacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 5905:

BuddyPress: Introduce BBP_Forums_Group_Extension::update_group_forum_visibility() to keep group forum visibility in alignment with BuddyPress Group visibility.

This changeset ensures that when a BuddyPress Group's visibility changes, it's bbPress forum visibility changes along with it. This avoids a UX issue where Group visibility and Forum visibility could become misaligned when updating a Group.

Props boonebgorges. Fixes #2599.

Note: See TracTickets for help on using tickets.