Skip to:
Content

Opened 16 months ago

Closed 3 weeks ago

#2599 closed defect (fixed)

Group forum visibility doesn't seem to change along with group visibility change.

Reported by: jreeve Owned by: johnjamesjacoby
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.5.3
Component: Extend - BuddyPress Keywords: has-patch
Cc:

Description

It seems like the visibility of group forums (handled by the bbpress extension for buddypress) should change along with the group visibility. We had several hidden groups staged to be public groups, but when we made them public, we noticed that their associated forums were still hidden. The "forum" button still exists in the group sidebar tabs, but when the user clicks "forum," he is incorrectly informed that the group doesn't have a forum.

To reproduce:

  1. Create a hidden buddypress group and make an associated group forum.
  2. Change the visibility of the group to "public."
  3. Notice that the group forum visibility does not also change.

Attachments (2)

2599.diff (3.2 KB) - added by pareshradadiya 4 months ago.
Forum visibility dropdown added to the 'Group Forum Settings'
2599.2.diff (1.8 KB) - added by boonebgorges 3 weeks ago.

Download all attachments as: .zip

Change History (12)

comment:1 @jreeve16 months ago

Also, even more disturbingly, after changing the visibility of a group, some group forums report that there are three topics in the forum, then (on the same page), report that there are no topics in the forum. Removing and readding the forum in the admin tab fixes this issue.

comment:2 @netweb16 months ago

  • Component changed from General to BuddyPress

Running the bbPress repair tool "Recalculate private and hidden forums" should resolve this issue also instead of recreating the forum. Will need to investigate why BuddyPress is currently doing this, the functionality was added in r5017 to support this.

comment:3 @netweb15 months ago

Still unsure what to do about this...

On the bbPress side we can add bbp_form_forum_visibility_dropdown() to the 'Group Forum Settings' per the mockup image below or something on the BuddyPress side if possible.

https://i.cloudup.com/CQRo30Aap7.png

comment:4 @johnjamesjacoby12 months ago

  • Milestone changed from Awaiting Review to 2.7

Move from awaiting review to 2.7 milestone.

comment:5 @netweb7 months ago

#2752 was marked as a duplicate.

@pareshradadiya4 months ago

Forum visibility dropdown added to the 'Group Forum Settings'

comment:6 @pareshradadiya4 months ago

  • Keywords has-patch added

comment:7 @slackbot3 weeks ago

This ticket was mentioned in Slack in #bbpress by netweb. View the logs.

comment:8 @netweb3 weeks ago

  • Milestone changed from 2.7 to 2.6

@boonebgorges3 weeks ago

comment:9 @boonebgorges3 weeks ago

In the vast majority of cases, group forum visibility should match the status of the group. For this reason, I think it's overkill (and ill-advised) to solve the problem by adding an independent dropdown. Such a dropdown will encourage, rather than reduce, the divergence of group/forum status, and it requires action by the group admin.

See 2599.2.diff for a suggested fix, which is totally automated.

comment:10 @johnjamesjacoby3 weeks ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 5905:

BuddyPress: Introduce BBP_Forums_Group_Extension::update_group_forum_visibility() to keep group forum visibility in alignment with BuddyPress Group visibility.

This changeset ensures that when a BuddyPress Group's visibility changes, it's bbPress forum visibility changes along with it. This avoids a UX issue where Group visibility and Forum visibility could become misaligned when updating a Group.

Props boonebgorges. Fixes #2599.

Note: See TracTickets for help on using tickets.