Skip to:
Content

bbPress.org

Opened 5 years ago

Last modified 5 years ago

#2570 new enhancement

Default User Profile Fields

Reported by: netweb Owned by:
Milestone: 2.8 Priority: low
Severity: normal Version: trunk
Component: Component - Users Keywords: 2nd-opinion
Cc:

Description

I couldn't work out why a users profile URL wasn't being displayed on their profile and realized it is because we don't actually include it in user-profile.php

I'm conflicted on if we should or shouldn't include this by default.

If we do then should we also include user registration date?

What about user_contactmethods? Should we create a new function bbp_user_contact_methods similar to bbp_edit_user_contact_methods and output each to the user profile?

Related: #2055 Include member page

Attachments (2)

user-profile.php.patch (874 bytes) - added by netweb 5 years ago.
2570.2.diff (1.0 KB) - added by netweb 5 years ago.

Download all attachments as: .zip

Change History (7)

@netweb
5 years ago

#1 @netweb
5 years ago

Over on bbpress I mentioned if we went ahead it would not use target="_blank" and linked to this, after reading some of comments in that post there are pros and cons to both sides of the argument.

I personally despise target="_blank" but I 100% expect (and count on it) with external links from Twitter and Gmail, but NOT Google Search.

So now, myself I am now conflicted on both implementation and if it should open in a new window/tab or not!

Edit: I suppose rel="nofollow" needs to also be added

Last edited 5 years ago by netweb (previous) (diff)

#2 @Robin W
5 years ago

  • Version changed from 2.5 to trunk

Of course the solution would be to add a function to includes/user/template.php called say

bbp_displayed_user_url_link ()

and create that with the href but without the target="_blank"

and call that from user-profile.php

and then anyone who wants can filter this function to add the 'target="_blank"' without having to alter the profile template !

Everyone satisfied !

#3 @johnjamesjacoby
5 years ago

In 5472:

Use wp_get_user_contact_methods() in bbp_get_user_contact_methods(). See #2570.

#4 @johnjamesjacoby
5 years ago

  • Milestone changed from Awaiting Review to 2.7

URL seems fine to me. So do the registration date and contact methods.

Moving to 2.7.

#5 @johnjamesjacoby
5 years ago

  • Milestone changed from 2.7 to 2.8

Bumping all 2.7 to 2.8 milestone.

Note: See TracTickets for help on using tickets.