BuddyPress new notifications component troubles

[imath]

Hi,

On bp-fr.net, we've noticed a pretty annoying issue using bbPress 2.5.1 with BuddyPress 1.9. bbPress is using the new notifications component, which is great. So when a reply is added, the author gets a notification.

1/ it's not displayed in the admin bar, but it is displayed into the unread screen panel of the notifications component. And when clicking on the link, it causes an error as the bp_core_mark_notifications_by_item_id() function doesn't exist in BuddyPress 1.9

2/ As in includes/extend/buddypress/loader.php the includes/extend/buddypress/notifications.php file is only loaded if the BuddyPress component 'notifications' is active, i believe, this feature is only enabled for BuddyPress 1.9+. So i suggest to directly use the new notifications component functions instead of deprecated ones to create the notifications.

3/ The reason in point 1/ the admin bar doesn't display the "bubble" is due to this ​ticket. I know it will be reversed, but in a future release of BuddyPress, the notifications will only be displayed in the admin bar and in notifications screens if bbPress is referenced as an active component. So this ticket is also modifying includes/extend/buddypress/loader.php to add bbPress to BuddyPress active components.

Just tested the suggested patch with trunk version of bbPress, BuddyPress 1.9 and WordPress 3.8, and it seems to solve the trouble.

[johnjamesjacoby]

In 5232:

Introduce helper function for getting the BuddyPress component name, and filter new BuddyPress function to include it in registered components. Fixes #2495. Hat-tip imath. (trunk)

[johnjamesjacoby]

In 5233:

Introduce helper function for getting the BuddyPress component name, and filter new BuddyPress function to include it in registered components. Fixes #2495. Hat-tip imath. (2.5 branch)

[johnjamesjacoby]

Related (and fixed for now): ​http://buddypress.trac.wordpress.org/ticket/5300