Skip to:
Content

bbPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2495 closed defect (fixed)

BuddyPress new notifications component troubles

Reported by: imath Owned by: johnjamesjacoby
Milestone: 2.5.2 Priority: normal
Severity: major Version: 2.5.1
Component: Extend - BuddyPress Keywords: has-patch needs-testing
Cc:

Description

Hi,

On bp-fr.net, we've noticed a pretty annoying issue using bbPress 2.5.1 with BuddyPress 1.9. bbPress is using the new notifications component, which is great. So when a reply is added, the author gets a notification.

1/ it's not displayed in the admin bar, but it is displayed into the unread screen panel of the notifications component. And when clicking on the link, it causes an error as the bp_core_mark_notifications_by_item_id() function doesn't exist in BuddyPress 1.9

2/ As in includes/extend/buddypress/loader.php the includes/extend/buddypress/notifications.php file is only loaded if the BuddyPress component 'notifications' is active, i believe, this feature is only enabled for BuddyPress 1.9+. So i suggest to directly use the new notifications component functions instead of deprecated ones to create the notifications.

3/ The reason in point 1/ the admin bar doesn't display the "bubble" is due to this ticket. I know it will be reversed, but in a future release of BuddyPress, the notifications will only be displayed in the admin bar and in notifications screens if bbPress is referenced as an active component. So this ticket is also modifying includes/extend/buddypress/loader.php to add bbPress to BuddyPress active components.

Just tested the suggested patch with trunk version of bbPress, BuddyPress 1.9 and WordPress 3.8, and it seems to solve the trouble.

Attachments (1)

2495.diff (2.2 KB) - added by imath 5 years ago.

Download all attachments as: .zip

Change History (5)

@imath
5 years ago

#1 @johnjamesjacoby
5 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 5232:

Introduce helper function for getting the BuddyPress component name, and filter new BuddyPress function to include it in registered components. Fixes #2495. Hat-tip imath. (trunk)

#2 @johnjamesjacoby
5 years ago

In 5233:

Introduce helper function for getting the BuddyPress component name, and filter new BuddyPress function to include it in registered components. Fixes #2495. Hat-tip imath. (2.5 branch)

#4 @johnjamesjacoby
5 years ago

  • Milestone changed from Awaiting Review to 2.5.2
Note: See TracTickets for help on using tickets.