Skip to:
Content

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#2481 closed defect (fixed)

bbp_enqueue_style() doesn't work well with Windows filepaths

Reported by: r-a-y Owned by: johnjamesjacoby
Milestone: 2.5.1 Priority: normal
Severity: normal Version: trunk
Component: Front-end Keywords: has-patch
Cc: Mat, Lipe

Description

r5204 and r5185 attempted to intelligently replace the WP_CONTENT_DIR with the WP_CONTENT_URL to generated the stylesheet URLs.

However, these commits do not work well with Windows filepaths.

Attached patch is an attempt at fixing this. Needs testing on Linux.

Attachments (2)

2481.01.patch (1.7 KB) - added by r-a-y 4 years ago.
2481.01.2.patch (1.7 KB) - added by netweb 4 years ago.
Same patch with added reference 'IIS'

Download all attachments as: .zip

Change History (11)

@r-a-y
4 years ago

#1 @r-a-y
4 years ago

Meant to type r5186 instead of r5185.

#2 @johnjamesjacoby
4 years ago

  • Milestone changed from Awaiting Review to 2.5.1

Had a feeling this might be a problem. Thanks for taking a stab at it.

#3 @netweb
4 years ago

Patch is good :)

Tested on:

Windows Apache (XAMPP) http://localhost

  • http://127.0.0.1/wp-content/plugins/bbpress/templates/default/css/bbpress.css?ver=2.5-5199

CentOS Apache http://example.com

  • http://example.com http://example.com/wp-content/plugins/bbpress/templates/default/css/bbpress.css?ver=2.5-5199

Windows IIS Multisite (Sub Domain)

  • http://firstsite.nw/wp-content/plugins/bbpress/templates/default/css/bbpress.css?ver=2.5-5199
  • http://firstsite.primarysite.nw/wp-content/plugins/bbpress/templates/default/css/bbpress.css?ver=2.5-5199
  • http://secondsite.nw/wp-content/plugins/bbpress/templates/default/css/bbpress.css?ver=2.5-5199
  • http://secondsite.primarysite.nw/wp-content/plugins/bbpress/templates/default/css/bbpress.css?ver=2.5-5199

I presume Nginx is good as bbpress.org is Nginx :) and I broke my Nginx setup ;)

@netweb
4 years ago

Same patch with added reference 'IIS'

#4 @r-a-y
4 years ago

Thanks for the extensive testing, netweb!

#5 @johnjamesjacoby
4 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 5209:

Windows (IIS) support for theme compatibility script and style functions. Props r-a-y, netweb. Fixes #2481. (trunk)

#6 @johnjamesjacoby
4 years ago

In 5210:

Windows (IIS) support for theme compatibility script and style functions. Props r-a-y, netweb. Fixes #2481. (2.5)

#7 @inetbizo
4 years ago

@netweb patch does not work in linux

#8 @netweb
4 years ago

@inetbizo You shouldn't need the patch for linux systems.

Firstly in your forum post here you state you have reverted back to bbPress 2.5, if this is correct version then your site is working as expected with bbPress 2.5 at the moment and looks great by the way :)

<link rel='stylesheet' id='bbp-default-css' href='https://www.hosting-4-oscommerce.com/wp-content/plugins/bbpress/templates/default/css/bbpress.css?ver=2.5-5199' type='text/css' media='screen' />

If your actually using bbPress 2.4.x could you please update to bbPress 2.5 again and let us know if that works.

#9 @Mat Lipe
4 years ago

  • Cc Mat Lipe added

Tested across a few systems and working as desired.

Note: See TracTickets for help on using tickets.