Skip to:
Content

Opened 5 years ago

Last modified 4 years ago

#2477 new defect

loop-single-reply.php calls bbp_reply_author_link() for topics, too

Reported by: wpdennis Owned by: johnjamesjacoby
Milestone: 2.8 Priority: lowest
Severity: trivial Version: 2.4.1
Component: Appearance - Included Themes Keywords: dev-feedback
Cc:

Description

A topic detail page loops through each post with loop-single-reply.php.

Without lead topics enabled, this template file is used for replies and topics.

If you filter something like bbp_get_reply_author_display_name the following will return false within the filter:

bbp_is_reply($reply_id)

for the first post in a topic (the topic itself). To be consistent, maybe the loop should distinguish between post type "reply" and post type "topic" to call the appropriate function.

Change History (4)

#1 @johnjamesjacoby
5 years ago

  • Milestone changed from Awaiting Review to 2.6

Good idea. There's likely a few places this happens.

Related #1513.

#2 @johnjamesjacoby
5 years ago

  • Owner set to johnjamesjacoby

#3 @netweb
5 years ago

Related #2244

#4 @johnjamesjacoby
4 years ago

  • Milestone changed from 2.6 to 2.8

Bumping to 2.8, as there's a fair amount of plumbing that needs to be updated before joining topics & replies into 1 set of functions could be achieved.

To that end, is that something we'd even want to do? There's something nice about being able to easily selectively filter topics VS replies, IMO.

Note: See TracTickets for help on using tickets.