Add filter for dropdown arguments in bbp_get_dropdown

[nofearinc]

bbp_get_dropdown in includes/common/template-tags.php is fetching entries with get_posts based on input arguments for all bbPress dropdown filters. The arguments passed to get_posts could not be filtered from plugins.

I would suggest adding a filter to the get_posts arguments array for external manipulation for dropdowns.

[nofearinc]

includes/common/template-tags.php filter added for get_posts args

[johnjamesjacoby]

Is this something you can solve using the passive and aggressive filters in bbp_parse_args()

• bbp_before_get_dropdown_parse_args
• bbp_after_get_dropdown_parse_args

[nofearinc]

Yes, bbp_after_get_dropdown_parse_args would do the work here, thanks

[nofearinc]

I'm reopening this ticket as the post_status is set after the filter in question.

This snippet could be found after those filters, before get_posts in template-tags.php:

		// Define local variable(s)
		$post_stati = array();

		// Public
		$post_stati[] = bbp_get_public_status_id();

Therefore I cannot modify the post status.

[johnjamesjacoby]

In 5010:

In bbp_get_dropdown(), remove the hard-coded post_status checker, and trust bbp_pre_get_posts_normalize_forum_visibility() to do its job. We still pass 'post_status' as null, so that get_posts() gets passed the results of bbp_parse_args(). Also, remove 'sort_column' array key from when this used get_pages(), and rely on 'orderby' for get_posts() instead.

In bbp_pre_get_posts_normalize_forum_visibility(), remove empties and duplicates from the $post_stati array.

Fixes #2354.