Search Improvements

[johnjamesjacoby]

Search has been in bbPress core for a few months now, and a few bugs have cropped up, warranting enhancements:

• Switch away from $_GET query string (See #2336)
• Audit URL encoding/decoding
• Audit unpretty permalink functionality
• Fix unpretty permalink breadcrumb link
• Add search-results page functions

[johnjamesjacoby]

In 4917:

Trim search shortcode search-terms. See #2337.

[johnjamesjacoby]

In 4919:

Introduce bbp_is_search_results() and use it in is_bbpress() and bbp_body_class(). See #2337.

[johnjamesjacoby]

In 4920:

In bbp_is_search_results(), use $wp_query->bbp_search_terms instead of new bbp_is_search_results query-var. See #2337.

[johnjamesjacoby]

In 4921:

Use bbp_get_search_url() in bbp_get_breadcrumb() so that it works without pretty permalinks. See #2337.

[johnjamesjacoby]

In 4928:

Introduce bbp_search_results_url(), bbp_get_search_results_url(), and bbp_search_template_redirect(), to handle the new search results page routing. See #2337.

[johnjamesjacoby]

In 4930:

Use WordPress core rewrite API to add rewrite tags, rules, and permalink structures. Replaces the need to merge rewrite rules directly into the $wp_rewrite array on permalink flush. In the future, much of this complexity can be turned into easier to use functions to add new profile pages, etc... Fixes #2336. See #2337.

[johnjamesjacoby]

In 4997:

Make search results page use pretty permalinks if they are enabled:

• Change search form method from "get" to "post"
• Move 'bbp_search_request_redirect' action to 'bbp_post_request' to avoid recursion.
• Tweak bbp_search_request_redirect() to check for pretty permalinks, and remove now superfluous recursion checks.
• See #2337.

[johnjamesjacoby]

In 4999:

Since search requests get existing data, and do not post new data, revert part of r4997 and switch request method back to "get".

Add hidden 'action' field to form-search.php template-part, and move 'bbp_search_results_redirect' action from 'bbp_post_request' to 'bbp_get_request'.

Fixes issue with request not redirecting properly, and uses more accurate form method. See #2337.