Skip to:
Content

bbPress.org

Opened 11 years ago

Closed 11 years ago

#2254 closed enhancement (wontfix)

Thread Post IDs starting at #1 and incrementing by thread posts only instead of by all the site components IDs

Reported by: jallejalle's profile jallejalle Owned by:
Milestone: Priority: low
Severity: normal Version: 2.2.3
Component: Appearance - Included Themes Keywords:
Cc:

Description

On a bbPress forum, each thread post has a number (for example: #156) which is useful to find it.
On a fresh install, the very first thread post on a new bbPress forum doesn't start at #1 as it should be expected by its members.
And the second post can get another number than #2, etc.

Post number starts and increases like that is bbPress forum posts are added as WordPress post items (including WordPress blog posts, pages, revisions, etc.). So the post number corresponds to the post ID in the database instead of the one of the forums.

It would be a very good enhancement if thread_post_ids could correspond to forum thread posts only, as logically expected.

Attachments (1)

2254.01.patch (746 bytes) - added by r-a-y 11 years ago.

Download all attachments as: .zip

Change History (7)

#1 @jallejalle
11 years ago

  • Milestone changed from Awaiting Review to Future Release

#2 @alex-ye
11 years ago

  • Milestone changed from Future Release to Awaiting Review
  • Version changed from 2.1 to 2.2.3

I can't see any enhancement here , I can talk about that a lot but you can read more about SQL , Ordered topics numbers it's sounds like a plugin to me :)

#3 follow-up: @r-a-y
11 years ago

  • Component changed from General to Included Themes
  • Keywords has-patch added
  • Priority changed from normal to low

I think this makes sense.

I've attached a patch against trunk that will do what jallejalle wants.

@r-a-y
11 years ago

#4 in reply to: ↑ 3 @alex-ye
11 years ago

Replying to r-a-y:

I think this makes sense.

Maybe , but we show the reply ID for a long time in bbPress , It's not easy to change a default beehive in that simple :( , I have many replies in my forums I like showing reply ID instead of reply position because it's make easy to debug , save and locate !

In addition , You can see bbp_reply_url() function it's ends with a reply ID , So it's not make sense to print reply position :)

And remember that the replies in bbPress can be delete , spam ... etc
So the reply position is not really unique !

At the end ...
It's easy thing to do , So I think it's something that the theme designer choose to do :)

#5 @r-a-y
11 years ago

  • Keywords has-patch removed

Popular forum software, vBulletin, uses the post number instead of the ID and the link to the post permalink ends with the post ID. Just a FYI.

And remember that the replies in bbPress can be delete , spam ... etc So the reply position is not really unique !

You're right! Just tested this and if you trash a reply and delete it, the post number will skip. (If I delete post number 3, the post numbers would then look like, 1, 2, 4, etc. ) Okay, disregard my patch. If the OP wants a solution, it would have to be custom-coded for now.

#6 @johnjamesjacoby
11 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.