Skip to:
Content

Opened 6 years ago

Last modified 4 years ago

#2223 new enhancement

Add bbPress User Roles Dropdown to new-user.php

Reported by: alex-ye Owned by:
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.2.3
Component: Back-end Keywords: has-patch
Cc: nashwan.doaqan@…, wordpress@…, pippin@…

Description

Hi , We should add bbPress user roles dropdown in new-user.php admin page .

Attachments (2)

users.php.patch (843 bytes) - added by MZAWeb 6 years ago.
2223.patch (2.1 KB) - added by MZAWeb 5 years ago.

Download all attachments as: .zip

Change History (17)

#1 @alex-ye
6 years ago

  • Cc nashwan.doaqan@… added

#2 @johnjamesjacoby
6 years ago

  • Milestone changed from Awaiting Review to 2.4

Oversight. Patch should be easyish. Moving to 2.4.

#3 @MZAWeb
6 years ago

  • Cc wordpress@… added
  • Keywords has-patch added; needs-patch removed

Added patch.

@MZAWeb
6 years ago

#4 @mordauk
6 years ago

  • Cc pippin@… added

#5 @johnjamesjacoby
6 years ago

Can we add a second dropdown, instead of adding bbPress's roles to the existing one?

#6 @johnjamesjacoby
6 years ago

  • Milestone changed from 2.4 to 2.5

No time. Moving to 2.5.

#7 @MZAWEb
6 years ago

Sorry, was out for a while. Will patch tomorrow.

#8 follow-up: @MZAWEb
6 years ago

So, finishing this patch I found that core's user-new.php doesn't have an action to add fields ( http://core.trac.wordpress.org/ticket/18709 ). Out options:

1) Add the combo only in the user edit screen. 2) (Hack) Use the show_password_fields hook and squeeze the combo in, and remember to fix it when core adds the correct action. 3) Wait for core to add the action before doing this patch.

2 is ugly but I guess our best option here. Thoughts?

#9 @mordauk
6 years ago

I'd propose we wait until core provides a hook.

#10 in reply to: ↑ 8 @johnjamesjacoby
6 years ago

Replying to MZAWEb:

2 is ugly but I guess our best option here. Thoughts?

Let's patch this as if #WP18709 is committed in, and wait. It's the correct approach, and I'd rather not hack it in temporarily.

@MZAWeb
5 years ago

#11 @MZAWeb
5 years ago

2223.patch​ assumes 18709.2.patch​ in #WP18709 gets into core.

#12 @netweb
5 years ago

#WP18709 is now in core via [WP25629]

#13 @johnjamesjacoby
5 years ago

  • Milestone changed from 2.5 to 2.6

Bump to 2.6.

#14 @johnjamesjacoby
5 years ago

  • Milestone changed from 2.6 to 2.7

Bump to 2.7.

#15 @johnjamesjacoby
4 years ago

  • Milestone changed from 2.7 to 2.8

Bumping all 2.7 to 2.8 milestone.

Note: See TracTickets for help on using tickets.