Fix Current URL in bbp_redirect_to_field()

[alex-ye]

Hi Guys , I just found this small bug in bbPress ...

bbp_redirect_to_field() Function doesn't work when the WordPress in sub-folder , because of using WordPress home_url() function , bbp_redirect_to_field() can't guess the correct current URL ...

Example :
if current URL is "​http://localhost/wp/page" the bbp_redirect_to_field() redirect you to "​http://localhost/wp/wp/page" .

Tested On :
WordPess 3.5
bbPress 2.2.3
PHP 5.4.3

[alexvorn2]

related #1835,

this patch is not good, because it breaks another fix...
​https://bbpress.trac.wordpress.org/attachment/ticket/1835/1835.diff

[alex-ye]

Replying to alexvorn2:

this patch is not good, because it breaks another fix...
​https://bbpress.trac.wordpress.org/attachment/ticket/1835/1835.diff

I have added a patch file that uses wp_get_referer() function :)

[alexvorn2]

why not use home_url function?

[alex-ye]

Replying to alexvorn2:

why not use home_url function?

I describe the problem above , as you see home_url() function returns a the website home link like localhost/bbp , and REQUEST_URL return the URI which was given in order to access this page like /bbp/post-title/

So passing REQUEST_URL to home_url() return wrong URL localhost/bbp/bbp/post-title/

[alexvorn2]

what about site_url() function? can you test if it works well here?

[alex-ye]

Replying to alexvorn2:

what about site_url() function? can you test if it works well here?

Remember that site_url() can return the same as home_url() in most cases :)

see :

​http://codex.wordpress.org/Function_Reference/site_url

​http://codex.wordpress.org/Function_Reference/home_url

[alexvorn2]

yeap, but it should work I think...

anyway, there must be a function, not a

$_SERVER['HTTP_HOST']

variable

[alex-ye]

Replying to alexvorn2:

yeap, but it should work I think...

anyway, there must be a function, not a

$_SERVER['HTTP_HOST']

variable

there are no must :) , The code I write above is from the WordPress core and bbPress core too , and it writed in many plugins and themes :)

Why are you feel bad of using HTTP_HOST ?!

[apet083]

Hi everyone, I thought I would update you on my experience with this problem. I have spent MONTHS finding a reason and a fix for why my bbPress forum would redirect users to random places when replying to a post. I noticed the URL was being rewritten wrongly - see http://bbpress.org/forums/topic/forum-reply-redirect-url-rewrite-issue/#post-125384

Anyway, I implemented the patch that @alex-ye added and my replies were redirected correctly! Am very relieved and thankful :)
My WordPress was setup on Windows 7/IIS 7.5/PHP 5.3/MySQL 5.1 with the latest version of WordPress and bbPress.

[johnjamesjacoby]

(In [4700]) Update bbp_redirect_to_field() to not use home_url(), and instead use super globals. Props alex-ye. Fixes #2155.