Skip to:
Content

bbPress.org

Opened 11 years ago

Closed 11 years ago

#2134 closed enhancement (fixed)

Improve readability in Example.php Forum Importer (Inline Docs & Code Formatting)

Reported by: netweb's profile netweb Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.4 Priority: normal
Severity: normal Version: 2.2
Component: API - Importers Keywords: needs-patch commit
Cc:

Description

The Example.php Forum Importer example needs to be tidied up to match the inline docs and code formatting as current revisions of bbPress1.php, phpBB.php & SimplePress5.php for improved readability.

Attachments (2)

2134.1.diff (18.5 KB) - added by netweb 11 years ago.
First pass, no core code changes, updated formatting, cleaned whitespace and updated inline docs and phpdoc for consistency across all import tools.
2134.2.diff (25.6 KB) - added by netweb 11 years ago.
Second pass includes all the possible 'to' fields for bbPress, adds common 'join' section in each section.

Download all attachments as: .zip

Change History (7)

#1 @johnjamesjacoby
11 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 2.4

Agree. Putting in 2.4 to give time for a nice patch.

#2 @netweb
11 years ago

Once patched also update the 'work in progress' docs

http://codex.bbpress.org/import-forums/custom-import/

@netweb
11 years ago

First pass, no core code changes, updated formatting, cleaned whitespace and updated inline docs and phpdoc for consistency across all import tools.

@netweb
11 years ago

Second pass includes all the possible 'to' fields for bbPress, adds common 'join' section in each section.

#3 @netweb
11 years ago

Still needs more cleaning up and adding callback functions

#4 @johnjamesjacoby
11 years ago

  • Keywords commit added

This is good, and worth sneaking in for 2.4.

#5 @johnjamesjacoby
11 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 5014:

Clean-up to Example.php converter. Props netweb. Fixes #2134.

Note: See TracTickets for help on using tickets.