Skip to:
Content

bbPress.org

Opened 9 years ago

Closed 9 years ago

#2054 closed defect (fixed)

heading tag in reply-content

Reported by: ellipszist Owned by: jaredatch
Milestone: 2.3 Priority: normal
Severity: normal Version: 2.2.2
Component: Appearance - Included Themes Keywords: has-patch needs-testing
Cc:

Description

This code

<h1>This is heading 1</h1>
<h2>This is heading 2</h2>
<h3>This is heading 3</h3>
<h4>This is heading 4</h4>
<h5>This is heading 5</h5>
<h6>This is heading 6</h6>

Attachments (7)

Capture2.PNG (23.0 KB) - added by ellipszist 9 years ago.
Capture3.PNG (15.9 KB) - added by ellipszist 9 years ago.
code in topic
2054.diff (2.8 KB) - added by jaredatch 9 years ago.
content.txt (3.8 KB) - added by jaredatch 9 years ago.
test content
2054.2.diff (3.0 KB) - added by jaredatch 9 years ago.
Clear headers and add reset for links.
2054.3.diff (3.0 KB) - added by jaredatch 9 years ago.
Cleared the headers incorrectly. Also, had to use an !Important on the list items to override the !important bbPress already uses :\
2054.4.diff (3.0 KB) - added by jaredatch 9 years ago.
Scratch that, !importants were from the stupid test theme

Download all attachments as: .zip

Change History (17)

@ellipszist
9 years ago

#1 @johnjamesjacoby
9 years ago

Thanks. Can you include details with your tickets please?

@ellipszist
9 years ago

code in topic

#2 @ellipszist
9 years ago

my theme is twentytwelve and use the default theme.

/wp-content/plugins/bbpress/templates/default

Theme Compatibility

don't built-in default theme into twentytwelve.

#3 @johnjamesjacoby
9 years ago

  • Milestone changed from Awaiting Review to 2.3

We could likely set more explicit stylings for these in 2.3.

#4 @jaredatch
9 years ago

  • Owner set to jaredatch
  • Status changed from new to assigned

As per the 11/28 dev chat we will reset the margin/padding on header elements. Patch forthcoming.

#5 @johnjamesjacoby
9 years ago

  • Status changed from assigned to new

#6 @johnjamesjacoby
9 years ago

  • Owner changed from jaredatch to jardatch

#7 @johnjamesjacoby
9 years ago

  • Owner changed from jardatch to jaredatch

@jaredatch
9 years ago

#8 @jaredatch
9 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

First pass at the patch.

Reset the padding and margin on all the headers.

Reset the list items (broken in TwentyTwelve).

Also added base styling for pre and code as I've found that a ton of themes don't style them.

Tested with TwentyTen/Eleven/Twelve. Could probably use some testing with some other themes, but I think it should be a good start.

@jaredatch
9 years ago

test content

#9 @ellipszist
9 years ago

jaredatch, jjj. please test my css.

/* =User Pages
-------------------------------------------------------------- */

#bbpress-forums h1,
#bbpress-forums h2,
#bbpress-forums h3,
#bbpress-forums h4,
#bbpress-forums h5,
#bbpress-forums h6{
	clear: none;
}

and remove clear: none; below #bbpress-forums h1.

#bbpress-forums h1 {
	clear: none;
	font-size: 1.8em;
	line-height: 1em;
	padding-bottom: 10px;
}
Last edited 9 years ago by ellipszist (previous) (diff)

@jaredatch
9 years ago

Clear headers and add reset for links.

@jaredatch
9 years ago

Cleared the headers incorrectly. Also, had to use an !Important on the list items to override the !important bbPress already uses :\

@jaredatch
9 years ago

Scratch that, !importants were from the stupid test theme

#10 @johnjamesjacoby
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4598]) Improved styling for inner topic and reply content elements, merged with recent changes and includes RTL. Props jaredatch. Fixes #2054.

Note: See TracTickets for help on using tickets.