bbp_set_current_user_default_role() doesn't seem to be adding default roles to non WP roles added by other plugins

[nerrad]

This is the behaviour observed for s2member.

See related discussion here -> http://bbpress.org/forums/topic/fix-for-users-of-s2member-and-bbpress-2-2/

I'm "assuming" that this is happening for other membership plugins other than s2member but that's an assumption based on observed behaviour with s2member.

Before making suggestions here, I'll do some more testing to see why the s2member added roles aren't being picked up.

[nerrad]

okay the current s2member role IS retrieved via $bbp->current_user->roles but there is nothing being done to handle that role if it doesn't match anything in the default bbp_get_user_role_map(). the loop there just checks for roles that match something in the default map.

The question is then, how do we handle this? I suggest that we have any other roles detected given the default bbp role. Something like what I'll post in a patch after this comment.

[netweb]

Also related discussion: ​http://www.s2member.com/forums/topic/dont-upgrade-to-bbpress-2-2/

[nerrad]

make sure any custom roles added by a plugin are given default bbp role

[nerrad]

I don't like the duplication of code in the patch, but at least it points to what needs to be changed/modified.

[johnjamesjacoby]

(In [4447]) Roles:

• Remove unused Visitor role.
• Map non-WordPress roles to default role.
• Hat-tip nerrad for confirmation/testing.
• Fixes #2042 (trunk)

[johnjamesjacoby]

(In [4448]) Roles:

• Remove unused Visitor role.
• Map non-WordPress roles to default role.
• Hat-tip nerrad for confirmation/testing.
• Fixes #2042 (2.2 branch)

[nerrad]

awesome... like the fix too.

[johnjamesjacoby]

(In [4449]) Roles:

• get_editable_roles() is an admin function, so copy over functionality into bbp_get_user_blog_role().
• See #2042 (2.2 branch)

[johnjamesjacoby]

(In [4450]) Roles:

• get_editable_roles() is an admin function, so copy over functionality into bbp_get_user_blog_role().
• See #2042 (trunk)

[johnjamesjacoby]

(In [4451]) Tools/Roles:

• In user-map repair tool, use default role if role-map entry does not exist.
• See #2042 (trunk)

[johnjamesjacoby]

(In [4452]) Tools/Roles:

• In user-map repair tool, use default role if role-map entry does not exist.
• See #2042 (2.2 branch)