call_user_func_array() expects parameter 1 to be a valid callback, non-static method BBP_Replies_Widget::register_widget() should not be called statically

[nerrad]

Getting the above notice on our bbPress site running PHP 5.3.18

Stack trace:

…ll_user_func_array called at /public_html/wp-includes/plugin.php (403)

…ntesp/public_html/wp-content/plugins/bbpress/bbp-includes/bbp-core-actions.php (402)

in bbp_widgets_init called at ? (?)
…ll_user_func_array called at /public_html/wp-includes/plugin.php (403)

…do_action called at /public_html/wp-includes/default-widgets.php (1181)

in wp_widgets_init called at ? (?)
…ll_user_func_array called at /public_html/wp-includes/plugin.php (403)

in do_action called at /public_html/wp-settings.php (302)

in require_once called at /public_html/wp-config.php (134)

in require_once called at /public_html/wp-load.php (29)

in require_once called at /public_html/wp-blog-header.php (12)

in require called at /public_html/index.php (17)

[nerrad]

looks like this applies to all bbPress widget calls. Would be better to declare all register_widget methods in the extended widgets as "static"?

[nerrad]

add static keyword to register_widget methods

[nerrad]

Added patch

[johnjamesjacoby]

Good catch. Haven't looked into why this isn't an issue for me on PHP5.4.

Moving to 2.2, as it's an easy fix.

[johnjamesjacoby]

(In [4432]) Widgets:

• Declare widget() methods as static.
• Fixes PHP notices for static method usages.
• Fixes #2030.

[johnjamesjacoby]

Props nerrad. Sorry I missed you in the commit message!