Skip to:
Content

Opened 6 years ago

Last modified 2 years ago

#1988 new enhancement

Pending Moderation template notice

Reported by: anointed Owned by:
Milestone: 2.7 Priority: normal
Severity: normal Version: 2.1
Component: API - Moderation Keywords: has-patch
Cc: jjjay@…

Description

On the WordPress settings->discussion tab you have a textfield where you can input a list of 'bad' words. I input a list of about 2,000 bad words into this field and it definitely works great.

There is a problem with bbPress though.

BbPress seems to check with the comments 'bad words' list when a user submits a new topic or reply. If there is a word in the list, it triggers the 'pending review' for the topic or reply, but the author is not notified in any way as to what happened.

How I found out:
I had a user send me a nasty email complaining about the new forum system 'bbPress' and how much they hated using it. They were telling me that basically anything they input into the box was not showing up when they clicked submit. Ultimately they ended up trying simple 1 word inputs and that worked.

As this is a LONG time moderator of mine who never complains, I went into the system to see what was happening. It turns out bbPress DOES have a 'Pending Review' status available and I found hundreds of topics and posts with this status. Obviously I have removed the 'bad words' from the moderation input.

Suggestion:
I don't want to loose the ability of filtering out 'bad' words, especially on a forum. I would suggest allowing the post to show up, but with a warning box letting the user know there is a problem with the post, and maybe highlighting the 'bad words/phrases'?

I had a vbulletin plugin that did this and it worked well. You could easily see what the problem was and fix it.

The way it is now, there is no warning. The post goes straight to awaiting review and does not say anything at all. Considering this was happening to my moderators who have virtual 'admin' access, this became even more confusing.

Not sure whether to call this a bug or a feature request. Leaving as a defect as it's horribly annoying.

screenshot:
https://dl.dropbox.com/u/2045194/bbpress-trac/moderation-issues.png

Attachments (3)

1988.sample.diff (3.0 KB) - added by tharsheblows 4 years ago.
1988.diff (3.6 KB) - added by tharsheblows 4 years ago.
display notices at the top of the page based on query string
1988.2.diff (7.0 KB) - added by thebrandonallen 3 years ago.

Download all attachments as: .zip

Change History (19)

#1 @alexvorn2
6 years ago

why not remove all bad words and use Akismet?

#2 follow-up: @anointed
6 years ago

because Akismet is an external service, and whether or not people want to admit it yet, there are some possible legal ramifications to sending customers data to external services for any reason without their full consent.

If you take a 'strict' reading of the law that was passed in Europe regarding customer data protection, then it is feasible that the website owner using services such as Akismet could potentially be held liable.

I am NOT an attorney but have read enough articles on this very problem, that for me at least, I choose NOT to take the chance and would rather keep this in house. I don't want to become the test case should people ever decide to sue over this. Call me paranoid... that's fine.

#3 in reply to: ↑ 2 @johnjamesjacoby
6 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Type changed from defect to enhancement

Replying to anointed:

because Akismet is an external service, and whether or not people want to admit it yet, there are some possible legal ramifications to sending customers data to external services for any reason without their full consent.

If you take a 'strict' reading of the law that was passed in Europe regarding customer data protection, then it is feasible that the website owner using services such as Akismet could potentially be held liable.

I am NOT an attorney but have read enough articles on this very problem, that for me at least, I choose NOT to take the chance and would rather keep this in house. I don't want to become the test case should people ever decide to sue over this. Call me paranoid... that's fine.

Akismet is unrelated to this since it's only for spam, and not for filtering based on WordPress settings. Regarding laws, that's a decision to be made by the site admin, and not by bbPress, WordPress, or any other software. Has nothing to do with "admitting" anything, it's just a choice you make for yourself.

I agree that the moderation flow of bbPress could be improved, but it will likely need to wait for a future release where Moderation is the major feature. Thankfully this code is pretty simple now, but decisions will need to be made about how much information to leak to the author about where their post went and why.

It's my experience that educating users that intend to violate your rules, find creative ways to work around them, either with no-break spaces, HTML formatting, or some other inventive method to circumvent the moderation logic. Having it be nondescript, and leaving it up to the moderation/admin team to review those posts and choose whether or not to publish them, seems the simplest approach for today.

Moving to future release, until we can put more energy towards moderation as a whole.

#4 @netweb
6 years ago

There is a new plugin that supports bbPress http://wordpress.org/extend/plugins/ultimate-wp-filter/

#5 @netweb
4 years ago

  • Milestone changed from Future Release to 2.6
  • Summary changed from comment 'bad word' moderation and bbPress to Pending Moderation template notice

Essentially the ticket #2589 was created to do what was proposed in this ticket and I've now marked it as a duplicate, moving this to 2.6 to replace that ticket :)

We should have a template notice for items that are 'Pending Moderation' to avoid the current default behaviour where no notice or reason is given for a forum, topic or reply that fails the bbp_check_for_moderation check.

"Your forum/topic/reply has been submitted successfully and is pending moderator approval"

Related: #2645 Add support to approve and unapprove pending topics and replies
Related: #2546 bbpress skips check for number of links if blacklist is empty

This ticket was mentioned in Slack in #bbpress by netweb. View the logs.


4 years ago

#7 @tharsheblows
4 years ago

Not sure if this is what / how you have it in mind but here is sample code with a filter function to show how I imagine it working. I haven't done any of the adding in of the query variables or anything like that, so if you get a chance, just have a look how it works by adding them on yourself to any single topic.

Use eg ?pending=1 to show the pending notice. test=something will show the test notice. The filter in bbp_functions.php puts a notice on every single topic page. As I said, it's just for illustration purposes to show how it works.

#8 @tharsheblows
4 years ago

  • Cc jjjay@… added

This ticket was mentioned in Slack in #bbpress by tharsheblows. View the logs.


4 years ago

#10 @tharsheblows
4 years ago

  • Keywords has-patch added

You can put the notice anywhere -- if you want it in the posting box, just change the action, although I'd also change the redirect to link to the form id rather than the top of the page.

@tharsheblows
4 years ago

display notices at the top of the page based on query string

This ticket was mentioned in Slack in #bbpress by tharsheblows. View the logs.


4 years ago

#12 @thebrandonallen
3 years ago

New patch, 1988.2.diff, adds a note about pending forums/topics/replies to the standard bbp_template_notices hook.

#13 @netweb
3 years ago

Related: #2573

#15 @netweb
3 years ago

Related: See meta:changeset:4216 for the current implementation on w.org

#16 @johnjamesjacoby
2 years ago

  • Milestone changed from 2.6 to 2.7

I missed this for 2.6, but would like to have a quick 2.7, so I'm going to move this out.

Note: See TracTickets for help on using tickets.