Skip to:
Content

bbPress.org

Opened 12 years ago

Closed 12 years ago

#1844 closed defect (bug) (fixed)

Issues with bbp_replace_the_content()

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.1 Priority: high
Severity: major Version: 2.0
Component: Appearance - Theme Compatibility Keywords:
Cc:

Description

In some wpcom testing, I uncovered the following issues with bbp_replace_the_content()

  • Theme compatibility makes it possible to run the 'the_content' filter inside an existing 'the_content' filter, which results in an infinite loop.
  • bbp_replace_the_content() does a global filter remove, which never gets readded.
  • Shortcodes do not correctly remove and re-add the 'bbp_replace_the_content' filter.
  • We're calling do_shortcode() in the shortcodes, which is also not needed.

Change History (1)

#1 @johnjamesjacoby
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3942]) Theme Compatibility:

  • Fix issues with 'the_content' and bbp_replace_the_content() causing infinite loops, duplicate filters, no filters, etc...
  • Add 'the_content' adds/removes to BBP_Shortcode where needed.
  • Remove unneeded calls to do_shortcode().
  • Fixes #1844.
Note: See TracTickets for help on using tickets.