Skip to:
Content

bbPress.org

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#1819 closed defect (fixed)

Topic replies are squashed on some themes

Reported by: NickMackz Owned by:
Milestone: 2.1.2 Priority: normal
Severity: normal Version: 2.1.1
Component: API - Actions/Filters Keywords: commit
Cc: nickmackz@…, stephen@…

Description

When using some themes (Custom Community is one), replies to forum topics are all squashed making them unreadable. This can fixed by adding this into bbpress.css. This makes all replies the correct height for their content. I suppose this would also need to be added to bbpress-rtl.css.

div.reply {
    height: auto;
}

Attachments (1)

1819.diff (860 bytes) - added by jaredatch 9 years ago.

Download all attachments as: .zip

Change History (12)

#1 @johnjamesjacoby
9 years ago

  • Keywords reporter-feedback added; has-patch removed

Don't suppose you have a site with this theme active I can see?

#2 @NickMackz
9 years ago

  • Keywords reporter-feedback removed

I am using it on http://talonstrikeforce.net with this 'fix' on an older version of 2.1 (about 2 weeks old). However the forums are members only. Feel free to register and I will approve you, or I can create you an account and PM you the password if you like.

#3 @NickMackz
9 years ago

  • Cc nickmackz@… added

#4 @johnjamesjacoby
9 years ago

This code change alone will be too far-reaching, since comments or any other thing might have a 'reply' class. Do you have any other alternative?

#5 @NickMackz
9 years ago

Changing it to

#bbpress-forums div.reply {
    height: auto;
}

should make it only apply to bbPress replies and not others.

#6 @johnjamesjacoby
9 years ago

  • Milestone changed from 2.1 to 2.2

I'm going to move this to 2.2. I haven't experienced any themes on WP.com with a height issue on replies in 2.1 dev, so my guess is it's a table layout issue that's already resolved.

@jaredatch
9 years ago

#8 @jaredatch
9 years ago

  • Keywords has-patch added

I haven't encountered this exact problem, but I have ran into similar issues with bbp-theme-compat. It's always weird CSS getting applied to .reply via the theme. This seems to be an easy preventative fix. If we see more issues in the forums it could be bumped to 2.1.2.

#9 @johnjamesjacoby
9 years ago

  • Keywords commit added; has-patch removed
  • Milestone changed from 2.2 to 2.1.2
  • Version set to 2.1.1

#10 @johnjamesjacoby
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4122]) Theme Compat:

  • Reset reply height to auto, to prevent conflicts with some themes.
  • Fixes #1819.
  • For 2.1 branch.
  • Props jaredatch.

#11 @johnjamesjacoby
9 years ago

(In [4123]) Theme Compat:

  • Reset reply height to auto, to prevent conflicts with some themes.
  • Fixes #1819.
  • For 2.2 branch.
  • Props jaredatch.
Note: See TracTickets for help on using tickets.