bbp_redirect_to_field() contains error in conditional statement

[mesayre]

This conditional statement, found in bbp-common-template.php, contains an error.

function bbp_redirect_to_field( $redirect_to = '' ) {
	
	// Rejig the $redirect_to
	if ( !isset( $_SERVER['REDIRECT_URL'] ) || ( !$redirect_to = home_url( $_SERVER['REDIRECT_URL'] ) ) )
		$redirect_to = wp_get_referer();

The assignment !$redirect_to = home_url() stomps on the value of $redirect_to and also makes the conditional return TRUE regardless of the content of $redirect_to

Should be:

if ( !isset( $_SERVER['REDIRECT_URL'] ) || ( !$redirect_to == home_url( $_SERVER['REDIRECT_URL'] ) ) )
		$redirect_to = wp_get_referer();

[cnorris23]

Good catch!

[johnjamesjacoby]

(In [3656]) Do not stomp the $redirect_to variable in bbp_redirect_to_field(). Props mesayre. Fixes #1709.