Skip to:
Content

Opened 6 years ago

Closed 5 years ago

Last modified 2 years ago

#1645 closed defect (fixed)

inappropriate logout or login filter redirect if wp installed in sub-folder

Reported by: michelwppi Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.0
Component: Appearance - Included Themes Keywords: has-patch
Cc: georgemamadashvili@…

Description

In very current basic situation like WP url and Home url is like

http://Michel-I3-iMac.local:8888/wp_3_bbp

Visible in current WP meta widget and in BBP login widget
the bbp_logout_url function called by bbpress plugin filter logout_url don't work properly. Inapropriate twice sub-folder inserted (here wp_3_bbp 2 time)

http://Michel-I3-iMac.local:8888/wp_3_bbp/wp-login.php?action=logout&_wpnonce=789fd19838&redirect_to=http%3A%2F%2FMichel-I3-iMac.local%3A8888%2Fwp_3_bbp%2Fwp_3_bbp%2F%3Fforum%3Dforum-eleven%26loggedout%3Dtrue

general settings of WP not tested by this filter.

Attachments (1)

1645.diff (717 bytes) - added by Mamaduka 6 years ago.

Download all attachments as: .zip

Change History (12)

#1 @binhdo
6 years ago

I would like to confirm this issue.

wp-url (home_url): http://localhost/wpdev/

bbpress logout redirects to: http://localhost/wpdev/wpdev/?loggedout=true

#2 @johnjamesjacoby
6 years ago

  • Component changed from Administration to Included Themes
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 2.1

#3 @johnjamesjacoby
6 years ago

  • Milestone changed from 2.1 to 2.0.1

#4 @cnorris23
6 years ago

Likely related #1662

#5 @Mamaduka
6 years ago

  • Cc georgemamadashvili@… added

I did small testing and I think problem is with

$_SERVER['REQUEST_URI']

it's passed as $path argument in home_url(), below is output of home_url without

http://localhost/bbpress

and with REQUEST_URI

http://localhost/bbpress/bbpress/wp-admin/

We need something more clever to get request URI, till then we can redirect users to wp-login.php how WordPress does

@Mamaduka
6 years ago

#6 @Mamaduka
6 years ago

  • Keywords has-patch added; needs-patch removed

There was similar bug with wp_logout_from redirect - http://core.trac.wordpress.org/ticket/17243

I created patch using solution by kawauso

#7 @johnjamesjacoby
6 years ago

  • Milestone changed from 2.0.1 to 2.1

#8 @johnjamesjacoby
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3626]) Fix subfolder redirect issue on login/logout. Fixes #1645. Props !Mamaduka.

#9 follow-up: @michelwppi
5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I begin to test 2.1 (r3773) on localhost. When creating a topic and clicking submit button in this url : http://Michel-I5-iMac.local:8888/wp_archi_hos/?forum=architectes. The submission faults because the link is : http://michel-i5-imac.local:8888/wp_archi_hos/wp_archi_hos/?forum=architectes - the sub-folder - wp_archi_hos - is repeated TWICE... If permalinks is activated, the browser display nothing because recursive redirection issues.
The title could be - sub-folder repeated twice with redirection issues -

#10 in reply to: ↑ 9 @johnjamesjacoby
5 years ago

  • Milestone 2.1 deleted
  • Resolution set to fixed
  • Status changed from reopened to closed

Replying to michelwppi:

I begin to test 2.1 (r3773) on localhost. When creating a topic and clicking submit button in this url : http://Michel-I5-iMac.local:8888/wp_archi_hos/?forum=architectes. The submission faults because the link is : http://michel-i5-imac.local:8888/wp_archi_hos/wp_archi_hos/?forum=architectes - the sub-folder - wp_archi_hos - is repeated TWICE... If permalinks is activated, the browser display nothing because recursive redirection issues.
The title could be - sub-folder repeated twice with redirection issues -

This ticket is specifically for logging in, not for content creation. Reclosing this ticket.

Also, it's unclear exactly how to recreate your setup so that we can duplicate the situation. If you could include more details in your new ticket would be great. Thanks!

This ticket was mentioned in Slack in #bbpress by robkk. View the logs.


2 years ago

Note: See TracTickets for help on using tickets.