Skip to:
Content

bbPress.org

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#1631 closed defect (fixed)

Last active forum and topic activity shows authors' replies even when marked as spam

Reported by: grantnorwood Owned by:
Milestone: 2.0 Priority: normal
Severity: normal Version:
Component: Component - Replies Keywords: has-patch needs-testing
Cc: grantnorwood

Description

When comment/post spam is caught by Akismet, those posts and comments are hidden from view appropriately, except that the author info of a reply marked as spam is still shown as the last activity for a forum or topic. The issue exists in the WordPress plugin v2.0-rc-4, but I have not tested this with a standalone instance of bbPress.

Deleting replies marked as spam from wp-admin resets the last active author info so that it is shown correctly.

Looks like we need to either not run the forum update handler upon posting if it fails Akismet, or properly exclude replies with status "spam" when calculating the forum and topic replies.

Attachments (3)

2011-09-07_1427_-_bbPress_screen_shot_-_spam_author_shown_as_last_active.png (44.4 KB) - added by grantnorwood 10 years ago.
Forum page screen shot with incorrect last author displayed
2011-09-07_1429_-_bbPress_screen_shot_-_topic_shows_spam_author_as_last_active.png (79.6 KB) - added by grantnorwood 10 years ago.
Topic page screen shot with incorrect last author displayed
1631.patch (17.6 KB) - added by johnjamesjacoby 10 years ago.

Download all attachments as: .zip

Change History (9)

@grantnorwood
10 years ago

Forum page screen shot with incorrect last author displayed

@grantnorwood
10 years ago

Topic page screen shot with incorrect last author displayed

#1 @cnorris23
10 years ago

Are you saying this _only_ happens when deleting from the dashboard, or that you noticed it there? If the latter, are things still in correct when deleting from the frontend? This will help better track the issue.

#2 @johnjamesjacoby
10 years ago

This happens when Akismet catches the topic/reply as spam.

It works correctly when you mark it as spam manually as an admin/moderator.

#3 @johnjamesjacoby
10 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

Attached patch took more work than I thought it would, which means there is possibly a more elegant way to do this. It adds a few functions to check the published status of topics and replies, and adds some checks on the updater functions to make sure nothing is updated that shouldn't be.

#4 @johnjamesjacoby
10 years ago

  • Milestone changed from Awaiting Review to 2.0
  • Version 2.0 deleted

#5 @johnjamesjacoby
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3501]) Fix issue when topics and replies are flagged as spam/trash where they would still update last active data for ancestors. Fixes #1631.
Fix issue when trashing and deleting a topic, replies may not be properly queried and updated. Fixes #1629.

#6 @grantnorwood
10 years ago

Thanks, John! I pulled the latest /branches/plugin down, and it looks good in my initial round of testing. Now, submitting obviously spammy topics and replies results in the spam being caught by Akismet and marked as "spam" correctly, and the topic and reply counts no longer show the spam's author info as "last active".

It indeed looks like you had to take a longer route to get this fix but I very much appreciate your work!

I apologize for being new to the workflow, though I've quickly read through the docs. I didn't see a tag for "tested-ok" or anything, but I can verify the initial issue reported seems to be fixed.

Note: See TracTickets for help on using tickets.