Last active forum and topic activity shows authors' replies even when marked as spam

[grantnorwood]

When comment/post spam is caught by Akismet, those posts and comments are hidden from view appropriately, except that the author info of a reply marked as spam is still shown as the last activity for a forum or topic. The issue exists in the WordPress plugin v2.0-rc-4, but I have not tested this with a standalone instance of bbPress.

Deleting replies marked as spam from wp-admin resets the last active author info so that it is shown correctly.

Looks like we need to either not run the forum update handler upon posting if it fails Akismet, or properly exclude replies with status "spam" when calculating the forum and topic replies.

[grantnorwood]

Forum page screen shot with incorrect last author displayed

[grantnorwood]

Topic page screen shot with incorrect last author displayed

[cnorris23]

Are you saying this _only_ happens when deleting from the dashboard, or that you noticed it there? If the latter, are things still in correct when deleting from the frontend? This will help better track the issue.

[johnjamesjacoby]

This happens when Akismet catches the topic/reply as spam.

It works correctly when you mark it as spam manually as an admin/moderator.

[johnjamesjacoby]

Attached patch took more work than I thought it would, which means there is possibly a more elegant way to do this. It adds a few functions to check the published status of topics and replies, and adds some checks on the updater functions to make sure nothing is updated that shouldn't be.

[johnjamesjacoby]

(In [3501]) Fix issue when topics and replies are flagged as spam/trash where they would still update last active data for ancestors. Fixes #1631.
Fix issue when trashing and deleting a topic, replies may not be properly queried and updated. Fixes #1629.

[grantnorwood]

Thanks, John! I pulled the latest /branches/plugin down, and it looks good in my initial round of testing. Now, submitting obviously spammy topics and replies results in the spam being caught by Akismet and marked as "spam" correctly, and the topic and reply counts no longer show the spam's author info as "last active".

It indeed looks like you had to take a longer route to get this fix but I very much appreciate your work!

I apologize for being new to the workflow, though I've quickly read through the docs. I didn't see a tag for "tested-ok" or anything, but I can verify the initial issue reported seems to be fixed.