Skip to:
Content

bbPress.org

Opened 14 years ago

Closed 14 years ago

#1227 closed enhancement (fixed)

In Topic.php, posters' name should be hyperlinked to profiles by default

Reported by: grassrootspa's profile grassrootspa Owned by:
Milestone: 1.1 Priority: normal
Severity: minor Version: 1.0.2
Component: Front-end Keywords: has-patch tested
Cc: nightgunner5@…, matveb

Description

On the topic discussion pages (topic.php) posters' names are not hyperlinked to their respective profiles by default.

This makes very little sense. The most obvious place/situation where one would be tempted to look at a posters' profile is right after reading a post they have made under a topic thread.

One cannot do that if the poster's name is not hyperlinked to their profile!

Attachments (3)

1227.patch (2.1 KB) - added by Nightgunner5 14 years ago.
Allow users to decide whether the name and avatar should link to the profile or the website.
1227-rel.diff (2.1 KB) - added by matveb 14 years ago.
1277.diff (3.9 KB) - added by GautamGupta 14 years ago.
Better Patch

Download all attachments as: .zip

Change History (13)

#1 @Nightgunner5
14 years ago

  • Cc nightgunner5@… added
  • Resolution set to invalid
  • Status changed from new to closed

Click on their title, for example "Member".

The username is linked to their website by default.

#2 @grassrootspa
14 years ago

I understand where you are coming from nightgunner5, but doesn't it make much more sense to hyperlink the user name to the profile rather than hyperlink their title to their profile?

The current setup doesn't make very much sense to me. Take Facebook for example: when two people have a wall exchange you click on a person's name to get to their profile, not something else. Same with Twitter. It makes little sense not to hyperlink a poster's name so it leads to their profile.

An outside observer would probably expect the title to go to a page explaining the title rather than the profile.

Follow me?

#3 @grassrootspa
14 years ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

@Nightgunner5
14 years ago

Allow users to decide whether the name and avatar should link to the profile or the website.

#4 @Nightgunner5
14 years ago

  • Keywords has-patch added

@matveb
14 years ago

#5 @matveb
14 years ago

+ 1 for implementing this.

Corrected the relationship (website was pointing to profile and viceversa) and changed the order to Website first.

#6 @matveb
14 years ago

  • Cc matveb added
  • Keywords dev-feedback added

#7 @kevinjohngallagher
14 years ago

  • Severity changed from normal to minor
  • Type changed from defect to enhancement

#8 @GautamGupta
14 years ago

  • Keywords topic.php profile link poster removed
  • Version changed from 1.0.1 to 1.0.2

@GautamGupta
14 years ago

Better Patch

#9 @GautamGupta
14 years ago

  • Keywords tested added; dev-feedback removed

The patch by NightGunner5 edited the gravatar link which I think the ticket doesn't intend to do. I have attached another patch which also has some fixes for the settings page, a note about the new option (telling what would it do) and correcting the place of link.

#10 @chrishajer
14 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [2431]) Link author's name to their profile page in topic.php. Fixes #1227. Props grassrootspa for the report, Nightgunner5 for the first path, GautamGupta for the final patch

Note: See TracTickets for help on using tickets.