Skip to:
Content

bbPress.org

Opened 17 years ago

Closed 16 years ago

#1185 closed defect (bug) (fixed)

throttle_time missing from admin menu

Reported by: _ck_'s profile _ck_ Owned by: chrishajer's profile chrishajer
Milestone: 1.0.3 Priority: normal
Severity: normal Version: 1.0.2
Component: General - Administration Keywords: has-patch tested
Cc:

Description

There is no way to change the throttle_time option from the admin menu and probably should be under writing options.

Attachments (2)

throttle_time-admin.diff (2.7 KB) - added by Nightgunner5 17 years ago.
Patch including both throttle_time option and some code standards cleanup
throttle-time-admin-revised-message.diff (2.8 KB) - added by chrishajer 16 years ago.
Changed capitalization for role titles

Download all attachments as: .zip

Change History (18)

@Nightgunner5
17 years ago

Patch including both throttle_time option and some code standards cleanup

#1 @Nightgunner5
17 years ago

  • Keywords has-patch added

#2 @sambauers
17 years ago

  • Milestone set to 1.0.3

I don't remember this being in the old admin screens. Does it really need to be in there?

#4 follow-up: @chrishajer
16 years ago

I applied this patch to my local installation, and it works (at least the display of the option, and the new setting being displayed when you edit a user is displayed). But I am concerned the language "A user without the throttle ability must wait this many seconds before posting again" is unclear. I didn't really understand what it meant.

Does anyone have a suggestion for language that is more clear? I mean, what does this mean in plain English? Just seems unclear to me.

#5 @chrishajer
16 years ago

Tested and it looks like my new setting of 60 seconds worked fine to prevent people from posting too quickly.

#6 @chrishajer
16 years ago

  • Owner set to chrishajer
  • Status changed from new to assigned

#7 in reply to: ↑ 4 @GautamGupta
16 years ago

Replying to chrishajer:

But I am concerned the language "A user without the throttle ability must wait this many seconds before posting again" is unclear. I didn't really understand what it meant.
Does anyone have a suggestion for language that is more clear? I mean, what does this mean in plain English? Just seems unclear to me.

Maybe "A user who does not have the throttle ability would have to wait for above mentioned seconds before posting another post."

#8 @GautamGupta
16 years ago

  • Keywords tested added

#9 follow-up: @chrishajer
16 years ago

I'm not sold on that wording either. Since "throttle ability" isn't really defined anywhere, that's the part that's confusing to me, I think. Who has throttle ability? And is it really throttle ability? It's the permission to avoid being throttled, right?

This wording still doesn't seem helpful to me.

#10 in reply to: ↑ 9 @GautamGupta
16 years ago

Replying to chrishajer:

I'm not sold on that wording either. Since "throttle ability" isn't really defined anywhere, that's the part that's confusing to me, I think. Who has throttle ability? And is it really throttle ability? It's the permission to avoid being throttled, right?

This wording still doesn't seem helpful to me.

Ok, here is a better version:

A user who can not bypass the throttling limit would have to wait for above mentioned seconds before posting another post.

Throttling limit is on the profile edit page where it is writting "Allow this user to [checkbox] Ignore the xx second post throttling limit"

#11 @GautamGupta
16 years ago

  • Component changed from Back-end to Administration

#12 @chrishajer
16 years ago

I was unable to replace the original patch (not enough permission). This message has just one line changed, the message to the user on the admin screen.

#13 @chrishajer
16 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

oops, forgot to put the ticket number in the commit message

#14 @chrishajer
16 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

oh, never mind. I didn't commit this. Please review the wording

#15 @GautamGupta
16 years ago

That's fine, but you make lower case the first letter of "Moderators, Administrators and Keymasters".

@chrishajer
16 years ago

Changed capitalization for role titles

#16 @chrishajer
16 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [2417]) Add throttle time setting to Options Writing admin screen. Fixes #1185. Props Nightgunner5, _ck_

Note: See TracTickets for help on using tickets.