Skip to:
Content

bbPress.org

Opened 17 years ago

Closed 17 years ago

Last modified 2 years ago

#1024 closed defect (bug) (fixed)

Unable to translate some strings and some missing label tags

Reported by: erkoristhein's profile Erko.Risthein Owned by:
Milestone: 1.0 Priority: normal
Severity: normal Version: 1.0-rc-2
Component: Locale - i18n/l10n Keywords: has-patch
Cc:

Description

See the path.

Attachments (10)

options-wordpress.diff​ (490 bytes) - added by Erko.Risthein 17 years ago.
Adds gettext
options-general.diff​ (786 bytes) - added by Erko.Risthein 17 years ago.
admin-header.diff​ (521 bytes) - added by Erko.Risthein 17 years ago.
site.diff​ (1.0 KB) - added by Erko.Risthein 17 years ago.
The linebreaks prevent the string being translated.
functions.bb-template.diff​ (2.0 KB) - added by Erko.Risthein 17 years ago.
functions.bb-template.2.diff​ (2.4 KB) - added by Erko.Risthein 17 years ago.
class.bb-install.diff​ (812 bytes) - added by Erko.Risthein 17 years ago.
Make the string match with the other ones (one in class.bb-install and other in options-wordpress)
bb-admin.index.diff​ (428 bytes) - added by Erko.Risthein 17 years ago.
functions.bb-admin.diff​ (600 bytes) - added by Erko.Risthein 17 years ago.
bb-settings.diff​ (917 bytes) - added by Erko.Risthein 17 years ago.

Download all attachments as: .zip

Change History (21)

@Erko.Risthein
17 years ago

Adds gettext

#1 @Erko.Risthein
17 years ago

  • Summary changed from Unable to translate user roles in options-wordpress.php to Unable to translate some strings

@Erko.Risthein
17 years ago

@Erko.Risthein
17 years ago

@Erko.Risthein
17 years ago

The linebreaks prevent the string being translated.

#2 @Erko.Risthein
17 years ago

  • Summary changed from Unable to translate some strings to Unable to translate some strings and some missing label tags

@Erko.Risthein
17 years ago

@Erko.Risthein
17 years ago

@Erko.Risthein
17 years ago

Make the string match with the other ones (one in class.bb-install and other in options-wordpress)

@Erko.Risthein
17 years ago

#3 @Erko.Risthein
17 years ago

  • Keywords has-patch added

@Erko.Risthein
17 years ago

#4 @Erko.Risthein
17 years ago

  • Milestone changed from 1.0 to 1.0-beta & XML-RPC

#5 @sambauers
17 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [1910]) Glorious gettext from Erko.Risthein, fixes #1024

#6 @sambauers
17 years ago

The roles are translated in bb-includes/functions.bb-capabilities.php in the function bb_init_roles()

Things like this...

_e( $foo );

... are generally not required and are to be avoided due to their incompatibility with our .pot file creation tools.

#7 @Erko.Risthein
17 years ago

Thanks for the info! :)

#8 @Erko.Risthein
17 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I figured out why the roles are not translated. It's because the localisation gets initialised AFTER the BP_Roles, so the gettext functions don't yet work. So the localisation should be initialised earlier (BEFORE BP_Roles) - that fixes the problem.
See the patch.

@Erko.Risthein
17 years ago

#9 @sambauers
17 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [1920]) Load localisation earlier. Fixes #1024. Props Erko.Risthein

#10 @(none)
16 years ago

  • Milestone 1.0-beta deleted

Milestone 1.0-beta deleted

#11 @sambauers
16 years ago

  • Milestone set to 1.0
Note: See TracTickets for help on using tickets.