Skip to:
Content

Opened 5 years ago

Closed 5 years ago

#2491 closed enhancement (fixed)

Add forum Open/Close Backend Row Actions

Reported by: netweb Owned by: netweb
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.5.1
Component: General - Administration Keywords: has-patch commit
Cc:

Description

Include the ability to open and close forums via the backend forum admin row action links.

Attachments (3)

2491.diff (8.0 KB) - added by netweb 5 years ago.
2491.png (33.4 KB) - added by netweb 5 years ago.
2491.2.diff (8.3 KB) - added by netweb 5 years ago.

Download all attachments as: .zip

Change History (7)

@netweb
5 years ago

@netweb
5 years ago

#1 follow-up: @johnjamesjacoby
5 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 2.6

Looks good. A few things:

  • Let's always use brackets goings forward, to match WordPress's updated code styling.
  • Is 'moderate' the correct capability? I think forums are limited to 'keep_gate'
  • We may want to avoid the long ternaries and use if/else blocks for the notice strings.

With those updates, let's commit this into 2.6.

@netweb
5 years ago

#2 in reply to: ↑ 1 @netweb
5 years ago

Replying to johnjamesjacoby:

Let's always use brackets goings forward, to match WordPress's updated code styling.

My bad, I should have done that in the first place

Is 'moderate' the correct capability? I think forums are limited to 'keep_gate'

Yep, fixed, updated to keep_gate

We may want to avoid the long ternaries and use if/else blocks for the notice strings.

Avoid the what? Go's and googles 'ternaries', ah those things

Refreshes patch... in 2491.2.diff fixes per above.

#3 @netweb
5 years ago

  • Owner set to netweb
  • Status changed from new to assigned

#4 @netweb
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 5254:

Include backend admin open and close forum row actions. Props netweb. Fixes #2491.

Note: See TracTickets for help on using tickets.