Changeset 7467 for trunk/src/includes/common/engagements.php

Timestamp:

09/10/2026 12:35:43 AM (2 weeks ago)

Author:

johnjamesjacoby

Message:

Counts: synchronize metadata across concurrent writes.

Introduce bbp_bump_count_meta() to update existing numeric metadata with bounded compare-and-swap retries while preserving WordPress metadata filters, actions, sanitization, and cache invalidation. Apply atomic differences to forum, topic, reply, ancestor, and user contribution counts.

Reconcile counts, engagements, and voices across status transitions, permanent deletion, author changes and reassignment, moderator move/merge/split operations, and repair recounts. Correct recursive forum totals and reply visibility, and preserve term-backed favorites and subscriptions during engagement rebuilds.

Document the count-hook compatibility changes and new helper arguments, and add regression coverage for single-site and multisite workflows.

In trunk, for 2.7.

Props alex-ye.
Fixes #2233.
Fixes #3678.

File:

• trunk/src/includes/common/engagements.php (modified) (2 diffs)

trunk/src/includes/common/engagements.php

@@ -430 +430 @@
          *
          * @since 2.6.0 bbPress (r6737)
+         * @since 2.6.16 Limit removal to the requested relationship taxonomy.
          *
          * @param int    $object_id The object id.
@@ -439 +440 @@
          */
         public function remove_object_from_all_users( $object_id = 0, $meta_key = '', $meta_type = 'post' ) {
-                return wp_delete_object_term_relationships( $object_id, get_object_taxonomies( 'bbp_user' ) );
+                $tax_key = "{$meta_key}_{$meta_type}";
+                $this->jit_taxonomy( $tax_key );
+
+                return wp_delete_object_term_relationships( $object_id, $tax_key );
         }