Changeset 7272 for branches/2.6/src/includes/forums/functions.php

Timestamp:

06/29/2024 04:51:33 PM (15 months ago)

Author:

johnjamesjacoby

Message:

Forums: bail out of pre_get_posts if empty post_type parameter

This change addresses a regression inside of bbp_pre_get_posts_normalize_forum_visibility that was unintentionally targeting posts queries that were not sourced from the ones built into bbPress (forum/topic/reply), causing the majority of non-bbPress queries to return empty results.

Fixes #3601.

In branches/2.6, for 2.6.11.

File:

• branches/2.6/src/includes/forums/functions.php (modified) (2 diffs)

branches/2.6/src/includes/forums/functions.php

@@ -2317 +2317 @@
     $post_types = array_filter( (array) $posts_query->get( 'post_type' ) );
 
+    // Bail if no post types to normalize
+    if ( empty( $post_types ) ) {
+        return;
+    }
+
     // Forums
     if ( in_array( bbp_get_forum_post_type(), $post_types, true ) ) {
@@ -2342 +2347 @@
     }
 
-    // Some other post type besides Forums, Topics, or Replies
+    // Any bbPress post type
     if ( ! array_diff( $post_types, bbp_get_post_types() ) ) {