Changeset 7255 for branches/2.6/src/includes/topics/functions.php

Timestamp:

06/23/2024 08:27:45 PM (15 months ago)

Author:

johnjamesjacoby

Message:

Topic/Reply: improvements to status updates.

This change includes 2 fixes:

• Prefer $topic_id over $topic->ID, and use it (instead of $forum_id) when checking for moderation capability
• Add missing logic in bbp_edit_reply_handler() that was preventing statuses from saving as intended

See #2644.

In branches/2.6, for 2.6.10.

File:

• branches/2.6/src/includes/topics/functions.php (modified) (2 diffs)

branches/2.6/src/includes/topics/functions.php

@@ -580 +580 @@
 
     // Maybe force into pending
-    if ( bbp_is_topic_public( $topic->ID ) && ! bbp_check_for_moderation( $anonymous_data, $topic_author, $topic_title, $topic_content ) ) {
+    if ( bbp_is_topic_public( $topic_id ) && ! bbp_check_for_moderation( $anonymous_data, $topic_author, $topic_title, $topic_content ) ) {
         $topic_status = bbp_get_pending_status_id();
 
@@ -587 +587 @@
 
         // Allow capable users to explicitly override the status
-        if ( current_user_can( 'moderate', $forum_id ) ) {
+        if ( current_user_can( 'moderate', $topic_id ) ) {
             $topic_status = sanitize_key( $_POST['bbp_topic_status'] );