Changeset 7220 for trunk/src/includes/common/template.php

Timestamp:

11/19/2021 04:04:05 PM (3 years ago)

Author:

johnjamesjacoby

Message:

Appearance: only add no-js body class on bbPress pages.

This change addresses a regression introduced in r7190, causing the bbpress body class to unintentionally be added to all pages triggering layout issues in some WordPress themes.

This commit makes sure that the bbpress body class is only added when intended, and moves the no-js body class into the same conditional check.

In trunk for 2.7. See #3443.

File:

• trunk/src/includes/common/template.php (modified) (2 diffs)

trunk/src/includes/common/template.php

@@ -966 +966 @@
  * @return array Body Classes
  */
-function bbp_body_class( $wp_classes, $custom_classes = false ) {
-
-    // Default classes
-    $bbp_classes = array( 'no-js' );
+function bbp_body_class( $wp_classes = array(), $custom_classes = false ) {
+
+    // Default to no classes
+    $bbp_classes = array();
 
     /** Archives **************************************************************/
@@ -1078 +1078 @@
     }
 
-    /** Clean up **************************************************************/
-
-    // Add bbPress class if we are within a bbPress page
+    /** General ***************************************************************/
+
+    // Any page with bbPress content
     if ( ! empty( $bbp_classes ) ) {
         $bbp_classes[] = 'bbpress';
-    }
+        $bbp_classes[] = 'no-js';
+    }
+
+    /** Clean up **************************************************************/
 
     // Merge WP classes with bbPress classes and remove any duplicates