Changeset 6923 for trunk/src/includes/common/functions.php

Timestamp:

11/09/2019 05:35:42 AM (5 years ago)

Author:

johnjamesjacoby

Message:

Counts (meta-data): full audit of forum/topic/reply, public/non-public counts.

This commit is the result of a full count audit, exposing multiple inconsistencies and voids in relation to how public and non-public counts are (re)calculated.

For instance, hidden forum replies are not counted at all, until now. By introducing a new Repair tool, hidden forum reply counts are now counted.

In addition, there were multiple bugs with topic & reply moderation, where the act of approving or unapproving topics or replies would cause the numbers to be inaccurate, or where topics & replies being caught in moderation were still increasing public counts.

It was also possible to, as a Key Master, publicly reply to unapproved topics, which was a completely unanticipated side-effect of allowing Key Masters to do pretty much anything. Going forward, the default reply status is the topic status, but is still beholden to all existing moderation settings and user role capabilities. This results in a more sane user experience, and prevents the unusual circumstance of there being "0 topics and 30 replies" in public-facing forums.

Certain count increase/decrease actions have been reprioritized to avoid collisions and race conditions, proving once again that ya gotta get up to get down.

See #2838. Fixes #1799.

File:

• trunk/src/includes/common/functions.php (modified) (2 diffs)

trunk/src/includes/common/functions.php

@@ -1664 +1664 @@
     }
 
-    // Get the public posts status
-    $post_status = array( bbp_get_public_status_id() );
-
-    // Add closed status if topic post type
-    if ( bbp_get_topic_post_type() === $post_type ) {
-        $post_status[] = bbp_get_closed_status_id();
+    // Which statuses
+    switch ( $post_type ) {
+
+        // Forum
+        case bbp_get_forum_post_type() :
+            $post_status = bbp_get_public_forum_statuses();
+            break;
+
+        // Topic
+        case bbp_get_topic_post_type() :
+            $post_status = bbp_get_public_topic_statuses();
+            break;
+
+        // Reply
+        case bbp_get_reply_post_type() :
+        default :
+            $post_status = bbp_get_public_reply_statuses();
+            break;
     }
 
@@ -1823 +1835 @@
         // Forum
         case bbp_get_forum_post_type() :
-            $post_status = array( bbp_get_public_status_id() );
+            $post_status = bbp_get_public_forum_statuses();
             break;