Changeset 6869 for trunk/src/includes/admin/settings.php

Timestamp:

10/12/2018 05:07:51 PM (6 years ago)

Author:

johnjamesjacoby

Message:

Edit Locking Improvements:

• Refactor to avoid doing unnecessary computations
• Invert default return value from false to true, requiring time to pass validation as opposed to assuming
• Improve obviousness of math computations for easier debuggability
• Update variables passed into the end return filter
• Add 6 unit tests for before/on/after, plus support for "0" as infinite
• Fix bug causing "0" values to return the opposite value
• Ensure only gmt/utc values are compared
• Add optional flag to use WordPress time instead
• Improve inline and function documentation

Fixes #3222. Props wpdennis.

File:

• trunk/src/includes/admin/settings.php (modified) (4 diffs)

trunk/src/includes/admin/settings.php

@@ -661 +661 @@
     </label>
     <label for="_bbp_edit_lock">
-        <input name="_bbp_edit_lock" id="_bbp_edit_lock" type="number" min="0" step="1" value="<?php bbp_form_option( '_bbp_edit_lock', '0' ); ?>" class="small-text"<?php bbp_maybe_admin_setting_disabled( '_bbp_edit_lock' ); ?> />
+        <input name="_bbp_edit_lock" id="_bbp_edit_lock" type="number" min="0" step="1" value="<?php bbp_form_option( '_bbp_edit_lock', '5' ); ?>" class="small-text"<?php bbp_maybe_admin_setting_disabled( '_bbp_edit_lock' ); ?> />
 
     <?php $select = ob_get_clean(); ?>
@@ -1945 +1945 @@
      * @param string $option
      * @param string $default
-     * @param bool $slug
+     * @param bool   $is_slug
+     *
+     * @return mixed
      */
-    function bbp_get_form_option( $option, $default = '', $slug = false ) {
+    function bbp_get_form_option( $option, $default = '', $is_slug = false ) {
 
         // Get the option and sanitize it
@@ -1953 +1955 @@
 
         // Slug?
-        if ( true === $slug ) {
+        if ( true === $is_slug ) {
             $value = esc_attr( apply_filters( 'editable_slug', $value ) );
 
@@ -1967 +1969 @@
 
         // Filter & return
-        return apply_filters( 'bbp_get_form_option', $value, $option );
+        return apply_filters( 'bbp_get_form_option', $value, $option, $default, $is_slug );
     }