Changeset 6585 for trunk/tests/phpunit/testcases/admin/tools.php

Timestamp:

06/19/2017 05:05:18 AM (8 years ago)

Author:

johnjamesjacoby

Message:

Cache: make bbp_clean_post_cache() an action-only function.

Instead of calling bbp_clean_post_cache() directly, we'll call clean_post_cache() as per normal and hook bbp_clean_post_cache() to the end of it. This reduces a bunch of superfluous cache invalidation from occurring back-to-back.

We'll also only ever update the last_changed cache key when we've reached the forum-root. This makes sure that subsequent recursive calls up the post_parent tree are dealing with the same last_changed value until the end.

This change will reduce the number of cache invalidation calls by a large amount, improving functional performance for database writes to the post & postmeta tables.

File:

• trunk/tests/phpunit/testcases/admin/tools.php (modified) (3 diffs)

trunk/tests/phpunit/testcases/admin/tools.php

@@ -161 +161 @@
         bbp_admin_repair_topic_voice_count();
 
-        bbp_clean_post_cache( $t );
+        clean_post_cache( $t );
 
         $count = bbp_get_topic_voice_count( $t );
@@ -215 +215 @@
         bbp_admin_repair_topic_hidden_reply_count();
 
-        bbp_clean_post_cache( $t );
+        clean_post_cache( $t );
 
         $count = bbp_get_topic_reply_count_hidden( $t, true );
@@ -662 +662 @@
         bbp_admin_repair_forum_meta();
 
-        bbp_clean_post_cache( $f );
-        bbp_clean_post_cache( $t );
-        bbp_clean_post_cache( $r );
+        clean_post_cache( $f );
+        clean_post_cache( $t );
+        clean_post_cache( $r );
 
         // Forums should NOT have a _bbp_forum_id meta key