Changeset 6415 for trunk/src/includes/replies/functions.php

Timestamp:

05/19/2017 03:25:37 AM (7 years ago)

Author:

johnjamesjacoby

Message:

in_array(): be strict whenever possible.

Use wp_parse_id_list() on certain array values to ensure proper results.

File:

• trunk/src/includes/replies/functions.php (modified) (2 diffs)

trunk/src/includes/replies/functions.php

@@ -1213 +1213 @@
 
                 // Loop detection: If the ancestor has been seen before, break.
-                if ( empty( $ancestor->post_parent ) || ( $grampy_id === $reply_id ) || in_array( $grampy_id, $ancestors ) ) {
+                if ( empty( $ancestor->post_parent ) || ( $grampy_id === $reply_id ) || in_array( $grampy_id, $ancestors, true ) ) {
                     break;
                 }
@@ -1352 +1352 @@
 
     // Invalid move option
-    if ( empty( $move_option ) || ! in_array( $move_option, array( 'existing', 'topic' ) ) ) {
+    if ( empty( $move_option ) || ! in_array( $move_option, array( 'existing', 'topic' ), true ) ) {
         bbp_add_error( 'bbp_move_reply_option', __( '<strong>ERROR</strong>: You need to choose a valid move option.', 'bbpress' ) );