Changeset 5850

Timestamp:

07/15/2015 10:17:40 PM (9 years ago)

Author:

johnjamesjacoby

Message:

Admin: Add hidden_post_status field back to topic & reply metaboxes, and use draft or current post status as value.

This changeset fixes a bug that caused topics & replies to be marked as edited when moderated via wp-admin.

Hat-tip tharsheblows. Fixes #2741.

Location:

trunk/src/includes/admin

Files:

• metaboxes.php (modified) (4 diffs)
• replies.php (modified) (1 diff)
• topics.php (modified) (1 diff)

trunk/src/includes/admin/metaboxes.php

@@ -392 +392 @@
     // Post ID
     $post_id = get_the_ID();
+    $status  = get_post_status( $post_id );
 
     /** Type ******************************************************************/
@@ -411 +412 @@
     <p>
         <strong class="label"><?php esc_html_e( 'Status:', 'bbpress' ); ?></strong>
+        <input type="hidden" name="hidden_post_status" id="hidden_post_status" value="<?php echo esc_attr( ( 'auto-draft' === $status ) ? 'draft' : $status ); ?>" />
         <label class="screen-reader-text" for="bbp_open_close_topic"><?php esc_html_e( 'Select whether to open or close the topic.', 'bbpress' ); ?></label>
         <?php bbp_form_topic_status_dropdown( array( 'select_id' => 'post_status', 'topic_id' => $post_id ) ); ?>
@@ -467 +469 @@
     // Post ID
     $post_id = get_the_ID();
+    $status  = get_post_status( $post_id );
 
     // Get some meta
@@ -479 +482 @@
     <p>
         <strong class="label"><?php esc_html_e( 'Status:', 'bbpress' ); ?></strong>
+        <input type="hidden" name="hidden_post_status" id="hidden_post_status" value="<?php echo esc_attr( ( 'auto-draft' === $status ) ? 'draft' : $status ); ?>" />
         <label class="screen-reader-text" for="post_status"><?php esc_html_e( 'Select what status to give the reply.', 'bbpress' ); ?></label>
         <?php bbp_form_reply_status_dropdown( array( 'select_id' => 'post_status', 'reply_id' => $post_id ) ); ?>

trunk/src/includes/admin/replies.php

@@ -322 +322 @@
         $anonymous_data = bbp_filter_anonymous_post_data();
         $author_id      = bbp_get_reply_author_id( $reply_id );
-        $is_edit        = (bool) isset( $_POST['save'] );
+        $is_edit        = ( isset( $_POST['hidden_post_status'] ) && ( $_POST['hidden_post_status'] !== 'draft' ) );
 
         // Formally update the reply

trunk/src/includes/admin/topics.php

@@ -316 +316 @@
         $anonymous_data = bbp_filter_anonymous_post_data();
         $author_id      = bbp_get_topic_author_id( $topic_id );
-        $is_edit        = (bool) isset( $_POST['save'] );
+        $is_edit        = ( isset( $_POST['hidden_post_status'] ) && ( $_POST['hidden_post_status'] !== 'draft' ) );
 
         // Formally update the topic