Skip to:
Content

bbPress.org


Ignore:
Timestamp:
07/14/2015 12:46:38 AM (10 years ago)
Author:
johnjamesjacoby
Message:

I think this building should be condemned. There's serious metal fatigue in all the load-bearing members, the wiring is substandard, it's completely inadequate for our power needs, and the neighborhood is like a demilitarized zone.

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/src/includes/forums/functions.php

    r5827 r5829  
    142142
    143143    // Remove kses filters from title and content for capable users and if the nonce is verified
    144     if ( current_user_can( 'unfiltered_html' ) && !empty( $_POST['_bbp_unfiltered_html_forum'] ) && wp_create_nonce( 'bbp-unfiltered-html-forum_new' ) === $_POST['_bbp_unfiltered_html_forum'] ) {
     144    if ( current_user_can( 'unfiltered_html' ) && ! empty( $_POST['_bbp_unfiltered_html_forum'] ) && wp_create_nonce( 'bbp-unfiltered-html-forum_new' ) === $_POST['_bbp_unfiltered_html_forum'] ) {
    145145        remove_filter( 'bbp_new_forum_pre_title',   'wp_filter_kses'      );
    146146        remove_filter( 'bbp_new_forum_pre_content', 'bbp_encode_bad',  10 );
    … …  
    150150    /** Forum Title ***********************************************************/
    151151
    152     if ( !empty( $_POST['bbp_forum_title'] ) ) {
     152    if ( ! empty( $_POST['bbp_forum_title'] ) ) {
    153153        $forum_title = sanitize_text_field( $_POST['bbp_forum_title'] );
    154154    }
    … …  
    164164    /** Forum Content *********************************************************/
    165165
    166     if ( !empty( $_POST['bbp_forum_content'] ) ) {
     166    if ( ! empty( $_POST['bbp_forum_content'] ) ) {
    167167        $forum_content = $_POST['bbp_forum_content'];
    168168    }
    … …  
    179179
    180180    // Forum parent was passed (the norm)
    181     if ( !empty( $_POST['bbp_forum_parent_id'] ) ) {
     181    if ( ! empty( $_POST['bbp_forum_parent_id'] ) ) {
    182182        $forum_parent_id = bbp_get_forum_id( $_POST['bbp_forum_parent_id'] );
    183183    }
    … …  
    191191
    192192    // Forum exists
    193     } elseif ( !empty( $forum_parent_id ) ) {
     193    } elseif ( ! empty( $forum_parent_id ) ) {
    194194
    195195        // Forum is a category
    … …  
    216216    /** Forum Flooding ********************************************************/
    217217
    218     if ( !bbp_check_for_flood( $anonymous_data, $forum_author ) ) {
     218    if ( ! bbp_check_for_flood( $anonymous_data, $forum_author ) ) {
    219219        bbp_add_error( 'bbp_forum_flood', __( '<strong>ERROR</strong>: Slow down; you move too fast.', 'bbpress' ) );
    220220    }
    … …  
    222222    /** Forum Duplicate *******************************************************/
    223223
    224     if ( !bbp_check_for_duplicate( array( 'post_type' => bbp_get_forum_post_type(), 'post_author' => $forum_author, 'post_content' => $forum_content, 'anonymous_data' => $anonymous_data ) ) ) {
     224    if ( ! bbp_check_for_duplicate( array( 'post_type' => bbp_get_forum_post_type(), 'post_author' => $forum_author, 'post_content' => $forum_content, 'anonymous_data' => $anonymous_data ) ) ) {
    225225        bbp_add_error( 'bbp_forum_duplicate', __( '<strong>ERROR</strong>: This forum already exists.', 'bbpress' ) );
    226226    }
    … …  
    228228    /** Forum Blacklist *******************************************************/
    229229
    230     if ( !bbp_check_for_blacklist( $anonymous_data, $forum_author, $forum_title, $forum_content ) ) {
     230    if ( ! bbp_check_for_blacklist( $anonymous_data, $forum_author, $forum_title, $forum_content ) ) {
    231231        bbp_add_error( 'bbp_forum_blacklist', __( '<strong>ERROR</strong>: Your forum cannot be created at this time.', 'bbpress' ) );
    232232    }
    … …  
    235235
    236236    $post_status = bbp_get_public_status_id();
    237     if ( !bbp_check_for_moderation( $anonymous_data, $forum_author, $forum_title, $forum_content ) ) {
     237    if ( ! bbp_check_for_moderation( $anonymous_data, $forum_author, $forum_title, $forum_content ) ) {
    238238        $post_status = bbp_get_pending_status_id();
    239239    }
    … …  
    267267    /** No Errors *************************************************************/
    268268
    269     if ( !empty( $forum_id ) && !is_wp_error( $forum_id ) ) {
     269    if ( ! empty( $forum_id ) && !is_wp_error( $forum_id ) ) {
    270270
    271271        /** Trash Check *******************************************************/
    … …  
    318318
    319319        // Add view all?
    320         if ( bbp_get_view_all() || !empty( $view_all ) ) {
     320        if ( bbp_get_view_all() || ! empty( $view_all ) ) {
    321321
    322322            // User can moderate, so redirect to forum with view all set
    … …  
    419419
    420420    // Remove kses filters from title and content for capable users and if the nonce is verified
    421     if ( current_user_can( 'unfiltered_html' ) && !empty( $_POST['_bbp_unfiltered_html_forum'] ) && ( wp_create_nonce( 'bbp-unfiltered-html-forum_' . $forum_id ) === $_POST['_bbp_unfiltered_html_forum'] ) ) {
     421    if ( current_user_can( 'unfiltered_html' ) && ! empty( $_POST['_bbp_unfiltered_html_forum'] ) && ( wp_create_nonce( 'bbp-unfiltered-html-forum_' . $forum_id ) === $_POST['_bbp_unfiltered_html_forum'] ) ) {
    422422        remove_filter( 'bbp_edit_forum_pre_title',   'wp_filter_kses'      );
    423423        remove_filter( 'bbp_edit_forum_pre_content', 'bbp_encode_bad',  10 );
    … …  
    428428
    429429    // Forum parent id was passed
    430     if ( !empty( $_POST['bbp_forum_parent_id'] ) ) {
     430    if ( ! empty( $_POST['bbp_forum_parent_id'] ) ) {
    431431        $forum_parent_id = bbp_get_forum_id( $_POST['bbp_forum_parent_id'] );
    432432    }
    … …  
    436436
    437437    // Forum exists
    438     if ( !empty( $forum_parent_id ) && ( $forum_parent_id !== $current_parent_forum_id ) ) {
     438    if ( ! empty( $forum_parent_id ) && ( $forum_parent_id !== $current_parent_forum_id ) ) {
    439439
    440440        // Forum is closed and user cannot access
    … …  
    456456    /** Forum Title ***********************************************************/
    457457
    458     if ( !empty( $_POST['bbp_forum_title'] ) ) {
     458    if ( ! empty( $_POST['bbp_forum_title'] ) ) {
    459459        $forum_title = sanitize_text_field( $_POST['bbp_forum_title'] );
    460460    }
    … …  
    470470    /** Forum Content *********************************************************/
    471471
    472     if ( !empty( $_POST['bbp_forum_content'] ) ) {
     472    if ( ! empty( $_POST['bbp_forum_content'] ) ) {
    473473        $forum_content = $_POST['bbp_forum_content'];
    474474    }
    … …  
    484484    /** Forum Blacklist *******************************************************/
    485485
    486     if ( !bbp_check_for_blacklist( $anonymous_data, bbp_get_forum_author_id( $forum_id ), $forum_title, $forum_content ) ) {
     486    if ( ! bbp_check_for_blacklist( $anonymous_data, bbp_get_forum_author_id( $forum_id ), $forum_title, $forum_content ) ) {
    487487        bbp_add_error( 'bbp_forum_blacklist', __( '<strong>ERROR</strong>: Your forum cannot be edited at this time.', 'bbpress' ) );
    488488    }
    … …  
    491491
    492492    $post_status = bbp_get_public_status_id();
    493     if ( !bbp_check_for_moderation( $anonymous_data, bbp_get_forum_author_id( $forum_id ), $forum_title, $forum_content ) ) {
     493    if ( ! bbp_check_for_moderation( $anonymous_data, bbp_get_forum_author_id( $forum_id ), $forum_title, $forum_content ) ) {
    494494        $post_status = bbp_get_pending_status_id();
    495495    }
    … …  
    524524     * @todo omitted for 2.1
    525525    // Revision Reason
    526     if ( !empty( $_POST['bbp_forum_edit_reason'] ) )
     526    if ( ! empty( $_POST['bbp_forum_edit_reason'] ) )
    527527        $forum_edit_reason = sanitize_text_field( $_POST['bbp_forum_edit_reason'] );
    528528
    529529    // Update revision log
    530     if ( !empty( $_POST['bbp_log_forum_edit'] ) && ( "1" === $_POST['bbp_log_forum_edit'] ) && ( $revision_id = wp_save_post_revision( $forum_id ) ) ) {
     530    if ( ! empty( $_POST['bbp_log_forum_edit'] ) && ( "1" === $_POST['bbp_log_forum_edit'] ) && ( $revision_id = wp_save_post_revision( $forum_id ) ) ) {
    531531        bbp_update_forum_revision_log( array(
    532532            'forum_id'    => $forum_id,
    … …  
    540540    /** No Errors *************************************************************/
    541541
    542     if ( !empty( $forum_id ) && !is_wp_error( $forum_id ) ) {
     542    if ( ! empty( $forum_id ) && !is_wp_error( $forum_id ) ) {
    543543
    544544        // Update counts, etc...
    … …  
    577577
    578578        // Add view all?
    579         if ( !empty( $view_all ) ) {
     579        if ( ! empty( $view_all ) ) {
    580580            $forum_url = bbp_add_view_all( $forum_url );
    581581        }
    … …  
    653653    /** Forum Visibility **************************************************/
    654654
    655     if ( !empty( $_POST['bbp_forum_visibility'] ) && in_array( $_POST['bbp_forum_visibility'], array( bbp_get_public_status_id(), bbp_get_private_status_id(), bbp_get_hidden_status_id() ) ) ) {
     655    if ( ! empty( $_POST['bbp_forum_visibility'] ) && in_array( $_POST['bbp_forum_visibility'], array( bbp_get_public_status_id(), bbp_get_private_status_id(), bbp_get_hidden_status_id() ) ) ) {
    656656
    657657        // Get forums current visibility
    … …  
    10251025
    10261026    // Users exist
    1027     if ( !empty( $users ) ) {
     1027    if ( ! empty( $users ) ) {
    10281028
    10291029        // Loop through users
    … …  
    10771077
    10781078        // If has ancestors, loop through them...
    1079         if ( !empty( $ancestors ) ) {
     1079        if ( ! empty( $ancestors ) ) {
    10801080            foreach ( (array) $ancestors as $parent_forum_id ) {
    10811081
    … …  
    11681168
    11691169        // If has ancestors, loop through them...
    1170         if ( !empty( $ancestors ) ) {
     1170        if ( ! empty( $ancestors ) ) {
    11711171            foreach ( (array) $ancestors as $parent_forum_id ) {
    11721172
    … …  
    12171217        // Loop through children and add together forum reply counts
    12181218        $children = bbp_forum_query_subforum_ids( $forum_id );
    1219         if ( !empty( $children ) ) {
     1219        if ( ! empty( $children ) ) {
    12201220            foreach ( $children as $child ) {
    12211221                $children_last_topic = bbp_update_forum_last_topic_id( $child ); // Recursive
    … …  
    12351235        // Get the most recent topic in this forum_id
    12361236        $recent_topic = get_posts( $post_vars );
    1237         if ( !empty( $recent_topic ) ) {
     1237        if ( ! empty( $recent_topic ) ) {
    12381238            $topic_id = $recent_topic[0]->ID;
    12391239        }
    … …  
    12451245
    12461246    // If child forums have higher id, use that instead
    1247     if ( !empty( $children ) && ( $children_last_topic > $topic_id ) ) {
     1247    if ( ! empty( $children ) && ( $children_last_topic > $topic_id ) ) {
    12481248        $topic_id = $children_last_topic;
    12491249    }
    … …  
    12871287        // Loop through children and get the most recent reply id
    12881288        $children = bbp_forum_query_subforum_ids( $forum_id );
    1289         if ( !empty( $children ) ) {
     1289        if ( ! empty( $children ) ) {
    12901290            foreach ( $children as $child ) {
    12911291                $children_last_reply = bbp_update_forum_last_reply_id( $child ); // Recursive
    … …  
    12951295        // If this forum has topics...
    12961296        $topic_ids = bbp_forum_query_topic_ids( $forum_id );
    1297         if ( !empty( $topic_ids ) ) {
     1297        if ( ! empty( $topic_ids ) ) {
    12981298
    12991299            // ...get the most recent reply from those topics...
    … …  
    13101310
    13111311    // If child forums have higher ID, check for newer reply id
    1312     if ( !empty( $children ) && ( $children_last_reply > $reply_id ) ) {
     1312    if ( ! empty( $children ) && ( $children_last_reply > $reply_id ) ) {
    13131313        $reply_id = $children_last_reply;
    13141314    }
    … …  
    13531353        // Loop through children and add together forum reply counts
    13541354        $children = bbp_forum_query_subforum_ids( $forum_id );
    1355         if ( !empty( $children ) ) {
     1355        if ( ! empty( $children ) ) {
    13561356            foreach ( $children as $child ) {
    13571357                $children_last_active = bbp_update_forum_last_active_id( $child, $active_id );
    … …  
    13611361        // Don't count replies if the forum is a category
    13621362        $topic_ids = bbp_forum_query_topic_ids( $forum_id );
    1363         if ( !empty( $topic_ids ) ) {
     1363        if ( ! empty( $topic_ids ) ) {
    13641364            $active_id = bbp_forum_query_last_reply_id( $forum_id, $topic_ids );
    13651365            $active_id = $active_id > max( $topic_ids ) ? $active_id : max( $topic_ids );
    … …  
    13761376
    13771377    // If child forums have higher id, use that instead
    1378     if ( !empty( $children ) && ( $children_last_active > $active_id ) ) {
     1378    if ( ! empty( $children ) && ( $children_last_active > $active_id ) ) {
    13791379        $active_id = $children_last_active;
    13801380    }
    … …  
    14121412
    14131413    // Update only if there is a time
    1414     if ( !empty( $new_time ) ) {
     1414    if ( ! empty( $new_time ) ) {
    14151415        update_post_meta( $forum_id, '_bbp_last_active_time', $new_time );
    14161416    }
    … …  
    14671467    // Loop through subforums and add together forum topic counts
    14681468    $children = bbp_forum_query_subforum_ids( $forum_id );
    1469     if ( !empty( $children ) ) {
     1469    if ( ! empty( $children ) ) {
    14701470        foreach ( $children as $child ) {
    14711471            $children_topic_count += bbp_update_forum_topic_count( $child ); // Recursive
    … …  
    15671567    // Loop through children and add together forum reply counts
    15681568    $children = bbp_forum_query_subforum_ids( $forum_id );
    1569     if ( !empty( $children ) ) {
     1569    if ( ! empty( $children ) ) {
    15701570        foreach ( (array) $children as $child ) {
    15711571            $children_reply_count += bbp_update_forum_reply_count( $child );
    … …  
    16531653
    16541654    // Update the parent forum if one was passed
    1655     if ( !empty( $r['post_parent'] ) && is_numeric( $r['post_parent'] ) ) {
     1655    if ( ! empty( $r['post_parent'] ) && is_numeric( $r['post_parent'] ) ) {
    16561656        bbp_update_forum( array(
    16571657            'forum_id'    => $r['post_parent'],
    … …  
    17921792
    17931793        // There are forums that need to be excluded
    1794         if ( !empty( $forum_ids ) ) {
     1794        if ( ! empty( $forum_ids ) ) {
    17951795
    17961796            switch ( $type ) {
    … …  
    18841884        if ( ! current_user_can( 'read_private_forums' ) ) {
    18851885            $key = array_search( bbp_get_private_status_id(), $post_stati );
    1886             if ( !empty( $key ) ) {
     1886            if ( ! empty( $key ) ) {
    18871887                unset( $post_stati[$key] );
    18881888            }
    … …  
    18981898        if ( ! current_user_can( 'read_hidden_forums' ) ) {
    18991899            $key = array_search( bbp_get_hidden_status_id(), $post_stati );
    1900             if ( !empty( $key ) ) {
     1900            if ( ! empty( $key ) ) {
    19011901                unset( $post_stati[$key] );
    19021902            }
    … …  
    20122012        }
    20132013
    2014         if ( !empty( $topic_ids ) ) {
     2014        if ( ! empty( $topic_ids ) ) {
    20152015            $bbp_db    = bbp_db();
    20162016            $topic_ids = implode( ',', wp_parse_id_list( $topic_ids ) );
    … …  
    20802080
    20812081    // If forum is explicitly hidden and user not capable, set 404
    2082     if ( !empty( $forum_id ) && bbp_is_forum_hidden( $forum_id ) && !current_user_can( 'read_hidden_forums' ) ) {
     2082    if ( ! empty( $forum_id ) && bbp_is_forum_hidden( $forum_id ) && !current_user_can( 'read_hidden_forums' ) ) {
    20832083        bbp_set_404();
    20842084    }
    … …  
    21352135
    21362136    // If forum is explicitly hidden and user not capable, set 404
    2137     if ( !empty( $forum_id ) && bbp_is_forum_private( $forum_id ) && !current_user_can( 'read_private_forums' ) ) {
     2137    if ( ! empty( $forum_id ) && bbp_is_forum_private( $forum_id ) && !current_user_can( 'read_private_forums' ) ) {
    21382138        bbp_set_404();
    21392139    }
    … …  
    22022202    // Loop through and delete child topics. Topic replies will get deleted by
    22032203    // the bbp_delete_topic() action.
    2204     if ( !empty( $topics->posts ) ) {
     2204    if ( ! empty( $topics->posts ) ) {
    22052205        foreach ( $topics->posts as $topic ) {
    22062206            wp_delete_post( $topic->ID, true );
    … …  
    22592259    // Loop through and trash child topics. Topic replies will get trashed by
    22602260    // the bbp_trash_topic() action.
    2261     if ( !empty( $topics->posts ) ) {
     2261    if ( ! empty( $topics->posts ) ) {
    22622262
    22632263        // Prevent debug notices
    … …  
    23082308
    23092309    // There are topics to untrash
    2310     if ( !empty( $pre_trashed_topics ) ) {
     2310    if ( ! empty( $pre_trashed_topics ) ) {
    23112311
    23122312        // Maybe reverse the trashed topics array
    … …  
    23392339    $forum_id = bbp_get_forum_id( $forum_id );
    23402340
    2341     if ( empty( $forum_id ) || !bbp_is_forum( $forum_id ) ) {
     2341    if ( empty( $forum_id ) || ! bbp_is_forum( $forum_id ) ) {
    23422342        return false;
    23432343    }
    … …  
    23612361    $forum_id = bbp_get_forum_id( $forum_id );
    23622362
    2363     if ( empty( $forum_id ) || !bbp_is_forum( $forum_id ) ) {
     2363    if ( empty( $forum_id ) || ! bbp_is_forum( $forum_id ) ) {
    23642364        return false;
    23652365    }
    … …  
    23792379    $forum_id = bbp_get_forum_id( $forum_id );
    23802380
    2381     if ( empty( $forum_id ) || !bbp_is_forum( $forum_id ) ) {
     2381    if ( empty( $forum_id ) || ! bbp_is_forum( $forum_id ) ) {
    23822382        return false;
    23832383    }
    … …  
    23992399    $forum_id = bbp_get_forum_id( $forum_id );
    24002400
    2401     if ( empty( $forum_id ) || !bbp_is_forum( $forum_id ) ) {
     2401    if ( empty( $forum_id ) || ! bbp_is_forum( $forum_id ) ) {
    24022402        return false;
    24032403    }
    … …  
    24172417    $forum_id = bbp_get_forum_id( $forum_id );
    24182418
    2419     if ( empty( $forum_id ) || !bbp_is_forum( $forum_id ) ) {
     2419    if ( empty( $forum_id ) || ! bbp_is_forum( $forum_id ) ) {
    24202420        return false;
    24212421    }
    … …  
    24352435    $forum_id = bbp_get_forum_id( $forum_id );
    24362436
    2437     if ( empty( $forum_id ) || !bbp_is_forum( $forum_id ) ) {
     2437    if ( empty( $forum_id ) || ! bbp_is_forum( $forum_id ) ) {
    24382438        return false;
    24392439    }
Note: See TracChangeset for help on using the changeset viewer.