Changeset 5735 for trunk/src/includes/core/functions.php

Timestamp:

05/13/2015 12:03:28 AM (11 years ago)

Author:

johnjamesjacoby

Message:

Core: Return the filtered results of ID's in core _update_ functions.

This helps with various type-casting improvements going into #2801.

File:

• trunk/src/includes/core/functions.php (modified) (3 diffs)

trunk/src/includes/core/functions.php

@@ -83 +83 @@
 
     // Allow the forum ID to be updated 'just in time' before save
-    $forum_id = apply_filters( 'bbp_update_forum_id', $forum_id, $post_id );
+    $forum_id = (int) apply_filters( 'bbp_update_forum_id', $forum_id, $post_id );
 
     // Update the post meta forum ID
-    update_post_meta( $post_id, '_bbp_forum_id', (int) $forum_id );
+    update_post_meta( $post_id, '_bbp_forum_id', $forum_id );
+
+    return $forum_id;
 }
 
@@ -100 +102 @@
 
     // Allow the topic ID to be updated 'just in time' before save
-    $topic_id = apply_filters( 'bbp_update_topic_id', $topic_id, $post_id );
+    $topic_id = (int) apply_filters( 'bbp_update_topic_id', $topic_id, $post_id );
 
     // Update the post meta topic ID
-    update_post_meta( $post_id, '_bbp_topic_id', (int) $topic_id );
+    update_post_meta( $post_id, '_bbp_topic_id', $topic_id );
+
+    return $topic_id;
 }
 
@@ -117 +121 @@
 
     // Allow the reply ID to be updated 'just in time' before save
-    $reply_id = apply_filters( 'bbp_update_reply_id', $reply_id, $post_id );
+    $reply_id = (int) apply_filters( 'bbp_update_reply_id', $reply_id, $post_id );
 
     // Update the post meta reply ID
-    update_post_meta( $post_id, '_bbp_reply_id',(int) $reply_id );
+    update_post_meta( $post_id, '_bbp_reply_id', $reply_id );
+
+    return $reply_id;
 }