Changeset 5338

Timestamp:

04/04/2014 03:52:52 PM (11 years ago)

Author:

johnjamesjacoby

Message:

When calculating a new reply position, ensure we are using raw, unformatted integers. Fixes bug where formatted numeric strings (I.E. with commas; eg: 1,532) were being passed to the menu_order property, causing broken pagination on topics with over 1k replies. Fixes #2556.

Location:

trunk/src/includes

Files:

• replies/functions.php (modified) (1 diff)
• replies/template.php (modified) (1 diff)
• topics/functions.php (modified) (1 diff)

trunk/src/includes/replies/functions.php

@@ -1291 +1291 @@
 
                 // Bump the reply position
-                $reply_position = bbp_get_topic_reply_count( $destination_topic->ID ) + 1;
+                $reply_position = bbp_get_topic_reply_count( $destination_topic->ID, true ) + 1;
 
                 // Update the reply

trunk/src/includes/replies/template.php

@@ -2286 +2286 @@
         $classes[] = 'bbp-parent-forum-'   . bbp_get_reply_forum_id( $reply_id );
         $classes[] = 'bbp-parent-topic-'   . bbp_get_reply_topic_id( $reply_id );
-        $classes[] = 'bbp-reply-position-' . bbp_get_reply_position( $reply_id );
+        $classes[] = 'bbp-reply-position-' . bbp_get_reply_position( $reply_id, true );
         $classes[] = 'user-id-' . bbp_get_reply_author_id( $reply_id );
         $classes[] = ( bbp_get_reply_author_id( $reply_id ) === bbp_get_topic_author_id( bbp_get_reply_topic_id( $reply_id ) ) ? 'topic-author' : '' );

trunk/src/includes/topics/functions.php

@@ -1629 +1629 @@
             // Get topic reply count for existing topic
             case 'existing' :
-                $reply_position = bbp_get_topic_reply_count( $destination_topic->ID );
+                $reply_position = bbp_get_topic_reply_count( $destination_topic->ID, true );
                 break;