Changeset 4996

Timestamp:

06/23/2013 07:00:11 AM (12 years ago)

Author:

johnjamesjacoby

Message:

Replace generic stdClass usages with correct object types.

Fixes debug notices with bbp_get_displayed_user_field() when requesting non-existing fields or when there is no displayed user, by allowing the magic get() methods of the WP_User class to bail if the field is not set.

Also prevents similar issues with main query loops. Fixes #2359.

Location:

trunk

Files:

• bbpress.php (modified) (2 diffs)
• includes/common/shortcodes.php (modified) (1 diff)
• includes/users/functions.php (modified) (1 diff)

trunk/bbpress.php

@@ -247 +247 @@
         $this->current_topic_tag_id = 0; // Current topic tag id
 
-        $this->forum_query    = new stdClass(); // Main forum query
-        $this->topic_query    = new stdClass(); // Main topic query
-        $this->reply_query    = new stdClass(); // Main reply query
-        $this->search_query   = new stdClass(); // Main search query
+        $this->forum_query    = new WP_Query(); // Main forum query
+        $this->topic_query    = new WP_Query(); // Main topic query
+        $this->reply_query    = new WP_Query(); // Main reply query
+        $this->search_query   = new WP_Query(); // Main search query
 
         /** Theme Compat ******************************************************/
@@ -259 +259 @@
         /** Users *************************************************************/
 
-        $this->current_user   = new stdClass(); // Currently logged in user
-        $this->displayed_user = new stdClass(); // Currently displayed user
+        $this->current_user   = new WP_User(); // Currently logged in user
+        $this->displayed_user = new WP_User(); // Currently displayed user
 
         /** Misc **************************************************************/

trunk/includes/common/shortcodes.php

@@ -120 +120 @@
 
         // Unset global queries
-        $bbp->forum_query  = new stdClass;
-        $bbp->topic_query  = new stdClass;
-        $bbp->reply_query  = new stdClass;
-        $bbp->search_query = new stdClass;
+        $bbp->forum_query  = new WP_Query();
+        $bbp->topic_query  = new WP_Query();
+        $bbp->reply_query  = new WP_Query();
+        $bbp->search_query = new WP_Query();
 
         // Unset global ID's

trunk/includes/users/functions.php

@@ -869 +869 @@
 
         if ( $new_email['hash'] === $_GET['newuseremail'] ) {
-            $user             = new stdClass();
+            $user             = new WP_User();
             $user->ID         = $user_id;
             $user->user_email = esc_html( trim( $new_email['newemail'] ) );