Changeset 4995

Timestamp:

06/23/2013 06:37:22 AM (12 years ago)

Author:

johnjamesjacoby

Message:

Use strict comparisons where possible (excluding the converter code, as it needs dedicated testing.) See #2358.

Location:

trunk

Files:

• includes/admin/admin.php (modified) (3 diffs)
• includes/admin/metaboxes.php (modified) (2 diffs)
• includes/admin/replies.php (modified) (10 diffs)
• includes/admin/settings.php (modified) (1 diff)
• includes/admin/tools.php (modified) (4 diffs)
• includes/admin/topics.php (modified) (12 diffs)
• includes/admin/users.php (modified) (3 diffs)
• includes/common/classes.php (modified) (1 diff)
• includes/common/formatting.php (modified) (3 diffs)
• includes/common/functions.php (modified) (14 diffs)
• includes/common/template-tags.php (modified) (31 diffs)
• includes/common/widgets.php (modified) (5 diffs)
• includes/core/capabilities.php (modified) (1 diff)
• includes/core/functions.php (modified) (2 diffs)
• includes/core/template-functions.php (modified) (3 diffs)
• includes/core/theme-compat.php (modified) (1 diff)
• includes/core/update.php (modified) (4 diffs)
• includes/extend/akismet.php (modified) (8 diffs)
• includes/extend/buddypress/activity.php (modified) (1 diff)
• includes/extend/buddypress/functions.php (modified) (1 diff)
• includes/extend/buddypress/group.php (modified) (4 diffs)
• includes/forums/capabilities.php (modified) (3 diffs)
• includes/forums/functions.php (modified) (14 diffs)
• includes/forums/template-tags.php (modified) (6 diffs)
• includes/replies/capabilities.php (modified) (2 diffs)
• includes/replies/functions.php (modified) (18 diffs)
• includes/replies/template-tags.php (modified) (9 diffs)
• includes/topics/capabilities.php (modified) (2 diffs)
• includes/topics/functions.php (modified) (29 diffs)
• includes/topics/template-tags.php (modified) (12 diffs)
• includes/users/capabilities.php (modified) (3 diffs)
• includes/users/functions.php (modified) (9 diffs)
• includes/users/options.php (modified) (3 diffs)
• includes/users/template-tags.php (modified) (2 diffs)
• templates/default/bbpress/form-user-edit.php (modified) (1 diff)
• templates/default/bbpress/loop-single-topic.php (modified) (1 diff)

trunk/includes/admin/admin.php

@@ -485 +485 @@
 
         // Return normal links if not bbPress
-        if ( plugin_basename( bbpress()->file ) != $file )
+        if ( plugin_basename( bbpress()->file ) !== $file )
             return $links;
 
@@ -558 +558 @@
         $reply_class = sanitize_html_class( bbp_get_reply_post_type() );
 
-        if ( ( 'post' == get_current_screen()->base ) && ( bbp_get_reply_post_type() == get_current_screen()->post_type ) ) : ?>
+        if ( ( 'post' === get_current_screen()->base ) && ( bbp_get_reply_post_type() === get_current_screen()->post_type ) ) : ?>
 
         <script type="text/javascript">
@@ -828 +828 @@
             }
 
-            <?php if ( 'bbpress' == get_user_option( 'admin_color' ) ) : ?>
+            <?php if ( 'bbpress' === get_user_option( 'admin_color' ) ) : ?>
 
                 /* Green Scheme Images */

trunk/includes/admin/metaboxes.php

@@ -154 +154 @@
                         $text = _n( 'Hidden Topic', 'Hidden Topics', $r['topic_count_hidden'], 'bbpress' );
                         $link = add_query_arg( array( 'post_type' => bbp_get_topic_post_type() ), get_admin_url( null, 'edit.php' ) );
-                        if ( '0' != $num ) {
+                        if ( '0' !== $num ) {
                             $link = add_query_arg( array( 'post_status' => bbp_get_spam_status_id() ), $link );
                         }
@@ -176 +176 @@
                         $text = _n( 'Hidden Reply', 'Hidden Replies', $r['reply_count_hidden'], 'bbpress' );
                         $link = add_query_arg( array( 'post_type' => bbp_get_reply_post_type() ), get_admin_url( null, 'edit.php' ) );
-                        if ( '0' != $num ) {
+                        if ( '0' !== $num ) {
                             $link = add_query_arg( array( 'post_status' => bbp_get_spam_status_id() ), $link );
                         }

trunk/includes/admin/replies.php

@@ -99 +99 @@
      */
     private function bail() {
-        if ( !isset( get_current_screen()->post_type ) || ( $this->post_type != get_current_screen()->post_type ) )
+        if ( !isset( get_current_screen()->post_type ) || ( $this->post_type !== get_current_screen()->post_type ) )
             return true;
 
@@ -339 +339 @@
 
         // Bail if post_type is not a reply
-        if ( empty( $_GET['action'] ) || ( 'edit' != $_GET['action'] ) )
+        if ( empty( $_GET['action'] ) || ( 'edit' !== $_GET['action'] ) )
             return;
 
@@ -478 +478 @@
             $message = array( 'bbp_reply_toggle_notice' => $message, 'reply_id' => $reply->ID );
 
-            if ( false == $success || is_wp_error( $success ) )
+            if ( false === $success || is_wp_error( $success ) )
                 $message['failed'] = '1';
 
@@ -530 +530 @@
             switch ( $notice ) {
                 case 'spammed' :
-                    $message = $is_failure == true ? sprintf( __( 'There was a problem marking the reply "%1$s" as spam.', 'bbpress' ), $reply_title ) : sprintf( __( 'Reply "%1$s" successfully marked as spam.', 'bbpress' ), $reply_title );
+                    $message = $is_failure === true ? sprintf( __( 'There was a problem marking the reply "%1$s" as spam.', 'bbpress' ), $reply_title ) : sprintf( __( 'Reply "%1$s" successfully marked as spam.', 'bbpress' ), $reply_title );
                     break;
 
                 case 'unspammed' :
-                    $message = $is_failure == true ? sprintf( __( 'There was a problem unmarking the reply "%1$s" as spam.', 'bbpress' ), $reply_title ) : sprintf( __( 'Reply "%1$s" successfully unmarked as spam.', 'bbpress' ), $reply_title );
+                    $message = $is_failure === true ? sprintf( __( 'There was a problem unmarking the reply "%1$s" as spam.', 'bbpress' ), $reply_title ) : sprintf( __( 'Reply "%1$s" successfully unmarked as spam.', 'bbpress' ), $reply_title );
                     break;
             }
@@ -543 +543 @@
             ?>
 
-            <div id="message" class="<?php echo $is_failure == true ? 'error' : 'updated'; ?> fade">
+            <div id="message" class="<?php echo $is_failure === true ? 'error' : 'updated'; ?> fade">
                 <p style="line-height: 150%"><?php echo esc_html( $message ); ?></p>
             </div>
@@ -654 +654 @@
 
                     // Alert capable users of reply forum mismatch
-                    if ( $reply_forum_id != $topic_forum_id ) {
+                    if ( $reply_forum_id !== $topic_forum_id ) {
                         if ( current_user_can( 'edit_others_replies' ) || current_user_can( 'moderate' ) ) {
                             $forum_title .= '<div class="attention">' . esc_html__( '(Mismatch)', 'bbpress' ) . '</div>';
@@ -727 +727 @@
 
         // User cannot view replies in trash
-        if ( ( bbp_get_trash_status_id() == $reply->post_status ) && !current_user_can( 'view_trash' ) )
+        if ( ( bbp_get_trash_status_id() === $reply->post_status ) && !current_user_can( 'view_trash' ) )
             unset( $actions['view'] );
 
@@ -744 +744 @@
         // Trash
         if ( current_user_can( 'delete_reply', $reply->ID ) ) {
-            if ( bbp_get_trash_status_id() == $reply->post_status ) {
+            if ( bbp_get_trash_status_id() === $reply->post_status ) {
                 $post_type_object   = get_post_type_object( bbp_get_reply_post_type() );
                 $actions['untrash'] = "<a title='" . esc_attr__( 'Restore this item from the Trash', 'bbpress' ) . "' href='" . add_query_arg( array( '_wp_http_referer' => add_query_arg( array( 'post_type' => bbp_get_reply_post_type() ), admin_url( 'edit.php' ) ) ), wp_nonce_url( admin_url( sprintf( $post_type_object->_edit_link . '&amp;action=untrash', $reply->ID ) ), 'untrash-' . $reply->post_type . '_' . $reply->ID ) ) . "'>" . esc_html__( 'Restore', 'bbpress' ) . "</a>";
@@ -751 +751 @@
             }
 
-            if ( bbp_get_trash_status_id() == $reply->post_status || !EMPTY_TRASH_DAYS ) {
+            if ( bbp_get_trash_status_id() === $reply->post_status || !EMPTY_TRASH_DAYS ) {
                 $actions['delete'] = "<a class='submitdelete' title='" . esc_attr__( 'Delete this item permanently', 'bbpress' ) . "' href='" . add_query_arg( array( '_wp_http_referer' => add_query_arg( array( 'post_type' => bbp_get_reply_post_type() ), admin_url( 'edit.php' ) ) ), get_delete_post_link( $reply->ID, '', true ) ) . "'>" . esc_html__( 'Delete Permanently', 'bbpress' ) . "</a>";
-            } elseif ( bbp_get_spam_status_id() == $reply->post_status ) {
+            } elseif ( bbp_get_spam_status_id() === $reply->post_status ) {
                 unset( $actions['trash'] );
             }
@@ -776 +776 @@
 
         // Add Empty Spam button
-        if ( !empty( $_GET['post_status'] ) && ( bbp_get_spam_status_id() == $_GET['post_status'] ) && current_user_can( 'moderate' ) ) {
+        if ( !empty( $_GET['post_status'] ) && ( bbp_get_spam_status_id() === $_GET['post_status'] ) && current_user_can( 'moderate' ) ) {
             wp_nonce_field( 'bulk-destroy', '_destroy_nonce' );
             $title = esc_attr__( 'Empty Spam', 'bbpress' );

trunk/includes/admin/settings.php

@@ -1749 +1749 @@
 
         // Compare
-        if ( ( $slug != $key ) && ( $slug_check == $this_slug ) ) : ?>
+        if ( ( $slug !== $key ) && ( $slug_check === $this_slug ) ) : ?>
 
             <span class="attention"><?php printf( esc_html__( 'Possible %1$s conflict: %2$s', 'bbpress' ), $value['context'], '<strong>' . $value['name'] . '</strong>' ); ?></span>

trunk/includes/admin/tools.php

@@ -91 +91 @@
 
     foreach ( (array) bbp_admin_repair_list() as $item ) {
-        if ( isset( $item[2] ) && isset( $_POST[$item[0]] ) && 1 == $_POST[$item[0]] && is_callable( $item[2] ) ) {
+        if ( isset( $item[2] ) && isset( $_POST[$item[0]] ) && 1 === $_POST[$item[0]] && is_callable( $item[2] ) ) {
             $messages[] = call_user_func( $item[2] );
         }
@@ -402 +402 @@
 
         // Rename 'Default Forum'  since it's now visible in sitewide forums
-        if ( 'Default Forum' == $posts[0]->post_title ) {
+        if ( 'Default Forum' === $posts[0]->post_title ) {
             wp_update_post( array(
                 'ID'         => $posts[0]->ID,
@@ -910 +910 @@
             // If the topic is not a super sticky, and the forum ID does not
             // match the topic's forum ID, unset the forum's sticky meta.
-            if ( ! bbp_is_topic_super_sticky( $topic_id ) && $forum_id != bbp_get_topic_forum_id( $topic_id ) ) {
+            if ( ! bbp_is_topic_super_sticky( $topic_id ) && $forum_id !== bbp_get_topic_forum_id( $topic_id ) ) {
                 unset( $forum_stickies[$forum_id][$id] );
             }
@@ -1206 +1206 @@
     $statement  = __( 'Deleting Conversion Table… %s', 'bbpress' );
     $table_name = $wpdb->prefix . 'bbp_converter_translator';
-    if ( $wpdb->get_var( "SHOW TABLES LIKE '{$table_name}'" ) == $table_name ) {
+    if ( $wpdb->get_var( "SHOW TABLES LIKE '{$table_name}'" ) === $table_name ) {
         $wpdb->query( "DROP TABLE {$table_name}" );
         $result = $success;

trunk/includes/admin/topics.php

@@ -99 +99 @@
      */
     private function bail() {
-        if ( !isset( get_current_screen()->post_type ) || ( $this->post_type != get_current_screen()->post_type ) )
+        if ( !isset( get_current_screen()->post_type ) || ( $this->post_type !== get_current_screen()->post_type ) )
             return true;
 
@@ -355 +355 @@
 
         // Bail if post_type is not a topic
-        if ( empty( $_GET['action'] ) || ( 'edit' != $_GET['action'] ) )
+        if ( empty( $_GET['action'] ) || ( 'edit' !== $_GET['action'] ) )
             return;
 
@@ -493 +493 @@
 
                     $is_open = bbp_is_topic_open( $topic_id );
-                    $message = true == $is_open ? 'closed' : 'opened';
-                    $success = true == $is_open ? bbp_close_topic( $topic_id ) : bbp_open_topic( $topic_id );
+                    $message = true === $is_open ? 'closed' : 'opened';
+                    $success = true === $is_open ? bbp_close_topic( $topic_id ) : bbp_open_topic( $topic_id );
 
                     break;
@@ -502 +502 @@
 
                     $is_sticky = bbp_is_topic_sticky( $topic_id );
-                    $is_super  = ( empty( $is_sticky ) && !empty( $_GET['super'] ) && 1 == (int) $_GET['super'] ) ? true : false;
-                    $message   = true == $is_sticky ? 'unsticked'     : 'sticked';
-                    $message   = true == $is_super  ? 'super_sticked' : $message;
-                    $success   = true == $is_sticky ? bbp_unstick_topic( $topic_id ) : bbp_stick_topic( $topic_id, $is_super );
+                    $is_super  = ( empty( $is_sticky ) && !empty( $_GET['super'] ) && 1 === (int) $_GET['super'] ) ? true : false;
+                    $message   = true === $is_sticky ? 'unsticked'     : 'sticked';
+                    $message   = true === $is_super  ? 'super_sticked' : $message;
+                    $success   = true === $is_sticky ? bbp_unstick_topic( $topic_id ) : bbp_stick_topic( $topic_id, $is_super );
 
                     break;
@@ -513 +513 @@
 
                     $is_spam = bbp_is_topic_spam( $topic_id );
-                    $message = true == $is_spam ? 'unspammed' : 'spammed';
-                    $success = true == $is_spam ? bbp_unspam_topic( $topic_id ) : bbp_spam_topic( $topic_id );
+                    $message = true === $is_spam ? 'unspammed' : 'spammed';
+                    $success = true === $is_spam ? bbp_unspam_topic( $topic_id ) : bbp_spam_topic( $topic_id );
 
                     break;
@@ -521 +521 @@
             $message = array( 'bbp_topic_toggle_notice' => $message, 'topic_id' => $topic->ID );
 
-            if ( false == $success || is_wp_error( $success ) )
+            if ( false === $success || is_wp_error( $success ) )
                 $message['failed'] = '1';
 
@@ -573 +573 @@
             switch ( $notice ) {
                 case 'opened'    :
-                    $message = $is_failure == true ? sprintf( __( 'There was a problem opening the topic "%1$s".',           'bbpress' ), $topic_title ) : sprintf( __( 'Topic "%1$s" successfully opened.',           'bbpress' ), $topic_title );
+                    $message = $is_failure === true ? sprintf( __( 'There was a problem opening the topic "%1$s".',           'bbpress' ), $topic_title ) : sprintf( __( 'Topic "%1$s" successfully opened.',           'bbpress' ), $topic_title );
                     break;
 
                 case 'closed'    :
-                    $message = $is_failure == true ? sprintf( __( 'There was a problem closing the topic "%1$s".',           'bbpress' ), $topic_title ) : sprintf( __( 'Topic "%1$s" successfully closed.',           'bbpress' ), $topic_title );
+                    $message = $is_failure === true ? sprintf( __( 'There was a problem closing the topic "%1$s".',           'bbpress' ), $topic_title ) : sprintf( __( 'Topic "%1$s" successfully closed.',           'bbpress' ), $topic_title );
                     break;
 
                 case 'super_sticked' :
-                    $message = $is_failure == true ? sprintf( __( 'There was a problem sticking the topic "%1$s" to front.', 'bbpress' ), $topic_title ) : sprintf( __( 'Topic "%1$s" successfully sticked to front.', 'bbpress' ), $topic_title );
+                    $message = $is_failure === true ? sprintf( __( 'There was a problem sticking the topic "%1$s" to front.', 'bbpress' ), $topic_title ) : sprintf( __( 'Topic "%1$s" successfully sticked to front.', 'bbpress' ), $topic_title );
                     break;
 
                 case 'sticked'   :
-                    $message = $is_failure == true ? sprintf( __( 'There was a problem sticking the topic "%1$s".',          'bbpress' ), $topic_title ) : sprintf( __( 'Topic "%1$s" successfully sticked.',          'bbpress' ), $topic_title );
+                    $message = $is_failure === true ? sprintf( __( 'There was a problem sticking the topic "%1$s".',          'bbpress' ), $topic_title ) : sprintf( __( 'Topic "%1$s" successfully sticked.',          'bbpress' ), $topic_title );
                     break;
 
                 case 'unsticked' :
-                    $message = $is_failure == true ? sprintf( __( 'There was a problem unsticking the topic "%1$s".',        'bbpress' ), $topic_title ) : sprintf( __( 'Topic "%1$s" successfully unsticked.',        'bbpress' ), $topic_title );
+                    $message = $is_failure === true ? sprintf( __( 'There was a problem unsticking the topic "%1$s".',        'bbpress' ), $topic_title ) : sprintf( __( 'Topic "%1$s" successfully unsticked.',        'bbpress' ), $topic_title );
                     break;
 
                 case 'spammed'   :
-                    $message = $is_failure == true ? sprintf( __( 'There was a problem marking the topic "%1$s" as spam.',   'bbpress' ), $topic_title ) : sprintf( __( 'Topic "%1$s" successfully marked as spam.',   'bbpress' ), $topic_title );
+                    $message = $is_failure === true ? sprintf( __( 'There was a problem marking the topic "%1$s" as spam.',   'bbpress' ), $topic_title ) : sprintf( __( 'Topic "%1$s" successfully marked as spam.',   'bbpress' ), $topic_title );
                     break;
 
                 case 'unspammed' :
-                    $message = $is_failure == true ? sprintf( __( 'There was a problem unmarking the topic "%1$s" as spam.', 'bbpress' ), $topic_title ) : sprintf( __( 'Topic "%1$s" successfully unmarked as spam.', 'bbpress' ), $topic_title );
+                    $message = $is_failure === true ? sprintf( __( 'There was a problem unmarking the topic "%1$s" as spam.', 'bbpress' ), $topic_title ) : sprintf( __( 'Topic "%1$s" successfully unmarked as spam.', 'bbpress' ), $topic_title );
                     break;
             }
@@ -606 +606 @@
             ?>
 
-            <div id="message" class="<?php echo $is_failure == true ? 'error' : 'updated'; ?> fade">
+            <div id="message" class="<?php echo $is_failure === true ? 'error' : 'updated'; ?> fade">
                 <p style="line-height: 150%"><?php echo esc_html( $message ); ?></p>
             </div>
@@ -774 +774 @@
 
         // Show view link if it's not set, the topic is trashed and the user can view trashed topics
-        if ( empty( $actions['view'] ) && ( bbp_get_trash_status_id() == $topic->post_status ) && current_user_can( 'view_trash' ) )
+        if ( empty( $actions['view'] ) && ( bbp_get_trash_status_id() === $topic->post_status ) && current_user_can( 'view_trash' ) )
             $actions['view'] = '<a href="' . bbp_get_topic_permalink( $topic->ID ) . '" title="' . esc_attr( sprintf( __( 'View &#8220;%s&#8221;', 'bbpress' ), bbp_get_topic_title( $topic->ID ) ) ) . '" rel="permalink">' . esc_html__( 'View', 'bbpress' ) . '</a>';
 
@@ -814 +814 @@
         // Do not show trash links for spam topics, or spam links for trashed topics
         if ( current_user_can( 'delete_topic', $topic->ID ) ) {
-            if ( bbp_get_trash_status_id() == $topic->post_status ) {
+            if ( bbp_get_trash_status_id() === $topic->post_status ) {
                 $post_type_object   = get_post_type_object( bbp_get_topic_post_type() );
                 $actions['untrash'] = "<a title='" . esc_attr__( 'Restore this item from the Trash', 'bbpress' ) . "' href='" . wp_nonce_url( add_query_arg( array( '_wp_http_referer' => add_query_arg( array( 'post_type' => bbp_get_topic_post_type() ), admin_url( 'edit.php' ) ) ), admin_url( sprintf( $post_type_object->_edit_link . '&amp;action=untrash', $topic->ID ) ) ), 'untrash-' . $topic->post_type . '_' . $topic->ID ) . "'>" . esc_html__( 'Restore', 'bbpress' ) . "</a>";
@@ -821 +821 @@
             }
 
-            if ( bbp_get_trash_status_id() == $topic->post_status || !EMPTY_TRASH_DAYS ) {
+            if ( bbp_get_trash_status_id() === $topic->post_status || !EMPTY_TRASH_DAYS ) {
                 $actions['delete'] = "<a class='submitdelete' title='" . esc_attr__( 'Delete this item permanently', 'bbpress' ) . "' href='" . add_query_arg( array( '_wp_http_referer' => add_query_arg( array( 'post_type' => bbp_get_topic_post_type() ), admin_url( 'edit.php' ) ) ), get_delete_post_link( $topic->ID, '', true ) ) . "'>" . esc_html__( 'Delete Permanently', 'bbpress' ) . "</a>";
-            } elseif ( bbp_get_spam_status_id() == $topic->post_status ) {
+            } elseif ( bbp_get_spam_status_id() === $topic->post_status ) {
                 unset( $actions['trash'] );
             }
@@ -846 +846 @@
 
         // Add Empty Spam button
-        if ( !empty( $_GET['post_status'] ) && ( bbp_get_spam_status_id() == $_GET['post_status'] ) && current_user_can( 'moderate' ) ) {
+        if ( !empty( $_GET['post_status'] ) && ( bbp_get_spam_status_id() === $_GET['post_status'] ) && current_user_can( 'moderate' ) ) {
             wp_nonce_field( 'bulk-destroy', '_destroy_nonce' );
             $title = esc_attr__( 'Empty Spam', 'bbpress' );

trunk/includes/admin/users.php

@@ -182 +182 @@
 
             // Don't let a user change their own role
-            if ( $user_id == $current_user_id ) 
+            if ( $user_id === $current_user_id )
                 continue;
 
@@ -194 +194 @@
 
             // Set the new forums role
-            if ( $new_role != $user_role ) {
+            if ( $new_role !== $user_role ) {
                 bbp_set_user_role( $user_id, $new_role );
             }
@@ -230 +230 @@
 
         // Only looking for bbPress's user role column
-        if ( 'bbp_user_role' == $column_name ) {
+        if ( 'bbp_user_role' === $column_name ) {
 
             // Get the users role

trunk/includes/common/classes.php

@@ -242 +242 @@
         // - the forum is a category
         // - forum is closed
-        if (    ( true == $args['disable_categories'] )
-                && ( bbp_get_forum_post_type() == $_post->post_type )
+        if (    ( true === $args['disable_categories'] )
+                && ( bbp_get_forum_post_type() === $_post->post_type )
                 && ( bbp_is_forum_category( $_post->ID )
                     || ( !current_user_can( 'edit_forum', $_post->ID ) && bbp_is_forum_closed( $_post->ID )

trunk/includes/common/formatting.php

@@ -187 +187 @@
 
     // Trim inline code, not pre blocks (to prevent removing indentation)
-    if ( "`" == $matches[1] ) {
+    if ( "`" === $matches[1] ) {
         $content = trim( $matches[2] );
     } else {
@@ -205 +205 @@
 
     // Wrap blocks in pre tags
-    if ( "`" != $matches[1] ) {
+    if ( "`" !== $matches[1] ) {
         $content = '<pre>' . $content . '</pre>';
     }
@@ -333 +333 @@
         }
 
-        if ( $in_code || empty( $piece ) || ( $piece[0] == '<' && ! preg_match('|^<\s*[\w]{1,20}+://|', $piece) ) ) {
+        if ( $in_code || empty( $piece ) || ( $piece[0] === '<' && ! preg_match('|^<\s*[\w]{1,20}+://|', $piece) ) ) {
             $r .= $piece;
             continue;

trunk/includes/common/functions.php

@@ -153 +153 @@
                 // Finding the biggest chunk (if the chunk fits, break)
                 $count = floor( $since / $seconds );
-                if ( 0 != $count ) {
+                if ( 0 !== $count ) {
                     break;
                 }
@@ -165 +165 @@
 
                 // Set output var
-                $output = ( 1 == $count ) ? '1 '. $chunks[$i][1] : $count . ' ' . $chunks[$i][2];
+                $output = ( 1 === $count ) ? '1 '. $chunks[$i][1] : $count . ' ' . $chunks[$i][2];
 
                 // Step two: the second chunk
@@ -174 +174 @@
 
                     // Add to output var
-                    if ( 0 != $count2 ) {
-                        $output .= ( 1 == $count2 ) ? _x( ',', 'Separator in time since', 'bbpress' ) . ' 1 '. $name2 : _x( ',', 'Separator in time since', 'bbpress' ) . ' ' . $count2 . ' ' . $chunks[$i + 1][2];
+                    if ( 0 !== $count2 ) {
+                        $output .= ( 1 === $count2 ) ? _x( ',', 'Separator in time since', 'bbpress' ) . ' 1 '. $name2 : _x( ',', 'Separator in time since', 'bbpress' ) . ' ' . $count2 . ' ' . $chunks[$i + 1][2];
                     }
                 }
@@ -187 +187 @@
 
         // Append 'ago' to the end of time-since if not 'right now'
-        if ( $output != $right_now_text ) {
+        if ( $output !== $right_now_text ) {
             $output = sprintf( $ago_text, $output );
         }
@@ -218 +218 @@
 
     // We add our own full stop.
-    while ( substr( $reason, -1 ) == '.' )
+    while ( substr( $reason, -1 ) === '.' )
         $reason = substr( $reason, 0, -1 );
 
@@ -291 +291 @@
  */
 function bbp_get_view_all( $cap = 'moderate' ) {
-    $retval = ( ( !empty( $_GET['view'] ) && ( 'all' == $_GET['view'] ) && current_user_can( $cap ) ) );
+    $retval = ( ( !empty( $_GET['view'] ) && ( 'all' === $_GET['view'] ) && current_user_can( $cap ) ) );
     return apply_filters( 'bbp_get_view_all', (bool) $retval );
 }
@@ -351 +351 @@
 
     // Is the post by an anonymous user?
-    if ( ( bbp_get_topic_post_type() == $data['post_type'] && !bbp_is_topic_anonymous( $postarr['ID'] ) ) ||
-         ( bbp_get_reply_post_type() == $data['post_type'] && !bbp_is_reply_anonymous( $postarr['ID'] ) ) )
+    if ( ( bbp_get_topic_post_type() === $data['post_type'] && !bbp_is_topic_anonymous( $postarr['ID'] ) ) ||
+         ( bbp_get_reply_post_type() === $data['post_type'] && !bbp_is_reply_anonymous( $postarr['ID'] ) ) )
         return $data;
 
@@ -1062 +1062 @@
 
         // Don't send notifications to the person who made the post
-        if ( !empty( $reply_author ) && (int) $user_id == (int) $reply_author )
+        if ( !empty( $reply_author ) && (int) $user_id === (int) $reply_author )
             continue;
 
@@ -1124 +1124 @@
 
         // Rejig the $redirect_to
-        if ( !isset( $_SERVER['REDIRECT_URL'] ) || ( $redirect_to != home_url( $_SERVER['REDIRECT_URL'] ) ) ) {
+        if ( !isset( $_SERVER['REDIRECT_URL'] ) || ( $redirect_to !== home_url( $_SERVER['REDIRECT_URL'] ) ) ) {
             $redirect_to = isset( $_SERVER['HTTP_REFERER'] ) ? $_SERVER['HTTP_REFERER'] : '';
         }
@@ -1257 +1257 @@
 
         // Add closed status if topic post type
-        if ( $post_type == bbp_get_topic_post_type() ) {
+        if ( $post_type === bbp_get_topic_post_type() ) {
             $post_status[] = bbp_get_closed_status_id();
         }
@@ -1302 +1302 @@
 
         // Add closed status if topic post type
-        if ( $post_type == bbp_get_topic_post_type() ) {
+        if ( $post_type === bbp_get_topic_post_type() ) {
             $post_status[] = bbp_get_closed_status_id();
         }
@@ -1347 +1347 @@
 
         // Add closed status if topic post type
-        if ( $post_type == bbp_get_topic_post_type() ) {
+        if ( $post_type === bbp_get_topic_post_type() ) {
             $post_status[] = bbp_get_closed_status_id();
         }
@@ -1553 +1553 @@
 
                     // Only forum replies
-                    if ( !empty( $_GET['type'] ) && ( bbp_get_reply_post_type() == $_GET['type'] ) ) {
+                    if ( !empty( $_GET['type'] ) && ( bbp_get_reply_post_type() === $_GET['type'] ) ) {
 
                         // The query
@@ -1571 +1571 @@
 
                     // Only forum topics
-                    } elseif ( !empty( $_GET['type'] ) && ( bbp_get_topic_post_type() == $_GET['type'] ) ) {
+                    } elseif ( !empty( $_GET['type'] ) && ( bbp_get_topic_post_type() === $_GET['type'] ) ) {
 
                         // The query

trunk/includes/common/template-tags.php

@@ -129 +129 @@
 
     // Supplied ID is a forum
-    if ( !empty( $post_id ) && ( bbp_get_forum_post_type() == get_post_type( $post_id ) ))
+    if ( !empty( $post_id ) && ( bbp_get_forum_post_type() === get_post_type( $post_id ) ) )
         $retval = true;
 
@@ -201 +201 @@
 
     // Check query
-    if ( !empty( $wp_query->bbp_is_forum_edit ) && ( $wp_query->bbp_is_forum_edit == true ) )
+    if ( !empty( $wp_query->bbp_is_forum_edit ) && ( $wp_query->bbp_is_forum_edit === true ) )
         $retval = true;
 
     // Editing in admin
-    elseif ( is_admin() && ( 'post.php' == $pagenow ) && ( get_post_type() == bbp_get_forum_post_type() ) && ( !empty( $_GET['action'] ) && ( 'edit' == $_GET['action'] ) ) )
+    elseif ( is_admin() && ( 'post.php' === $pagenow ) && ( get_post_type() === bbp_get_forum_post_type() ) && ( !empty( $_GET['action'] ) && ( 'edit' === $_GET['action'] ) ) )
         $retval = true;
 
@@ -227 +227 @@
 
     // Supplied ID is a topic
-    if ( !empty( $post_id ) && ( bbp_get_topic_post_type() == get_post_type( $post_id ) ) )
+    if ( !empty( $post_id ) && ( bbp_get_topic_post_type() === get_post_type( $post_id ) ) )
         $retval = true;
 
@@ -298 +298 @@
 
     // Check query
-    if ( !empty( $wp_query->bbp_is_topic_edit ) && ( $wp_query->bbp_is_topic_edit == true ) )
+    if ( !empty( $wp_query->bbp_is_topic_edit ) && ( $wp_query->bbp_is_topic_edit === true ) )
         $retval = true;
 
     // Editing in admin
-    elseif ( is_admin() && ( 'post.php' == $pagenow ) && ( get_post_type() == bbp_get_topic_post_type() ) && ( !empty( $_GET['action'] ) && ( 'edit' == $_GET['action'] ) ) )
+    elseif ( is_admin() && ( 'post.php' === $pagenow ) && ( get_post_type() === bbp_get_topic_post_type() ) && ( !empty( $_GET['action'] ) && ( 'edit' === $_GET['action'] ) ) )
         $retval = true;
 
@@ -322 +322 @@
 
     // Check topic edit and GET params
-    if ( bbp_is_topic_edit() && !empty( $_GET['action'] ) && ( 'merge' == $_GET['action'] ) )
+    if ( bbp_is_topic_edit() && !empty( $_GET['action'] ) && ( 'merge' === $_GET['action'] ) )
         return true;
 
@@ -342 +342 @@
 
     // Check topic edit and GET params
-    if ( bbp_is_topic_edit() && !empty( $_GET['action'] ) && ( 'split' == $_GET['action'] ) )
+    if ( bbp_is_topic_edit() && !empty( $_GET['action'] ) && ( 'split' === $_GET['action'] ) )
         $retval = true;
 
@@ -394 +394 @@
 
     // Check query
-    if ( !empty( $wp_query->bbp_is_topic_tag_edit ) && ( true == $wp_query->bbp_is_topic_tag_edit ) )
+    if ( !empty( $wp_query->bbp_is_topic_tag_edit ) && ( true === $wp_query->bbp_is_topic_tag_edit ) )
         $retval = true;
 
     // Editing in admin
-    elseif ( is_admin() && ( 'edit-tags.php' == $pagenow ) && ( bbp_get_topic_tag_tax_id() == $taxnow ) && ( !empty( $_GET['action'] ) && ( 'edit' == $_GET['action'] ) ) )
+    elseif ( is_admin() && ( 'edit-tags.php' === $pagenow ) && ( bbp_get_topic_tag_tax_id() === $taxnow ) && ( !empty( $_GET['action'] ) && ( 'edit' === $_GET['action'] ) ) )
         $retval = true;
 
@@ -449 +449 @@
 
     // Supplied ID is a reply
-    if ( !empty( $post_id ) && ( bbp_get_reply_post_type() == get_post_type( $post_id ) ) )
+    if ( !empty( $post_id ) && ( bbp_get_reply_post_type() === get_post_type( $post_id ) ) )
         $retval = true;
 
@@ -470 +470 @@
 
     // Check query
-    if ( !empty( $wp_query->bbp_is_reply_edit ) && ( true == $wp_query->bbp_is_reply_edit ) )
+    if ( !empty( $wp_query->bbp_is_reply_edit ) && ( true === $wp_query->bbp_is_reply_edit ) )
         $retval = true;
 
     // Editing in admin
-    elseif ( is_admin() && ( 'post.php' == $pagenow ) && ( get_post_type() == bbp_get_reply_post_type() ) && ( !empty( $_GET['action'] ) && ( 'edit' == $_GET['action'] ) ) )
+    elseif ( is_admin() && ( 'post.php' === $pagenow ) && ( get_post_type() === bbp_get_reply_post_type() ) && ( !empty( $_GET['action'] ) && ( 'edit' === $_GET['action'] ) ) )
         $retval = true;
 
@@ -492 +492 @@
 
     // Check reply edit and GET params
-    if ( bbp_is_reply_edit() && !empty( $_GET['action'] ) && ( 'move' == $_GET['action'] ) )
+    if ( bbp_is_reply_edit() && !empty( $_GET['action'] ) && ( 'move' === $_GET['action'] ) )
         $retval = true;
 
@@ -540 +540 @@
 
     // Check query
-    if ( !empty( $wp_query->bbp_is_single_user_favs ) && ( true == $wp_query->bbp_is_single_user_favs ) )
+    if ( !empty( $wp_query->bbp_is_single_user_favs ) && ( true === $wp_query->bbp_is_single_user_favs ) )
         $retval = true;
 
@@ -560 +560 @@
 
     // Check query
-    if ( !empty( $wp_query->bbp_is_single_user_subs ) && ( true == $wp_query->bbp_is_single_user_subs ) )
+    if ( !empty( $wp_query->bbp_is_single_user_subs ) && ( true === $wp_query->bbp_is_single_user_subs ) )
         $retval = true;
 
@@ -581 +581 @@
 
     // Check query
-    if ( !empty( $wp_query->bbp_is_single_user_topics ) && ( true == $wp_query->bbp_is_single_user_topics ) )
+    if ( !empty( $wp_query->bbp_is_single_user_topics ) && ( true === $wp_query->bbp_is_single_user_topics ) )
         $retval = true;
 
@@ -602 +602 @@
 
     // Check query
-    if ( !empty( $wp_query->bbp_is_single_user_replies ) && ( true == $wp_query->bbp_is_single_user_replies ) )
+    if ( !empty( $wp_query->bbp_is_single_user_replies ) && ( true === $wp_query->bbp_is_single_user_replies ) )
         $retval = true;
 
@@ -625 +625 @@
 
     // Check query
-    if ( !empty( $wp_query->bbp_is_single_user_home ) && ( true == $wp_query->bbp_is_single_user_home ) )
+    if ( !empty( $wp_query->bbp_is_single_user_home ) && ( true === $wp_query->bbp_is_single_user_home ) )
         $retval = true;
 
@@ -667 +667 @@
 
     // Check query
-    if ( !empty( $wp_query->bbp_is_single_user ) && ( true == $wp_query->bbp_is_single_user ) )
+    if ( !empty( $wp_query->bbp_is_single_user ) && ( true === $wp_query->bbp_is_single_user ) )
         $retval = true;
 
@@ -688 +688 @@
 
     // Check query
-    if ( !empty( $wp_query->bbp_is_single_user_edit ) && ( true == $wp_query->bbp_is_single_user_edit ) )
+    if ( !empty( $wp_query->bbp_is_single_user_edit ) && ( true === $wp_query->bbp_is_single_user_edit ) )
         $retval = true;
 
@@ -709 +709 @@
 
     // Check query
-    if ( !empty( $wp_query->bbp_is_single_user_profile ) && ( true == $wp_query->bbp_is_single_user_profile ) )
+    if ( !empty( $wp_query->bbp_is_single_user_profile ) && ( true === $wp_query->bbp_is_single_user_profile ) )
         $retval = true;
 
@@ -730 +730 @@
 
     // Check query
-    if ( !empty( $wp_query->bbp_is_single_user_topics ) && ( true == $wp_query->bbp_is_single_user_topics ) )
+    if ( !empty( $wp_query->bbp_is_single_user_topics ) && ( true === $wp_query->bbp_is_single_user_topics ) )
         $retval = true;
 
@@ -751 +751 @@
 
     // Check query
-    if ( !empty( $wp_query->bbp_is_single_user_replies ) && ( true == $wp_query->bbp_is_single_user_replies ) )
+    if ( !empty( $wp_query->bbp_is_single_user_replies ) && ( true === $wp_query->bbp_is_single_user_replies ) )
         $retval = true;
 
@@ -773 +773 @@
 
     // Check query
-    if ( !empty( $wp_query->bbp_is_view ) && ( true == $wp_query->bbp_is_view ) )
+    if ( !empty( $wp_query->bbp_is_view ) && ( true === $wp_query->bbp_is_view ) )
         $retval = true;
 
@@ -803 +803 @@
 
     // Check query
-    if ( !empty( $wp_query->bbp_is_search ) && ( true == $wp_query->bbp_is_search ) )
+    if ( !empty( $wp_query->bbp_is_search ) && ( true === $wp_query->bbp_is_search ) )
         $retval = true;
 
@@ -866 +866 @@
 
     // Check query
-    if ( !empty( $wp_query->bbp_is_edit ) && ( $wp_query->bbp_is_edit == true ) )
+    if ( !empty( $wp_query->bbp_is_edit ) && ( $wp_query->bbp_is_edit === true ) )
         $retval = true;
 
@@ -1400 +1400 @@
 
         // Forums
-        if ( bbp_get_forum_post_type() == $r['post_type'] ) {
+        if ( bbp_get_forum_post_type() === $r['post_type'] ) {
 
             // Private forums
@@ -1826 +1826 @@
     // Unset fullscreen
     foreach ( $plugins as $key => $value ) {
-        if ( 'fullscreen' == $value ) {
+        if ( 'fullscreen' === $value ) {
             unset( $plugins[$key] );
             break;
@@ -2017 +2017 @@
  */
 function bbp_is_query_name( $name = '' )  {
-    return (bool) ( bbp_get_query_name() == $name );
+    return (bool) ( bbp_get_query_name() === $name );
 }
 
@@ -2151 +2151 @@
 
         // Root slug is also the front page
-        if ( !empty( $front_id ) && ( $front_id == $root_id ) ) {
+        if ( !empty( $front_id ) && ( $front_id === $root_id ) ) {
             $pre_include_root = false;
         }
@@ -2161 +2161 @@
 
         // Don't show root if viewing page in place of forum archive
-        if ( !empty( $root_id ) && ( ( is_single() || is_page() ) && ( $root_id == get_the_ID() ) ) ) {
+        if ( !empty( $root_id ) && ( ( is_single() || is_page() ) && ( $root_id === get_the_ID() ) ) ) {
             $pre_include_root = false;
         }
@@ -2440 +2440 @@
         // Loop through notices and separate errors from messages
         foreach ( $bbp->errors->get_error_messages( $code ) as $error ) {
-            if ( 'message' == $severity ) {
+            if ( 'message' === $severity ) {
                 $messages[] = $error;
             } else {
@@ -2609 +2609 @@
 
     // Compare new title with original title
-    if ( $title == $_title )
+    if ( $title === $_title )
         return $title;
 
@@ -2620 +2620 @@
 
     // sep on right, so reverse the order
-    if ( 'right' == $seplocation ) {
+    if ( 'right' === $seplocation ) {
         $title_array = array_reverse( explode( $t_sep, $title ) );
         $title       = implode( " $sep ", $title_array ) . $prefix;

trunk/includes/common/widgets.php

@@ -804 +804 @@
 
                 // Maybe get the topic author
-                if ( 'on' == $settings['show_user'] ) :
+                if ( 'on' === $settings['show_user'] ) :
                     $author_link = bbp_get_topic_author_link( array( 'post_id' => $topic_id, 'type' => 'both', 'size' => 14 ) );
                 endif; ?>
@@ -817 +817 @@
                     <?php endif; ?>
 
-                    <?php if ( 'on' == $settings['show_date'] ) : ?>
+                    <?php if ( 'on' === $settings['show_date'] ) : ?>
 
                         <div><?php bbp_topic_last_active_time( $topic_id ); ?></div>
@@ -1155 +1155 @@
 
                     // Only query user if showing them
-                    if ( 'on' == $settings['show_user'] ) :
+                    if ( 'on' === $settings['show_user'] ) :
                         $author_link = bbp_get_reply_author_link( array( 'post_id' => $reply_id, 'type' => 'both', 'size' => 14 ) );
                     else :
@@ -1162 +1162 @@
 
                     // Reply author, link, and timestamp
-                    if ( ( 'on' == $settings['show_date'] ) && !empty( $author_link ) ) :
+                    if ( ( 'on' === $settings['show_date'] ) && !empty( $author_link ) ) :
 
                         // translators: 1: reply author, 2: reply link, 3: reply timestamp
@@ -1168 +1168 @@
 
                     // Reply link and timestamp
-                    elseif ( 'on' == $settings['show_date'] ) :
+                    elseif ( 'on' === $settings['show_date'] ) :
 
                         // translators: 1: reply link, 2: reply timestamp

trunk/includes/core/capabilities.php

@@ -475 +475 @@
 
             // If keys match, unset
-            if ( $wp_role == $bbp_role ) {
+            if ( $wp_role === $bbp_role ) {
                 unset( $all_roles[$wp_role] );
             }

trunk/includes/core/functions.php

@@ -551 +551 @@
  */
 function bbp_is_post_request() {
-    return (bool) ( 'POST' == strtoupper( $_SERVER['REQUEST_METHOD'] ) );
+    return (bool) ( 'POST' === strtoupper( $_SERVER['REQUEST_METHOD'] ) );
 }
 
@@ -561 +561 @@
  */
 function bbp_is_get_request() {
-    return (bool) ( 'GET' == strtoupper( $_SERVER['REQUEST_METHOD'] ) );
-}
-
+    return (bool) ( 'GET' === strtoupper( $_SERVER['REQUEST_METHOD'] ) );
+}
+

trunk/includes/core/template-functions.php

@@ -102 +102 @@
 
     // Maybe load the template if one was located
-    if ( ( true == $load ) && !empty( $located ) ) {
+    if ( ( true === $load ) && !empty( $located ) ) {
         load_template( $located, $require_once );
     }
@@ -316 +316 @@
 
     // Bail if filters are suppressed on this query
-    if ( true == $posts_query->get( 'suppress_filters' ) )
+    if ( true === $posts_query->get( 'suppress_filters' ) )
         return;
 
@@ -422 +422 @@
 
         // User is looking at their own profile
-        if ( get_current_user_id() == $the_user->ID ) {
+        if ( get_current_user_id() === $the_user->ID ) {
             $posts_query->bbp_is_single_user_home = true;
         }

trunk/includes/core/theme-compat.php

@@ -259 +259 @@
         return false;
 
-    return (bool) ( $bbp->theme_compat->original_template == $template );
+    return (bool) ( $bbp->theme_compat->original_template === $template );
 }
 

trunk/includes/core/update.php

@@ -54 +54 @@
     $action = false;
 
-    if ( ! empty( $_REQUEST['action'] ) && ( '-1' != $_REQUEST['action'] ) ) {
+    if ( ! empty( $_REQUEST['action'] ) && ( '-1' !== $_REQUEST['action'] ) ) {
         $action = $_REQUEST['action'];
-    } elseif ( ! empty( $_REQUEST['action2'] ) && ( '-1' != $_REQUEST['action2'] ) ) {
+    } elseif ( ! empty( $_REQUEST['action2'] ) && ( '-1' !== $_REQUEST['action2'] ) ) {
         $action = $_REQUEST['action2'];
     }
@@ -66 +66 @@
 
     // The plugin(s) being activated
-    if ( $action == 'activate' ) {
+    if ( $action === 'activate' ) {
         $plugins = isset( $_GET['plugin'] ) ? array( $_GET['plugin'] ) : array();
     } else {
@@ -96 +96 @@
     $action = false;
     
-    if ( ! empty( $_REQUEST['action'] ) && ( '-1' != $_REQUEST['action'] ) ) {
+    if ( ! empty( $_REQUEST['action'] ) && ( '-1' !== $_REQUEST['action'] ) ) {
         $action = $_REQUEST['action'];
-    } elseif ( ! empty( $_REQUEST['action2'] ) && ( '-1' != $_REQUEST['action2'] ) ) {
+    } elseif ( ! empty( $_REQUEST['action2'] ) && ( '-1' !== $_REQUEST['action2'] ) ) {
         $action = $_REQUEST['action2'];
     }
@@ -108 +108 @@
 
     // The plugin(s) being deactivated
-    if ( $action == 'deactivate' ) {
+    if ( $action === 'deactivate' ) {
         $plugins = isset( $_GET['plugin'] ) ? array( $_GET['plugin'] ) : array();
     } else {

trunk/includes/extend/akismet.php

@@ -98 +98 @@
 
         // Post is not published
-        if ( bbp_get_public_status_id() != $post_data['post_status'] )
+        if ( bbp_get_public_status_id() !== $post_data['post_status'] )
             return $post_data;
 
@@ -166 +166 @@
 
         // Spam
-        if ( 'true' == $post_data['bbp_akismet_result'] ) {
+        if ( 'true' === $post_data['bbp_akismet_result'] ) {
 
             // Let plugins do their thing
@@ -255 +255 @@
 
         // Bail if we're spamming, but the post_status isn't spam
-        if ( ( 'spam' == $request_type ) && ( bbp_get_spam_status_id() != $_post->post_status ) )
+        if ( ( 'spam' === $request_type ) && ( bbp_get_spam_status_id() !== $_post->post_status ) )
             return;
 
@@ -385 +385 @@
 
         // Aim...
-        if ( 'check' == $check ) {
+        if ( 'check' === $check ) {
             $path = '/1.1/comment-check';
-        } elseif ( 'submit' == $check ) {
+        } elseif ( 'submit' === $check ) {
             $path = '/1.1/submit-' . $spam;
         }
@@ -446 +446 @@
 
             // More checks
-            if (    intval( $as_submitted['comment_post_ID'] )    == intval( $_post->post_parent )
-                    &&      $as_submitted['comment_author']       == ( $anonymous_data ? $anonymous_data['bbp_anonymous_name']  : $userdata->display_name )
-                    &&      $as_submitted['comment_author_email'] == ( $anonymous_data ? $anonymous_data['bbp_anonymous_email'] : $userdata->user_email   )
+            if (    intval( $as_submitted['comment_post_ID'] )    === intval( $_post->post_parent )
+                    &&      $as_submitted['comment_author']       === ( $anonymous_data ? $anonymous_data['bbp_anonymous_name']  : $userdata->display_name )
+                    &&      $as_submitted['comment_author_email'] === ( $anonymous_data ? $anonymous_data['bbp_anonymous_email'] : $userdata->user_email   )
                 ) {
 
                 // Normal result: true
-                if ( $this->last_post['bbp_akismet_result'] == 'true' ) {
+                if ( $this->last_post['bbp_akismet_result'] === 'true' ) {
 
                     // Leave a trail so other's know what we did
@@ -459 +459 @@
 
                     // If post_status isn't the spam status, as expected, leave a note
-                    if ( $_post->post_status != bbp_get_spam_status_id() ) {
+                    if ( bbp_get_spam_status_id() !== $_post->post_status ) {
                         $this->update_post_history( $post_id, sprintf( esc_html__( 'Post status was changed to %s', 'bbpress' ), $_post->post_status ), 'status-changed-' . $_post->post_status );
                     }
 
                 // Normal result: false
-                } elseif ( $this->last_post['bbp_akismet_result'] == 'false' ) {
+                } elseif ( $this->last_post['bbp_akismet_result'] === 'false' ) {
 
                     // Leave a trail so other's know what we did
@@ -471 +471 @@
 
                     // If post_status is the spam status, which isn't expected, leave a note
-                    if ( $_post->post_status == bbp_get_spam_status_id() ) {
+                    if ( bbp_get_spam_status_id() === $_post->post_status ) {
 
                         // @todo Use wp_blacklist_check()
@@ -661 +661 @@
 
             // Open a socket connection
-            if ( false != ( $fs = @fsockopen( $http_host, $port, $errno, $errstr, 10 ) ) ) {
+            if ( false !== ( $fs = @fsockopen( $http_host, $port, $errno, $errstr, 10 ) ) ) {
 
                 // Write our request to the pointer

trunk/includes/extend/buddypress/activity.php

@@ -632 +632 @@
 
         // Action based on new status
-        if ( $post->post_status == bbp_get_public_status_id() ) {
+        if ( bbp_get_public_status_id() === $post->post_status ) {
 
             // Validate reply data

trunk/includes/extend/buddypress/functions.php

@@ -39 +39 @@
 
     // Currently viewing or editing a user
-    elseif ( ( true == $displayed_user_fallback ) && !empty( $did ) )
+    elseif ( ( true === $displayed_user_fallback ) && !empty( $did ) )
         $bbp_user_id = $did;
 
     // Maybe fallback on the current_user ID
-    elseif ( ( true == $current_user_fallback ) && !empty( $lid ) )
+    elseif ( ( true === $current_user_fallback ) && !empty( $lid ) )
         $bbp_user_id = $lid;
 

trunk/includes/extend/buddypress/group.php

@@ -792 +792 @@
 
                     // Topic edit
-                    if ( bp_action_variable( $offset + 2 ) == bbp_get_edit_rewrite_id() ) :
+                    if ( bp_action_variable( $offset + 2 ) === bbp_get_edit_rewrite_id() ) :
 
                         // Unset the super sticky link on edit topic template
@@ -805 +805 @@
 
                         // Merge
-                        if ( !empty( $_GET['action'] ) && 'merge' == $_GET['action'] ) :
+                        if ( !empty( $_GET['action'] ) && 'merge' === $_GET['action'] ) :
                             bbp_set_query_name( 'bbp_topic_merge' );
                             bbp_get_template_part( 'form', 'topic-merge' );
 
                         // Split
-                        elseif ( !empty( $_GET['action'] ) && 'split' == $_GET['action'] ) :
+                        elseif ( !empty( $_GET['action'] ) && 'split' === $_GET['action'] ) :
                             bbp_set_query_name( 'bbp_topic_split' );
                             bbp_get_template_part( 'form', 'topic-split' );
@@ -851 +851 @@
                     <h3><?php bbp_reply_title(); ?></h3>
 
-                    <?php if ( bp_action_variable( $offset + 2 ) == bbp_get_edit_rewrite_id() ) :
+                    <?php if ( bp_action_variable( $offset + 2 ) === bbp_get_edit_rewrite_id() ) :
 
                         // Set the edit switches
@@ -861 +861 @@
 
                         // Move
-                        if ( !empty( $_GET['action'] ) && ( 'move' == $_GET['action'] ) ) :
+                        if ( !empty( $_GET['action'] ) && ( 'move' === $_GET['action'] ) ) :
                             bbp_set_query_name( 'bbp_reply_move' );
                             bbp_get_template_part( 'form', 'reply-move' );

trunk/includes/forums/capabilities.php

@@ -78 +78 @@
 
                     // Post is public
-                    if ( bbp_get_public_status_id() == $_post->post_status ) {
+                    if ( bbp_get_public_status_id() === $_post->post_status ) {
                         $caps = array( 'spectate' );
 
                     // User is author so allow read
-                    } elseif ( (int) $user_id == (int) $_post->post_author ) {
+                    } elseif ( (int) $user_id === (int) $_post->post_author ) {
                         $caps = array( 'spectate' );
 
@@ -138 +138 @@
 
                 // User is author so allow edit
-                } elseif ( (int) $user_id == (int) $_post->post_author ) {
+                } elseif ( (int) $user_id === (int) $_post->post_author ) {
                     $caps[] = $post_type->cap->edit_posts;
 
@@ -167 +167 @@
 
                 // User is author so allow to delete
-                } elseif ( (int) $user_id == (int) $_post->post_author ) {
+                } elseif ( (int) $user_id === (int) $_post->post_author ) {
                     $caps[] = $post_type->cap->delete_posts;
 

trunk/includes/forums/functions.php

@@ -137 +137 @@
 
     // Remove kses filters from title and content for capable users and if the nonce is verified
-    if ( current_user_can( 'unfiltered_html' ) && !empty( $_POST['_bbp_unfiltered_html_forum'] ) && wp_create_nonce( 'bbp-unfiltered-html-forum_new' ) == $_POST['_bbp_unfiltered_html_forum'] ) {
+    if ( current_user_can( 'unfiltered_html' ) && !empty( $_POST['_bbp_unfiltered_html_forum'] ) && wp_create_nonce( 'bbp-unfiltered-html-forum_new' ) === $_POST['_bbp_unfiltered_html_forum'] ) {
         remove_filter( 'bbp_new_forum_pre_title',   'wp_filter_kses'      );
         remove_filter( 'bbp_new_forum_pre_content', 'bbp_encode_bad',  10 );
@@ -258 +258 @@
         // If the forum is trash, or the forum_status is switched to
         // trash, trash it properly
-        if ( ( get_post_field( 'post_status', $forum_id ) == bbp_get_trash_status_id() ) || ( $forum_data['post_status'] == bbp_get_trash_status_id() ) ) {
+        if ( ( get_post_field( 'post_status', $forum_id ) === bbp_get_trash_status_id() ) || ( $forum_data['post_status'] === bbp_get_trash_status_id() ) ) {
 
             // Trash the reply
@@ -270 +270 @@
 
         // If reply or forum are spam, officially spam this reply
-        if ( $forum_data['post_status'] == bbp_get_spam_status_id() ) {
+        if ( $forum_data['post_status'] === bbp_get_spam_status_id() ) {
             add_post_meta( $forum_id, '_bbp_spam_meta_status', bbp_get_public_status_id() );
 
@@ -407 +407 @@
 
     // Remove kses filters from title and content for capable users and if the nonce is verified
-    if ( current_user_can( 'unfiltered_html' ) && !empty( $_POST['_bbp_unfiltered_html_forum'] ) && ( wp_create_nonce( 'bbp-unfiltered-html-forum_' . $forum_id ) == $_POST['_bbp_unfiltered_html_forum'] ) ) {
+    if ( current_user_can( 'unfiltered_html' ) && !empty( $_POST['_bbp_unfiltered_html_forum'] ) && ( wp_create_nonce( 'bbp-unfiltered-html-forum_' . $forum_id ) === $_POST['_bbp_unfiltered_html_forum'] ) ) {
         remove_filter( 'bbp_edit_forum_pre_title',   'wp_filter_kses'      );
         remove_filter( 'bbp_edit_forum_pre_content', 'bbp_encode_bad',  10 );
@@ -509 +509 @@
 
     // Update revision log
-    if ( !empty( $_POST['bbp_log_forum_edit'] ) && ( 1 == $_POST['bbp_log_forum_edit'] ) && ( $revision_id = wp_save_post_revision( $forum_id ) ) ) {
+    if ( !empty( $_POST['bbp_log_forum_edit'] ) && ( 1 === $_POST['bbp_log_forum_edit'] ) && ( $revision_id = wp_save_post_revision( $forum_id ) ) ) {
         bbp_update_forum_revision_log( array(
             'forum_id'    => $forum_id,
@@ -539 +539 @@
         // as the first arg and new forum parent id as the second.
         // @todo implement
-        //if ( $forum_id != $forum->post_parent )
+        //if ( $forum_id !== $forum->post_parent )
         //  bbp_move_forum_handler( $forum_parent_id, $forum->post_parent, $forum_id );
 
@@ -612 +612 @@
 
     if ( !empty( $_POST['bbp_forum_status'] ) && in_array( $_POST['bbp_forum_status'], array( 'open', 'closed' ) ) ) {
-        if ( 'closed' == $_POST['bbp_forum_status'] && !bbp_is_forum_closed( $forum_id, false ) ) {
+        if ( 'closed' === $_POST['bbp_forum_status'] && !bbp_is_forum_closed( $forum_id, false ) ) {
             bbp_close_forum( $forum_id );
-        } elseif ( 'open' == $_POST['bbp_forum_status'] && bbp_is_forum_closed( $forum_id, false ) ) {
+        } elseif ( 'open' === $_POST['bbp_forum_status'] && bbp_is_forum_closed( $forum_id, false ) ) {
             bbp_open_forum( $forum_id );
         }
@@ -622 +622 @@
 
     if ( !empty( $_POST['bbp_forum_type'] ) && in_array( $_POST['bbp_forum_type'], array( 'forum', 'category' ) ) ) {
-        if ( 'category' == $_POST['bbp_forum_type'] && !bbp_is_forum_category( $forum_id ) ) {
+        if ( 'category' === $_POST['bbp_forum_type'] && !bbp_is_forum_category( $forum_id ) ) {
             bbp_categorize_forum( $forum_id );
-        } elseif ( 'forum' == $_POST['bbp_forum_type'] && bbp_is_forum_category( $forum_id ) ) {
+        } elseif ( 'forum' === $_POST['bbp_forum_type'] && bbp_is_forum_category( $forum_id ) ) {
             bbp_normalize_forum( $forum_id );
         }
@@ -799 +799 @@
 
     // Only run queries if visibility is changing
-    if ( bbp_get_public_status_id() != $current_visibility ) {
+    if ( bbp_get_public_status_id() !== $current_visibility ) {
 
         // Update forum post_status
@@ -828 +828 @@
 
     // Only run queries if visibility is changing
-    if ( bbp_get_private_status_id() != $current_visibility ) {
+    if ( bbp_get_private_status_id() !== $current_visibility ) {
 
         // Get hidden forums
@@ -877 +877 @@
 
     // Only run queries if visibility is changing
-    if ( bbp_get_hidden_status_id() != $current_visibility ) {
+    if ( bbp_get_hidden_status_id() !== $current_visibility ) {
 
         // Get private forums
@@ -1226 +1226 @@
 
     // Update only if published
-    if ( bbp_get_public_status_id() == get_post_status( $active_id ) )
+    if ( bbp_get_public_status_id() === get_post_status( $active_id ) )
         update_post_meta( $forum_id, '_bbp_last_active_id', (int) $active_id );
 
@@ -1476 +1476 @@
     }
 
-    if ( bbp_get_public_status_id() == $r['last_active_status'] ) {
+    if ( bbp_get_public_status_id() === $r['last_active_status'] ) {
         bbp_update_forum_last_active_time( $r['forum_id'], $r['last_active_time'] );
     }
@@ -1642 +1642 @@
 
     // Bail if filters are suppressed on this query
-    if ( true == $posts_query->get( 'suppress_filters' ) ) {
+    if ( true === $posts_query->get( 'suppress_filters' ) ) {
         return;
     }

trunk/includes/forums/template-tags.php

@@ -206 +206 @@
 
     // Tweak the data type to return
-    if ( $output == OBJECT ) {
+    if ( $output === OBJECT ) {
         return $forum;
 
-    } elseif ( $output == ARRAY_A ) {
+    } elseif ( $output === ARRAY_A ) {
         $_forum = get_object_vars( $forum );
         return $_forum;
 
-    } elseif ( $output == ARRAY_N ) {
+    } elseif ( $output === ARRAY_N ) {
         $_forum = array_values( get_object_vars( $forum ) );
         return $_forum;
@@ -1433 +1433 @@
     $forum_id = bbp_get_forum_id( $forum_id );
     $type     = bbp_get_forum_type( $forum_id );
-    $retval   = ( !empty( $type ) && 'category' == $type );
+    $retval   = ( !empty( $type ) && 'category' === $type );
 
     return (bool) apply_filters( 'bbp_is_forum_category', (bool) $retval, $forum_id );
@@ -1469 +1469 @@
 
         $forum_id = bbp_get_forum_id( $forum_id );
-        $retval    = ( bbp_get_closed_status_id() == bbp_get_forum_status( $forum_id ) );
+        $retval    = ( bbp_get_closed_status_id() === bbp_get_forum_status( $forum_id ) );
 
         if ( !empty( $check_ancestors ) ) {
@@ -1504 +1504 @@
 
     // If post status is public, return true
-    $retval = ( bbp_get_public_status_id() == $visibility );
+    $retval = ( bbp_get_public_status_id() === $visibility );
 
     // Check ancestors and inherit their privacy setting for display
@@ -1540 +1540 @@
 
     // If post status is private, return true
-    $retval = ( bbp_get_private_status_id() == $visibility );
+    $retval = ( bbp_get_private_status_id() === $visibility );
 
     // Check ancestors and inherit their privacy setting for display
@@ -1576 +1576 @@
 
     // If post status is private, return true
-    $retval = ( bbp_get_hidden_status_id() == $visibility );
+    $retval = ( bbp_get_hidden_status_id() === $visibility );
 
     // Check ancestors and inherit their privacy setting for display

trunk/includes/replies/capabilities.php

@@ -67 +67 @@
 
                     // Post is public
-                    if ( bbp_get_public_status_id() == $_post->post_status ) {
+                    if ( bbp_get_public_status_id() === $_post->post_status ) {
                         $caps = array( 'spectate' );
 
                     // User is author so allow read
-                    } elseif ( (int) $user_id == (int) $_post->post_author ) {
+                    } elseif ( (int) $user_id === (int) $_post->post_author ) {
                         $caps = array( 'spectate' );
 
@@ -127 +127 @@
 
                 // User is author so allow edit
-                } elseif ( (int) $user_id == (int) $_post->post_author ) {
+                } elseif ( (int) $user_id === (int) $_post->post_author ) {
                     $caps[] = $post_type->cap->edit_posts;
 

trunk/includes/replies/functions.php

@@ -210 +210 @@
 
     // Remove kses filters from title and content for capable users and if the nonce is verified
-    if ( current_user_can( 'unfiltered_html' ) && !empty( $_POST['_bbp_unfiltered_html_reply'] ) && wp_create_nonce( 'bbp-unfiltered-html-reply_' . $topic_id ) == $_POST['_bbp_unfiltered_html_reply'] ) {
+    if ( current_user_can( 'unfiltered_html' ) && !empty( $_POST['_bbp_unfiltered_html_reply'] ) && wp_create_nonce( 'bbp-unfiltered-html-reply_' . $topic_id ) === $_POST['_bbp_unfiltered_html_reply'] ) {
         remove_filter( 'bbp_new_reply_pre_title',   'wp_filter_kses'      );
         remove_filter( 'bbp_new_reply_pre_content', 'bbp_encode_bad',  10 );
@@ -336 +336 @@
         // If this reply starts as trash, add it to pre_trashed_replies
         // for the topic, so it is properly restored.
-        if ( bbp_is_topic_trash( $topic_id ) || ( $reply_data['post_status'] == bbp_get_trash_status_id() ) ) {
+        if ( bbp_is_topic_trash( $topic_id ) || ( $reply_data['post_status'] === bbp_get_trash_status_id() ) ) {
 
             // Trash the reply
@@ -357 +357 @@
 
         // If reply or topic are spam, officially spam this reply
-        } elseif ( bbp_is_topic_spam( $topic_id ) || ( $reply_data['post_status'] == bbp_get_spam_status_id() ) ) {
+        } elseif ( bbp_is_topic_spam( $topic_id ) || ( $reply_data['post_status'] === bbp_get_spam_status_id() ) ) {
             add_post_meta( $reply_id, '_bbp_spam_meta_status', bbp_get_public_status_id() );
 
@@ -501 +501 @@
 
     // Remove kses filters from title and content for capable users and if the nonce is verified
-    if ( current_user_can( 'unfiltered_html' ) && !empty( $_POST['_bbp_unfiltered_html_reply'] ) && wp_create_nonce( 'bbp-unfiltered-html-reply_' . $reply_id ) == $_POST['_bbp_unfiltered_html_reply'] ) {
+    if ( current_user_can( 'unfiltered_html' ) && !empty( $_POST['_bbp_unfiltered_html_reply'] ) && wp_create_nonce( 'bbp-unfiltered-html-reply_' . $reply_id ) === $_POST['_bbp_unfiltered_html_reply'] ) {
         remove_filter( 'bbp_edit_reply_pre_title',   'wp_filter_kses'      );
         remove_filter( 'bbp_edit_reply_pre_content', 'bbp_encode_bad',  10 );
@@ -580 +580 @@
 
         // Set post status to pending if public
-        if ( bbp_get_public_status_id() == $reply->post_status ) {
+        if ( bbp_get_public_status_id() === $reply->post_status ) {
             $reply_status = bbp_get_pending_status_id();
         }
@@ -661 +661 @@
 
     // Update revision log
-    if ( !empty( $_POST['bbp_log_reply_edit'] ) && ( 1 == $_POST['bbp_log_reply_edit'] ) ) {
+    if ( !empty( $_POST['bbp_log_reply_edit'] ) && ( 1 === $_POST['bbp_log_reply_edit'] ) ) {
         $revision_id = wp_save_post_revision( $reply_id );
         if ( !empty( $revision_id ) ) {
@@ -795 +795 @@
     if ( bbp_is_subscriptions_active() && !empty( $author_id ) && !empty( $topic_id ) ) {
         $subscribed = bbp_is_user_subscribed( $author_id, $topic_id );
-        $subscheck  = ( !empty( $_POST['bbp_topic_subscription'] ) && ( 'bbp_subscribe' == $_POST['bbp_topic_subscription'] ) ) ? true : false;
+        $subscheck  = ( !empty( $_POST['bbp_topic_subscription'] ) && ( 'bbp_subscribe' === $_POST['bbp_topic_subscription'] ) ) ? true : false;
 
         // Subscribed and unsubscribing
-        if ( true == $subscribed && false == $subscheck ) {
+        if ( true === $subscribed && false === $subscheck ) {
             bbp_remove_user_subscription( $author_id, $topic_id );
 
         // Subscribing
-        } elseif ( false == $subscribed && true == $subscheck ) {
+        } elseif ( false === $subscribed && true === $subscheck ) {
             bbp_add_user_subscription( $author_id, $topic_id );
         }
@@ -886 +886 @@
 
     // If we want a full refresh, unset any of the possibly passed variables
-    if ( true == $refresh )
+    if ( true === $refresh )
         $forum_id = $topic_id = $reply_id = $active_id = $last_active_time = 0;
 
@@ -983 +983 @@
 
                 // Get first parent that is a forum
-                if ( get_post_field( 'post_type', $ancestor ) == bbp_get_forum_post_type() ) {
+                if ( get_post_field( 'post_type', $ancestor ) === bbp_get_forum_post_type() ) {
                     $forum_id = $ancestor;
 
@@ -1032 +1032 @@
 
                 // Get first parent that is a forum
-                if ( get_post_field( 'post_type', $ancestor ) == bbp_get_topic_post_type() ) {
+                if ( get_post_field( 'post_type', $ancestor ) === bbp_get_topic_post_type() ) {
                     $topic_id = $ancestor;
 
@@ -1292 +1292 @@
 
                     // Shouldn't happen
-                    if ( false == $destination_topic_id || is_wp_error( $destination_topic_id ) || empty( $destination_topic ) ) {
+                    if ( false === $destination_topic_id || is_wp_error( $destination_topic_id ) || empty( $destination_topic ) ) {
                         bbp_add_error( 'bbp_move_reply_destination_reply', __( '<strong>ERROR</strong>: There was a problem converting the reply into the topic. Please try again.', 'bbpress' ) );
                     }
@@ -1352 +1352 @@
     // It is a new topic and we need to set some default metas to make
     // the topic display in bbp_has_topics() list
-    if ( 'topic' == $move_option ) {
+    if ( 'topic' === $move_option ) {
         bbp_update_topic_last_reply_id   ( $destination_topic->ID, $last_reply_id );
         bbp_update_topic_last_active_id  ( $destination_topic->ID, $last_reply_id );
@@ -1479 +1479 @@
 
     // What is the user doing here?
-    if ( !current_user_can( 'edit_reply', $reply->ID ) || ( 'bbp_toggle_reply_trash' == $action && !current_user_can( 'delete_reply', $reply->ID ) ) ) {
+    if ( !current_user_can( 'edit_reply', $reply->ID ) || ( 'bbp_toggle_reply_trash' === $action && !current_user_can( 'delete_reply', $reply->ID ) ) ) {
         bbp_add_error( 'bbp_toggle_reply_permission', __( '<strong>ERROR:</strong> You do not have the permission to do that!', 'bbpress' ) );
         return;
@@ -1540 +1540 @@
 
     // No errors
-    if ( ( false != $success ) && !is_wp_error( $success ) ) {
+    if ( ( false !== $success ) && !is_wp_error( $success ) ) {
 
         /** Redirect **********************************************************/
@@ -1589 +1589 @@
 
     // Bail if already spam
-    if ( bbp_get_spam_status_id() == $reply['post_status'] )
+    if ( bbp_get_spam_status_id() === $reply['post_status'] )
         return false;
 
@@ -1636 +1636 @@
 
     // Bail if already not spam
-    if ( bbp_get_spam_status_id() != $reply['post_status'] )
+    if ( bbp_get_spam_status_id() !== $reply['post_status'] )
         return false;
 
@@ -1858 +1858 @@
 
     // Bail if not a topic and reply query
-    if ( array( bbp_get_topic_post_type(), bbp_get_reply_post_type() ) != $query->get( 'post_type' ) ) {
+    if ( array( bbp_get_topic_post_type(), bbp_get_reply_post_type() ) !== $query->get( 'post_type' ) ) {
         return $where;
     }
@@ -2116 +2116 @@
 
     // If reply is actually the first post in a topic, return 0
-    if ( $reply_id != $topic_id ) {
+    if ( $reply_id !== $topic_id ) {
 
         // Make sure the topic has replies before running another query

trunk/includes/replies/template-tags.php

@@ -151 +151 @@
 
                 // Make sure it's a reply to a reply
-                if ( empty( $reply_to ) || ( bbp_get_reply_topic_id( $post->ID ) == $reply_to ) ) {
+                if ( empty( $reply_to ) || ( bbp_get_reply_topic_id( $post->ID ) === $reply_to ) ) {
                     $reply_to = 0;
                 }
@@ -342 +342 @@
         return null;
 
-    if ( $output == OBJECT ) {
+    if ( $output === OBJECT ) {
         return $reply;
 
-    } elseif ( $output == ARRAY_A ) {
+    } elseif ( $output === ARRAY_A ) {
         $_reply = get_object_vars( $reply );
         return $_reply;
 
-    } elseif ( $output == ARRAY_N ) {
+    } elseif ( $output === ARRAY_N ) {
         $_reply = array_values( get_object_vars( $reply ) );
         return $_reply;
@@ -827 +827 @@
  */
 function bbp_is_reply_published( $reply_id = 0 ) {
-    $reply_status = bbp_get_reply_status( bbp_get_reply_id( $reply_id ) ) == bbp_get_public_status_id();
+    $reply_status = bbp_get_reply_status( bbp_get_reply_id( $reply_id ) ) === bbp_get_public_status_id();
     return (bool) apply_filters( 'bbp_is_reply_published', (bool) $reply_status, $reply_id );
 }
@@ -842 +842 @@
  */
 function bbp_is_reply_spam( $reply_id = 0 ) {
-    $reply_status = bbp_get_reply_status( bbp_get_reply_id( $reply_id ) ) == bbp_get_spam_status_id();
+    $reply_status = bbp_get_reply_status( bbp_get_reply_id( $reply_id ) ) === bbp_get_spam_status_id();
     return (bool) apply_filters( 'bbp_is_reply_spam', (bool) $reply_status, $reply_id );
 }
@@ -857 +857 @@
  */
 function bbp_is_reply_trash( $reply_id = 0 ) {
-    $reply_status = bbp_get_reply_status( bbp_get_reply_id( $reply_id ) ) == bbp_get_trash_status_id();
+    $reply_status = bbp_get_reply_status( bbp_get_reply_id( $reply_id ) ) === bbp_get_trash_status_id();
     return (bool) apply_filters( 'bbp_is_reply_trash', (bool) $reply_status, $reply_id );
 }
@@ -1132 +1132 @@
 
             // Get avatar
-            if ( 'avatar' == $r['type'] || 'both' == $r['type'] ) {
+            if ( 'avatar' === $r['type'] || 'both' === $r['type'] ) {
                 $author_links['avatar'] = bbp_get_reply_author_avatar( $reply_id, $r['size'] );
             }
 
             // Get display name
-            if ( 'name' == $r['type']   || 'both' == $r['type'] ) {
+            if ( 'name' === $r['type']   || 'both' === $r['type'] ) {
                 $author_links['name'] = bbp_get_reply_author_display_name( $reply_id );
             }
@@ -1450 +1450 @@
         $ancestor_id = $reply_id;
         while ( $parent_id = bbp_get_reply_to( $ancestor_id ) ) {
-            if ( empty( $parent_id ) || ( $parent_id === $ancestor_id ) || ( bbp_get_reply_topic_id( $reply_id ) === $parent_id ) || ( $parent_id == $reply_id ) ) {
+            if ( empty( $parent_id ) || ( $parent_id === $ancestor_id ) || ( bbp_get_reply_topic_id( $reply_id ) === $parent_id ) || ( $parent_id === $reply_id ) ) {
                 break;
             }
@@ -1656 +1656 @@
 
             // Post is not the topic
-            if ( $reply_id != $topic_id ) {
+            if ( $reply_id !== $topic_id ) {
                 $reply_position = bbp_get_reply_position_raw( $reply_id, $topic_id );
 
@@ -2199 +2199 @@
         $classes[] = 'bbp-reply-position-' . bbp_get_reply_position( $reply_id );
         $classes[] = 'user-id-' . bbp_get_reply_author_id( $reply_id );
-        $classes[] = ( bbp_get_reply_author_id( $reply_id ) == bbp_get_topic_author_id( bbp_get_reply_topic_id( $reply_id ) ) ? 'topic-author' : '' );
+        $classes[] = ( bbp_get_reply_author_id( $reply_id ) === bbp_get_topic_author_id( bbp_get_reply_topic_id( $reply_id ) ) ? 'topic-author' : '' );
         $classes   = array_filter( $classes );
         $classes   = get_post_class( $classes, $reply_id );

trunk/includes/topics/capabilities.php

@@ -85 +85 @@
 
                     // Post is public
-                    if ( bbp_get_public_status_id() == $_post->post_status ) {
+                    if ( bbp_get_public_status_id() === $_post->post_status ) {
                         $caps = array( 'spectate' );
 
                     // User is author so allow read
-                    } elseif ( (int) $user_id == (int) $_post->post_author ) {
+                    } elseif ( (int) $user_id === (int) $_post->post_author ) {
                         $caps = array( 'spectate' );
 
@@ -145 +145 @@
 
                 // User is author so allow edit
-                } elseif ( (int) $user_id == (int) $_post->post_author ) {
+                } elseif ( (int) $user_id === (int) $_post->post_author ) {
                     $caps[] = $post_type->cap->edit_posts;
 

trunk/includes/topics/functions.php

@@ -157 +157 @@
 
     // Remove kses filters from title and content for capable users and if the nonce is verified
-    if ( current_user_can( 'unfiltered_html' ) && !empty( $_POST['_bbp_unfiltered_html_topic'] ) && wp_create_nonce( 'bbp-unfiltered-html-topic_new' ) == $_POST['_bbp_unfiltered_html_topic'] ) {
+    if ( current_user_can( 'unfiltered_html' ) && !empty( $_POST['_bbp_unfiltered_html_topic'] ) && wp_create_nonce( 'bbp-unfiltered-html-topic_new' ) === $_POST['_bbp_unfiltered_html_topic'] ) {
         remove_filter( 'bbp_new_topic_pre_title',   'wp_filter_kses'      );
         remove_filter( 'bbp_new_topic_pre_content', 'bbp_encode_bad',  10 );
@@ -304 +304 @@
         // If the forum is trash, or the topic_status is switched to
         // trash, trash it properly
-        if ( ( get_post_field( 'post_status', $forum_id ) == bbp_get_trash_status_id() ) || ( $topic_data['post_status'] == bbp_get_trash_status_id() ) ) {
+        if ( ( get_post_field( 'post_status', $forum_id ) === bbp_get_trash_status_id() ) || ( $topic_data['post_status'] === bbp_get_trash_status_id() ) ) {
 
             // Trash the reply
@@ -316 +316 @@
 
         // If reply or topic are spam, officially spam this reply
-        if ( $topic_data['post_status'] == bbp_get_spam_status_id() ) {
+        if ( $topic_data['post_status'] === bbp_get_spam_status_id() ) {
             add_post_meta( $topic_id, '_bbp_spam_meta_status', bbp_get_public_status_id() );
 
@@ -488 +488 @@
 
     // Remove kses filters from title and content for capable users and if the nonce is verified
-    if ( current_user_can( 'unfiltered_html' ) && !empty( $_POST['_bbp_unfiltered_html_topic'] ) && ( wp_create_nonce( 'bbp-unfiltered-html-topic_' . $topic_id ) == $_POST['_bbp_unfiltered_html_topic'] ) ) {
+    if ( current_user_can( 'unfiltered_html' ) && !empty( $_POST['_bbp_unfiltered_html_topic'] ) && ( wp_create_nonce( 'bbp-unfiltered-html-topic_' . $topic_id ) === $_POST['_bbp_unfiltered_html_topic'] ) ) {
         remove_filter( 'bbp_edit_topic_pre_title',   'wp_filter_kses'      );
         remove_filter( 'bbp_edit_topic_pre_content', 'bbp_encode_bad',  10 );
@@ -659 +659 @@
 
         // Update revision log
-        if ( !empty( $_POST['bbp_log_topic_edit'] ) && ( 1 == $_POST['bbp_log_topic_edit'] ) )  {
+        if ( !empty( $_POST['bbp_log_topic_edit'] ) && ( 1 === $_POST['bbp_log_topic_edit'] ) )  {
             $revision_id = wp_save_post_revision( $topic_id );
             if ( ! empty( $revision_id ) ) {
@@ -676 +676 @@
         // bbp_move_topic action and pass the topic's forum id as the
         // first arg and topic id as the second to update counts.
-        if ( $forum_id != $topic->post_parent ) {
+        if ( $forum_id !== $topic->post_parent ) {
             bbp_move_topic_handler( $topic_id, $topic->post_parent, $forum_id );
         }
@@ -822 +822 @@
     if ( bbp_is_subscriptions_active() && !empty( $author_id ) ) {
         $subscribed = bbp_is_user_subscribed( $author_id, $topic_id );
-        $subscheck  = ( !empty( $_POST['bbp_topic_subscription'] ) && ( 'bbp_subscribe' == $_POST['bbp_topic_subscription'] ) ) ? true : false;
+        $subscheck  = ( !empty( $_POST['bbp_topic_subscription'] ) && ( 'bbp_subscribe' === $_POST['bbp_topic_subscription'] ) ) ? true : false;
 
         // Subscribed and unsubscribing
-        if ( true == $subscribed && false == $subscheck ) {
+        if ( true === $subscribed && false === $subscheck ) {
             bbp_remove_user_subscription( $author_id, $topic_id );
 
         // Subscribing
-        } elseif ( false == $subscribed && true == $subscheck ) {
+        } elseif ( false === $subscribed && true === $subscheck ) {
             bbp_add_user_subscription( $author_id, $topic_id );
         }
@@ -905 +905 @@
 
     // If we want a full refresh, unset any of the possibly passed variables
-    if ( true == $refresh ) {
+    if ( true === $refresh ) {
         $forum_id = $topic_id = $reply_id = $active_id = $last_active_time = 0;
         $topic_status = bbp_get_public_status_id();
@@ -975 +975 @@
         // Loop through stickies of forum and add misses to the updated array
         foreach ( (array) $old_stickies as $sticky_topic_id ) {
-            if ( $topic_id != $sticky_topic_id ) {
+            if ( $topic_id !== $sticky_topic_id ) {
                 $updated_stickies[] = $sticky_topic_id;
             }
@@ -981 +981 @@
 
         // If stickies are different, update or delete them
-        if ( $updated_stickies != $old_stickies ) {
+        if ( $updated_stickies !== $old_stickies ) {
 
             // No more stickies so delete the meta
@@ -1176 +1176 @@
 
             // Shift the subscriber if told to
-            if ( !empty( $_POST['bbp_topic_subscribers'] ) && ( 1 == $_POST['bbp_topic_subscribers'] ) && bbp_is_subscriptions_active() )
+            if ( !empty( $_POST['bbp_topic_subscribers'] ) && ( 1 === $_POST['bbp_topic_subscribers'] ) && bbp_is_subscriptions_active() )
                 bbp_add_user_subscription( $subscriber, $destination_topic->ID );
 
@@ -1196 +1196 @@
 
             // Shift the favoriter if told to
-            if ( !empty( $_POST['bbp_topic_favoriters'] ) && 1 == $_POST['bbp_topic_favoriters'] )
+            if ( !empty( $_POST['bbp_topic_favoriters'] ) && 1 === $_POST['bbp_topic_favoriters'] )
                 bbp_add_user_favorite( $favoriter, $destination_topic->ID );
 
@@ -1213 +1213 @@
 
         // Shift the tags if told to
-        if ( !empty( $_POST['bbp_topic_tags'] ) && ( 1 == $_POST['bbp_topic_tags'] ) )
+        if ( !empty( $_POST['bbp_topic_tags'] ) && ( 1 === $_POST['bbp_topic_tags'] ) )
             wp_set_post_terms( $destination_topic->ID, $source_topic_tags, bbp_get_topic_tag_tax_id(), true );
 
@@ -1486 +1486 @@
 
                     // Shouldn't happen
-                    if ( false == $destination_topic_id || is_wp_error( $destination_topic_id ) || empty( $destination_topic ) ) {
+                    if ( false === $destination_topic_id || is_wp_error( $destination_topic_id ) || empty( $destination_topic ) ) {
                         bbp_add_error( 'bbp_split_topic_destination_reply', __( '<strong>ERROR</strong>: There was a problem converting the reply into the topic. Please try again.', 'bbpress' ) );
                     }
@@ -1527 +1527 @@
 
     // Copy the subscribers
-    if ( !empty( $_POST['bbp_topic_subscribers'] ) && 1 == $_POST['bbp_topic_subscribers'] && bbp_is_subscriptions_active() ) {
+    if ( !empty( $_POST['bbp_topic_subscribers'] ) && 1 === $_POST['bbp_topic_subscribers'] && bbp_is_subscriptions_active() ) {
 
         // Get the subscribers
@@ -1544 +1544 @@
 
     // Copy the favoriters if told to
-    if ( !empty( $_POST['bbp_topic_favoriters'] ) && 1 == $_POST['bbp_topic_favoriters'] ) {
+    if ( !empty( $_POST['bbp_topic_favoriters'] ) && 1 === $_POST['bbp_topic_favoriters'] ) {
 
         // Get the favoriters
@@ -1561 +1561 @@
 
     // Copy the tags if told to
-    if ( !empty( $_POST['bbp_topic_tags'] ) && ( 1 == $_POST['bbp_topic_tags'] ) ) {
+    if ( !empty( $_POST['bbp_topic_tags'] ) && ( 1 === $_POST['bbp_topic_tags'] ) ) {
 
         // Get the source topic tags
@@ -1629 +1629 @@
 
             // New topic from reply can't be a reply to
-            if ( ( $from_reply->ID == $destination_topic->ID && $from_reply->ID == $reply_to ) ) {
+            if ( ( $from_reply->ID === $destination_topic->ID && $from_reply->ID === $reply_to ) ) {
                 bbp_update_reply_to( $reply->ID, 0 );
             }
@@ -1638 +1638 @@
 
         // Remove reply to from new topic
-        if ( $from_reply->ID == $destination_topic->ID ) {
+        if ( $from_reply->ID === $destination_topic->ID ) {
             delete_post_meta( $from_reply->ID, '_bbp_reply_to' );
         }
@@ -1654 +1654 @@
     // It is a new topic and we need to set some default metas to make
     // the topic display in bbp_has_topics() list
-    if ( 'reply' == $split_option ) {
+    if ( 'reply' === $split_option ) {
         bbp_update_topic_last_reply_id   ( $destination_topic->ID, $last_reply_id );
         bbp_update_topic_last_active_id  ( $destination_topic->ID, $last_reply_id );
@@ -1843 +1843 @@
 
             // Attempting to merge a tag into itself
-            if ( $tag_id == $to_tag ) {
+            if ( $tag_id === $to_tag ) {
                 bbp_add_error( 'bbp_manage_topic_tag_merge_same', __( '<strong>ERROR</strong>: The tags which are being merged can not be the same.', 'bbpress' ) );
                 return;
@@ -2009 +2009 @@
 
     // What is the user doing here?
-    if ( !current_user_can( 'edit_topic', $topic->ID ) || ( 'bbp_toggle_topic_trash' == $action && !current_user_can( 'delete_topic', $topic->ID ) ) ) {
+    if ( !current_user_can( 'edit_topic', $topic->ID ) || ( 'bbp_toggle_topic_trash' === $action && !current_user_can( 'delete_topic', $topic->ID ) ) ) {
         bbp_add_error( 'bbp_toggle_topic_permission', __( '<strong>ERROR:</strong> You do not have the permission to do that.', 'bbpress' ) );
         return;
@@ -2032 +2032 @@
 
             $is_sticky = bbp_is_topic_sticky( $topic_id );
-            $is_super  = ( empty( $is_sticky ) && !empty( $_GET['super'] ) && 1 == (int) $_GET['super'] ) ? true : false;
+            $is_super  = ( empty( $is_sticky ) && !empty( $_GET['super'] ) && 1 === (int) $_GET['super'] ) ? true : false;
             $success   = $is_sticky ? bbp_unstick_topic( $topic_id ) : bbp_stick_topic( $topic_id, $is_super );
             $failure   = $is_sticky ? __( '<strong>ERROR</strong>: There was a problem unsticking the topic.', 'bbpress' ) : __( '<strong>ERROR</strong>: There was a problem sticking the topic.', 'bbpress' );
@@ -2091 +2091 @@
 
     // No errors
-    if ( false != $success && !is_wp_error( $success ) ) {
+    if ( false !== $success && !is_wp_error( $success ) ) {
 
         // Redirect back to the topic's forum
-        if ( isset( $sub_action ) && ( 'delete' == $sub_action ) ) {
+        if ( isset( $sub_action ) && ( 'delete' === $sub_action ) ) {
             $redirect = bbp_get_forum_permalink( $success->post_parent );
 
@@ -2409 +2409 @@
 
     // Update only if published
-    if ( bbp_get_public_status_id() == get_post_status( $active_id ) ) {
+    if ( bbp_get_public_status_id() === get_post_status( $active_id ) ) {
         update_post_meta( $topic_id, '_bbp_last_active_id', (int) $active_id );
     }
@@ -2640 +2640 @@
 
     // Bail if already closed
-    if ( bbp_get_closed_status_id() == $topic['post_status'] )
+    if ( bbp_get_closed_status_id() === $topic['post_status'] )
         return false;
 
@@ -2686 +2686 @@
 
     // Bail if already open
-    if ( bbp_get_closed_status_id() != $topic['post_status'])
+    if ( bbp_get_closed_status_id() !== $topic['post_status'])
         return false;
 
@@ -2734 +2734 @@
 
     // Bail if topic is spam
-    if ( bbp_get_spam_status_id() == $topic['post_status'] )
+    if ( bbp_get_spam_status_id() === $topic['post_status'] )
         return false;
 
@@ -2843 +2843 @@
 
     // Bail if already not spam
-    if ( bbp_get_spam_status_id() != $topic['post_status'] )
+    if ( bbp_get_spam_status_id() !== $topic['post_status'] )
         return false;
 

trunk/includes/topics/template-tags.php

@@ -148 +148 @@
 
     // Set post_parent back to 0 if originally set to 'any'
-    if ( 'any' == $r['post_parent'] )
+    if ( 'any' === $r['post_parent'] )
         $r['post_parent'] = 0;
 
@@ -270 +270 @@
 
     // If no limit to posts per page, set it to the current post_count
-    if ( -1 == $r['posts_per_page'] )
+    if ( -1 === $r['posts_per_page'] )
         $r['posts_per_page'] = $bbp->topic_query->post_count;
 
@@ -340 +340 @@
             'base'      => $base,
             'format'    => '',
-            'total'     => $r['posts_per_page'] == $bbp->topic_query->found_posts ? 1 : ceil( (int) $bbp->topic_query->found_posts / (int) $r['posts_per_page'] ),
+            'total'     => $r['posts_per_page'] === $bbp->topic_query->found_posts ? 1 : ceil( (int) $bbp->topic_query->found_posts / (int) $r['posts_per_page'] ),
             'current'   => (int) $bbp->topic_query->paged,
             'prev_text' => is_rtl() ? '→' : '←',
@@ -486 +486 @@
 
     // Tweak the data type to return
-    if ( $output == OBJECT ) {
+    if ( $output === OBJECT ) {
         return $topic;
 
-    } elseif ( $output == ARRAY_A ) {
+    } elseif ( $output === ARRAY_A ) {
         $_topic = get_object_vars( $topic );
         return $_topic;
 
-    } elseif ( $output == ARRAY_N ) {
+    } elseif ( $output === ARRAY_N ) {
         $_topic = array_values( get_object_vars( $topic ) );
         return $_topic;
@@ -1059 +1059 @@
      */
     function bbp_is_topic_closed( $topic_id = 0 ) {
-        $closed = bbp_get_topic_status( $topic_id ) == bbp_get_closed_status_id();
+        $closed = bbp_get_topic_status( $topic_id ) === bbp_get_closed_status_id();
         return (bool) apply_filters( 'bbp_is_topic_closed', (bool) $closed, $topic_id );
     }
@@ -1118 +1118 @@
  */
 function bbp_is_topic_published( $topic_id = 0 ) {
-    $topic_status = bbp_get_topic_status( bbp_get_topic_id( $topic_id ) ) == bbp_get_public_status_id();
+    $topic_status = bbp_get_topic_status( bbp_get_topic_id( $topic_id ) ) === bbp_get_public_status_id();
     return (bool) apply_filters( 'bbp_is_topic_published', (bool) $topic_status, $topic_id );
 }
@@ -1134 +1134 @@
  */
 function bbp_is_topic_spam( $topic_id = 0 ) {
-    $topic_status = bbp_get_topic_status( bbp_get_topic_id( $topic_id ) ) == bbp_get_spam_status_id();
+    $topic_status = bbp_get_topic_status( bbp_get_topic_id( $topic_id ) ) === bbp_get_spam_status_id();
     return (bool) apply_filters( 'bbp_is_topic_spam', (bool) $topic_status, $topic_id );
 }
@@ -1150 +1150 @@
  */
 function bbp_is_topic_trash( $topic_id = 0 ) {
-    $topic_status = bbp_get_topic_status( bbp_get_topic_id( $topic_id ) ) == bbp_get_trash_status_id();
+    $topic_status = bbp_get_topic_status( bbp_get_topic_id( $topic_id ) ) === bbp_get_trash_status_id();
     return (bool) apply_filters( 'bbp_is_topic_trash', (bool) $topic_status, $topic_id );
 }
@@ -1429 +1429 @@
 
             // Get avatar
-            if ( 'avatar' == $r['type'] || 'both' == $r['type'] ) {
+            if ( 'avatar' === $r['type'] || 'both' === $r['type'] ) {
                 $author_links['avatar'] = bbp_get_topic_author_avatar( $topic_id, $r['size'] );
             }
 
             // Get display name
-            if ( 'name' == $r['type'] || 'both' == $r['type'] ) {
+            if ( 'name' === $r['type'] || 'both' === $r['type'] ) {
                 $author_links['name'] = bbp_get_topic_author_display_name( $topic_id );
             }
@@ -1864 +1864 @@
         $reply_id = bbp_get_topic_last_reply_id( $topic_id );
 
-        if ( !empty( $reply_id ) && ( $reply_id != $topic_id ) ) {
+        if ( !empty( $reply_id ) && ( $reply_id !== $topic_id ) ) {
             $reply_url = bbp_get_reply_url( $reply_id );
         } else {
@@ -2607 +2607 @@
         $stick_uri = esc_url( wp_nonce_url( $stick_uri, 'stick-topic_' . $topic->ID ) );
 
-        $stick_display = true == $is_sticky ? $r['unstick_text'] : $r['stick_text'];
+        $stick_display = true === $is_sticky ? $r['unstick_text'] : $r['stick_text'];
         $stick_display = '<a href="' . $stick_uri . '">' . $stick_display . '</a>';
 
@@ -3628 +3628 @@
 
             // Post author is not the current user
-            if ( bbp_get_current_user_id() != $post_author ) {
+            if ( bbp_get_current_user_id() !== $post_author ) {
                 $topic_subscribed = bbp_is_user_subscribed( $post_author );
 

trunk/includes/users/capabilities.php

@@ -69 +69 @@
 
         // User already has this role so no new role is set
-        if ( $new_role == $role ) {
+        if ( $new_role === $role ) {
             $new_role = false;
 
@@ -193 +193 @@
 
     // Bail if no role change
-    if ( $new_role == $forums_role )
+    if ( $new_role === $forums_role )
         return;
 
@@ -281 +281 @@
 
     // Add the user to the site
-    if ( true == $add_to_site ) {
+    if ( true === $add_to_site ) {
 
         // Make sure bbPress roles are added

trunk/includes/users/functions.php

@@ -32 +32 @@
 
     // $url was manually set in wp-login.php to redirect to admin
-    elseif ( admin_url() == $url )
+    elseif ( admin_url() === $url )
         $url = home_url();
 
@@ -473 +473 @@
     $success     = false;
 
-    if ( true == $is_favorite && 'bbp_favorite_remove' == $action )
+    if ( true === $is_favorite && 'bbp_favorite_remove' === $action )
         $success = bbp_remove_user_favorite( $user_id, $topic_id );
-    elseif ( false == $is_favorite && 'bbp_favorite_add' == $action )
+    elseif ( false === $is_favorite && 'bbp_favorite_add' === $action )
         $success = bbp_add_user_favorite( $user_id, $topic_id );
 
@@ -482 +482 @@
 
     // Success!
-    if ( true == $success ) {
+    if ( true === $success ) {
 
         // Redirect back from whence we came
@@ -503 +503 @@
 
     // Fail! Handle errors
-    } elseif ( true == $is_favorite && 'bbp_favorite_remove' == $action ) {
+    } elseif ( true === $is_favorite && 'bbp_favorite_remove' === $action ) {
         bbp_add_error( 'bbp_favorite_remove', __( '<strong>ERROR</strong>: There was a problem removing that topic from favorites!', 'bbpress' ) );
-    } elseif ( false == $is_favorite && 'bbp_favorite_add' == $action ) {
+    } elseif ( false === $is_favorite && 'bbp_favorite_add' === $action ) {
         bbp_add_error( 'bbp_favorite_add',    __( '<strong>ERROR</strong>: There was a problem favoriting that topic!', 'bbpress' ) );
     }
@@ -786 +786 @@
     $success         = false;
 
-    if ( true == $is_subscription && 'bbp_unsubscribe' == $action )
+    if ( true === $is_subscription && 'bbp_unsubscribe' === $action )
         $success = bbp_remove_user_subscription( $user_id, $topic_id );
-    elseif ( false == $is_subscription && 'bbp_subscribe' == $action )
+    elseif ( false === $is_subscription && 'bbp_subscribe' === $action )
         $success = bbp_add_user_subscription( $user_id, $topic_id );
 
@@ -795 +795 @@
 
     // Success!
-    if ( true == $success ) {
+    if ( true === $success ) {
 
         // Redirect back from whence we came
@@ -816 +816 @@
 
     // Fail! Handle errors
-    } elseif ( true == $is_subscription && 'bbp_unsubscribe' == $action ) {
+    } elseif ( true === $is_subscription && 'bbp_unsubscribe' === $action ) {
         bbp_add_error( 'bbp_unsubscribe', __( '<strong>ERROR</strong>: There was a problem unsubscribing from that topic!', 'bbpress' ) );
-    } elseif ( false == $is_subscription && 'bbp_subscribe' == $action ) {
+    } elseif ( false === $is_subscription && 'bbp_subscribe' === $action ) {
         bbp_add_error( 'bbp_subscribe',    __( '<strong>ERROR</strong>: There was a problem subscribing to that topic!', 'bbpress' ) );
     }
@@ -868 +868 @@
         $new_email = get_option( $user_id . '_new_email' );
 
-        if ( $new_email['hash'] == $_GET['newuseremail'] ) {
+        if ( $new_email['hash'] === $_GET['newuseremail'] ) {
             $user             = new stdClass();
             $user->ID         = $user_id;
@@ -887 +887 @@
 
     // Delete new email address from user options
-    } elseif ( is_multisite() && bbp_is_user_home_edit() && !empty( $_GET['dismiss'] ) && ( $user_id . '_new_email' == $_GET['dismiss'] ) ) {
+    } elseif ( is_multisite() && bbp_is_user_home_edit() && !empty( $_GET['dismiss'] ) && ( $user_id . '_new_email' === $_GET['dismiss'] ) ) {
         delete_option( $user_id . '_new_email' );
         wp_safe_redirect( add_query_arg( array( 'updated' => 'true' ), bbp_get_user_profile_edit_url( $user_id ) ) );

trunk/includes/users/options.php

@@ -153 +153 @@
 
         $count  = (int) get_user_option( '_bbp_topic_count', $user_id );
-        $filter = ( false == $integer ) ? 'bbp_get_user_topic_count_int' : 'bbp_get_user_topic_count';
+        $filter = ( false === $integer ) ? 'bbp_get_user_topic_count_int' : 'bbp_get_user_topic_count';
 
         return apply_filters( $filter, $count, $user_id );
@@ -191 +191 @@
 
         $count  = (int) get_user_option( '_bbp_reply_count', $user_id );
-        $filter = ( true == $integer ) ? 'bbp_get_user_topic_count_int' : 'bbp_get_user_topic_count';
+        $filter = ( true === $integer ) ? 'bbp_get_user_topic_count_int' : 'bbp_get_user_topic_count';
 
         return apply_filters( $filter, $count, $user_id );
@@ -231 +231 @@
         $replies = bbp_get_user_reply_count( $user_id, true );
         $count   = (int) $topics + $replies;
-        $filter  = ( true == $integer ) ? 'bbp_get_user_post_count_int' : 'bbp_get_user_post_count';
+        $filter  = ( true === $integer ) ? 'bbp_get_user_post_count_int' : 'bbp_get_user_post_count';
 
         return apply_filters( $filter, $count, $user_id );

trunk/includes/users/template-tags.php

@@ -1237 +1237 @@
 
     // loggedout was passed
-    if ( !empty( $_GET['loggedout'] ) && ( true == $_GET['loggedout'] ) ) {
+    if ( !empty( $_GET['loggedout'] ) && ( true === $_GET['loggedout'] ) ) {
         bbp_add_error( 'loggedout', __( 'You are now logged out.', 'bbpress' ), 'message' );
 
     // registration is disabled
-    } elseif ( !empty( $_GET['registration'] ) && ( 'disabled' == $_GET['registration'] ) ) {
+    } elseif ( !empty( $_GET['registration'] ) && ( 'disabled' === $_GET['registration'] ) ) {
         bbp_add_error( 'registerdisabled', __( 'New user registration is currently not allowed.', 'bbpress' ) );
 
@@ -1445 +1445 @@
 
             // Get avatar
-            if ( 'avatar' == $r['type'] || 'both' == $r['type'] ) {
+            if ( 'avatar' === $r['type'] || 'both' === $r['type'] ) {
                 $author_links[] = get_avatar( $user_id, $r['size'] );
             }
 
             // Get display name
-            if ( 'name' == $r['type'] || 'both' == $r['type'] ) {
+            if ( 'name' === $r['type'] || 'both' === $r['type'] ) {
                 $author_links[] = get_the_author_meta( 'display_name', $user_id );
             }

trunk/templates/default/bbpress/form-user-edit.php

@@ -109 +109 @@
             // Handle address change requests
             $new_email = get_option( bbp_get_displayed_user_id() . '_new_email' );
-            if ( $new_email && $new_email != bbp_get_displayed_user_field( 'user_email', 'edit' ) ) : ?>
+            if ( !empty( $new_email ) && $new_email !== bbp_get_displayed_user_field( 'user_email', 'edit' ) ) : ?>
 
                 <span class="updated inline">

trunk/templates/default/bbpress/loop-single-topic.php

@@ -62 +62 @@
             <?php do_action( 'bbp_theme_after_topic_started_by' ); ?>
 
-            <?php if ( !bbp_is_single_forum() || ( bbp_get_topic_forum_id() != bbp_get_forum_id() ) ) : ?>
+            <?php if ( !bbp_is_single_forum() || ( bbp_get_topic_forum_id() !== bbp_get_forum_id() ) ) : ?>
 
                 <?php do_action( 'bbp_theme_before_topic_started_in' ); ?>