Changeset 4059 for branches/plugin/bbp-includes/bbp-topic-functions.php

Timestamp:

07/05/2012 05:32:33 AM (13 years ago)

Author:

johnjamesjacoby

Message:

Performance:

• Add 'numeric' to applicable meta-queries to avoid casting as char.
• Remove meta-queries, and use post_parent where possible.
• Introduce _bbp_has_replies_where() filter, attached to 'posts_where' which is responsible for adding the lead topic to the results. This avoids having to use a costly meta-query, potentially resulting in full table scans.
• Audit meta-queries, and tweak where needed.
• Fixes #1885.
• Props vibol for investigation.

File:

• branches/plugin/bbp-includes/bbp-topic-functions.php (modified) (4 diffs)

branches/plugin/bbp-includes/bbp-topic-functions.php

@@ -2831 +2831 @@
 
     // Topic is being permanently deleted, so its replies gotta go too
+    // @todo remove meta query
     if ( bbp_has_replies( array(
         'post_type'      => bbp_get_reply_post_type(),
@@ -2838 +2839 @@
             'key'        => '_bbp_topic_id',
             'value'      => $topic_id,
+            'type'       => 'numeric',
             'compare'    => '='
         ) )
@@ -2875 +2877 @@
 
     // Topic is being trashed, so its replies are trashed too
+    // @todo remove meta query
     if ( bbp_has_replies( array( 
         'post_type'      => bbp_get_reply_post_type(),
@@ -2882 +2885 @@
             'key'        => '_bbp_topic_id',
             'value'      => $topic_id,
+            'type'       => 'numeric',
             'compare'    => '='
         ) )