Changeset 4059 for branches/plugin/bbp-includes/bbp-core-shortcodes.php

Timestamp:

07/05/2012 05:32:33 AM (13 years ago)

Author:

johnjamesjacoby

Message:

Performance:

• Add 'numeric' to applicable meta-queries to avoid casting as char.
• Remove meta-queries, and use post_parent where possible.
• Introduce _bbp_has_replies_where() filter, attached to 'posts_where' which is responsible for adding the lead topic to the results. This avoids having to use a costly meta-query, potentially resulting in full table scans.
• Audit meta-queries, and tweak where needed.
• Fixes #1885.
• Props vibol for investigation.

File:

• branches/plugin/bbp-includes/bbp-core-shortcodes.php (modified) (2 diffs)

branches/plugin/bbp-includes/bbp-core-shortcodes.php

@@ -377 +377 @@
         }
 
-        // Filter the query
-        if ( ! bbp_is_single_topic() ) {
-            add_filter( 'bbp_before_has_replies_parse_args', array( $this, 'display_topic_query' ) );
-        }
-
         // Start output buffer
         $this->start( 'bbp_single_topic' );
@@ -749 +744 @@
         $args['show_stickies'] = true;
         $args['order']         = 'DESC';
-        return $args;
-    }
-
-    /**
-     * Filter the query for the topic index
-     *
-     * @since bbPress (r3637)
-     *
-     * @param array $args
-     * @return array
-     */
-    public function display_topic_query( $args = array() ) {
-        $args['meta_query'] = array( array(
-            'key'     => '_bbp_topic_id',
-            'value'   => bbpress()->current_topic_id,
-            'compare' => '='
-        ) );
-
         return $args;
     }