Skip to:
Content

bbPress.org

{33} Commit Messages, Current Release (4819 matches)

Report designed to help manage the list of contributors.

Note: If you'd like a RSS feed of the changesets a they happen, Please use the timeline rss feed instead.

Results (1401 - 1500 of 4819)

Changeset Author Message
[5080] johnjamesjacoby Separate content replacement from title replacement in forum and topic archives, allowing pages with matching slugs but empty post_content to replace the_content as expected. Fixes situation where a user creates a "Forums" page and leaves the content empty, expecting bbPress to replace it. Also use the $page->ID to help "Edit" links to point to the correct post ID.
[3717] johnjamesjacoby Separate bbp-core-compatibility.php into smaller, less-confusing parts: * bbp-theme-compatibility.php - the API that makes existing themes compatible * bbp-template-functions.php - functions used to find and load bbPress templates * bbp-template-loader.php - similar to the WordPress template loader, it handles the logic of what template to display * Move commonly used functions into bbp-common-functions.php * Update bbpress.php to require() new files
[3399] johnjamesjacoby Separate actions and filters in BBP_BuddyPress class. Introduce activity_can_comment() and activity_get_permalink() filters to force bbPress's activity stream items to behave exactly like they do currently with group forums.
[3179] johnjamesjacoby Security sweep and code clean-up through bbp-reply-functions.php. See #1514.
[3225] johnjamesjacoby Second round of bbPress standalone importer updates. Props !GautamGupta. See #1523.
[6824] johnjamesjacoby Search: update `bbp_get_search_terms()` to only accept a string. This change prevents non-string payloads from being encoded & trimmed.
[7280] johnjamesjacoby Search: remove `array_keys()` from This change ensures that the correct public statuses are used by default inside of the `bbp_has_search_results()` function, and it does this by using the values from `bbp_get_public_topic_statuses()` and not the keys. This fixes a regression causing search results to omit public statuses as part of their default arguments. Props GDragoN. Fixes #3607.
[7262] johnjamesjacoby Search: prevent hidden forums from appearing in results. This change includes the following changes: * Removes `readable` perm check from `bbp_has_search_results()` and replaces it with public topic statuses by default, while conditionally adding private & hidden statuses if user is capable * Tweaks the logic inside of `bbp_pre_get_posts_normalize_forum_visibility()` to always handle both of its internal conditions (forum query, or any query that includes forums/topics/replies connected via meta data) * Tweaks output of `content-search.php` template part to not show the "Oh bother" error when visiting a search page for the first time * Adds a string `feedback-no-search.php` template part to address both "no results" and "no terms" conditions These changes address some faulty search logic that was allowing hidden forums to appear in global search results to users who should not have been able to see them, while also improving the search page experience itself. Fixes #3473. Props wpsolr, robin-w. In branches/2.6, for 2.6.10.
[6630] johnjamesjacoby Search: move `bbp_allow_search()` checks into form template parts. This allows the inclusion of those forms without needing to wrap each inclusion statement in its own feature check, making search a more atomic and isolated feature within bbPress. It also should conclude the development of the user content search functionality. Because this involves some template-part changes to the "Default" template pack, users who have opted to override these parts in their own themes will not receive these updates (nor should they.) This is a known consequence of including template parts in themes, so while still not an ideal system, will not result in any breakage for existing sites.
[6903] johnjamesjacoby Search: add support for `fs` query-arg to search forums list: * Introduces `bbp_sanitize_search_request()` to encapsulate duplicate code across forums/topics/replies * Introduces `bbp_get_search_type_ids()` to stub out future enhancements (tags, users, etc...) * Use these new functions where intended * Update `bbp_get_search_terms()` to loop through known search-type IDs This commit also fixes debug notices that would happen when these query arguments were not explicitly strings. Fixes #3245.
[6629] johnjamesjacoby Search: Use correct `rs` request key. Fixes a debug notice when searching replies inside of topics.
[6620] johnjamesjacoby Search: Escape output of `bbp_search_terms()` and wire-up to `ts` and `rs`.
[7076] johnjamesjacoby Search/Rewrites: unslash search terms inside `bbp_get_search_terms()`. This commit ensures that search terms appear correctly inside of template output, without additional slashes. It also eliminates a few repeated calls to `bbp_get_search_rewrite_id()`, and more strictly compares rewrite rule query vars to null results for improved code clarity & consistency. Props dd32, johnjamesjacoby. See #3357. Trunk, for 2.7.0.
[7077] johnjamesjacoby Search/Rewrites: unslash search terms inside `bbp_get_search_terms()`. This commit ensures that search terms appear correctly inside of template output, without additional slashes. It also eliminates a few repeated calls to `bbp_get_search_rewrite_id()`, and more strictly compares rewrite rule query vars to null results for improved code clarity & consistency. Props dd32, johnjamesjacoby. Fixes #3357. 2.6 branch, for 2.6.5.
[4618] johnjamesjacoby Search Tweaks: * Add support for search root page. * Add search root page to breadcrumb. * Tweak search form CSS. * See #1575.
[6641] johnjamesjacoby Scripts: Do not enqueue if not `is_bbpress()`. This reduces the number of external scripts that are enqueued on non-bbPress pages. Put another way, it makes sure that bbPress styles & scripts are only loaded on pages where bbPress content is known to exist. Fibes #3138. Props DJPaul.
[4203] johnjamesjacoby Scripts: * Create empty .min files where warranted. * Rejig green admin scheme CSS files to use .min.
[2817] johnjamesjacoby Sanity checks on logout redirection global variables
[3227] johnjamesjacoby Sanity check on user roles to prevent error if user does not have a role assigned to them.
[3426] johnjamesjacoby Sanity check nickname in bbp_edit_user_display_name() to prevent potential debug notice. Fixes #1597. Props !GautamGupta.
[3423] johnjamesjacoby Sanity check $wp_roles and set if not already set.
[7042] netweb SVN: Set `svn:mime-type` to `text/xml` for *.xml.dist files
[5690] netweb SVN: Remove invalid SVN property `sv:eol-style` from image files in `/branches/2.0` and `/tags/2.0.x`
[3986] johnjamesjacoby SVN properties: * Add EOL native to new feedback-no-replies.php template part. * Fixes #1851.
[2906] johnjamesjacoby SVN add bbp-update.php from previous revision
[5576] netweb SMF importer: Include Subscribed Forums and Subscribed Topics Props netweb. See #2668
[5332] netweb SMF Importer BBCode regex expressions * Fix copy pasta `<br>`/`<tt>` regex * Add non-break space `&nbsp;` to space ` ` rexex Props mspecht. Fixes @2558
[2809] johnjamesjacoby Run strip_tags and trim on topic and reply excerpts. Fixes #1448.
[3308] johnjamesjacoby Round 2 of Akismet updates. Fixes #1553. Props cnorris23.
[7257] johnjamesjacoby Roles: prevent notices when calling `bbp_add_forums_roles()` This change adds sanity checks around the `$wp_roles` parameter of the `bbp_add_forums_roles()` function. It will now attempt to initialize the `WP_Roles` class just-in-time, but only if not already doing the `wp_roles_init` action (to prevent recursion). If after all of that `$wp_roles` is still not what it needs to be, this function will now silently bail instead of proceeding (to prevent debug notices & errors). Fixes #3493. Props naxoc. In branches/2.6, for 2.6.10.
[6667] johnjamesjacoby Roles: account for empty role in `bbp_set_current_user_default_role()` This change makes sure that if a user's role does not match any known role, they still receive the default role for the site. Trunk, for 2.6.
[6116] johnjamesjacoby Roles: Remove overzealous usages of `bbp_add_forums_roles()`. Now that the `wp_roles_init` action exists, we can rely on bbPress roles being registered an available, and no longer need to re-reinitalize them before trying to interact with them. See: #2959.
[6147] johnjamesjacoby Roles: Port `bbp_roles_init()` from trunk to 2.5 branch. See: #3028.
[6107] johnjamesjacoby Roles: Modify `bbp_add_forums_roles()` to accept a `WP_Roles` object as a parameter. This allows dynamic roles to be initialized on each call to `wp_roles_init` (for WordPress 4.7) rather than relying on the guesswork of blog-switching, option-sniffing, or user init'ing (none of which have ever been good indicators of roles being initialized.) See: #2452.
[6106] johnjamesjacoby Roles: Introduce `bbp_roles_init` subaction, and use this for future dynamic roles initialization. See: #2452;
[6108] johnjamesjacoby Roles: Improve performance of `bbp_get_dynamic_roles()` with a local static variable. Previously, it rebuilt the multidimensional array of role keys & strings each time it was called, which may be several depending on the page being loaded. See: #2452.
[6120] johnjamesjacoby Roles: Fix infinite loops from load order changes in WordPress 4.7. * Do not translate "role names" which are actually role IDs * Add dummy function so literal role names are part of the pomo dictionary * Introduce `common/locale.php` for future localization code * Introduce `bbp_translate_user_role()` to help with outputting literal role names in the proper language See #3017. 2.5 branch (for 2.5.11)
[6118] johnjamesjacoby Roles: Fix infinite loops from load order changes in WordPress 4.7. * Do not translate "role names" which are actually role IDs * Add dummy function so literal role names are part of the pomo dictionary * Introduce `common/locale.php` for future localization code * Introduce `roles` variable to main bbPress class, and store loaded roles there * Introduce `bbp_translate_user_role()` to help with outputting literal role names in the proper language See #3017. For trunk (2.6)
[4450] johnjamesjacoby Roles: * get_editable_roles() is an admin function, so copy over functionality into bbp_get_user_blog_role(). * See #2042 (trunk)
[4449] johnjamesjacoby Roles: * get_editable_roles() is an admin function, so copy over functionality into bbp_get_user_blog_role(). * See #2042 (2.2 branch)
[4527] johnjamesjacoby Roles: * When updating bbPress and normalizing user roles, remove the old moderator and participant roles from the database. * Props jmdodd. * Fixes #2065.
[4528] johnjamesjacoby Roles: * When updating bbPress and normalizing user roles, remove the old moderator and participant roles from the database. * Move !BuddyPress role removal into groups repair tool. * See #2065 (2.2 branch)
[4447] johnjamesjacoby Roles: * Remove unused Visitor role. * Map non-WordPress roles to default role. * Hat-tip nerrad for confirmation/testing. * Fixes #2042 (trunk)
[4448] johnjamesjacoby Roles: * Remove unused Visitor role. * Map non-WordPress roles to default role. * Hat-tip nerrad for confirmation/testing. * Fixes #2042 (2.2 branch)
[6889] johnjamesjacoby Rewrites: use `property_exists()` on `$wp_rewrite` global touches. This makes sure that bbPress defaults are preferred, and avoids fatal errors if class properties are unset. Also relocate `bbp_use_pretty_urls()` to better group it together with other `bbp_rewrite()` wrappers.
[4321] johnjamesjacoby Rewrites: * Introduce unique rewrite tags and rules for user topics and replies. * Fixes conflict with topic and reply post type rules. * Fixes bug where user topics and replies pages were not working on some installations.
[6079] netweb Rewrite Rules: Update search permastruct in `bbPress::add_permastructs()` to `$search_id` This changeset fixes copy pasta introduced in r4930, and updates the search rewrite to use the `$search_id` and not the `$user_id` as the permalink structure name. Props offereins. Fixes #2984.
[4427] johnjamesjacoby Revisions: * Use correct post type in replies. * See #2029.
[4426] johnjamesjacoby Revisions: * Since we do our own revision handling, turn off revisions for the initial call to wp_update_post() in topics and replies. * We check if the post type supports revisions, and toggle them off and back on to avoid duplicate revisions from specifically saving it later in the edit process. * Fixes #2029.
[4428] johnjamesjacoby Revisions: * In bbp_get_reply_revision_log(), check the post type, and maybe return bbp_get_topic_revision_log() if post is a topic in the replies loop. * This happens when bbp_show_lead_topic() is set to false, which is the default. * See #2029.
[2597] johnjamesjacoby Revert to colloquial barbarisms (content type/post type)
[6854] johnjamesjacoby Revert r6853. This breaks pages with matching slug paths. Will revisit this more thoroughly in a future version.
[5273] johnjamesjacoby Revert r5270, r5271. Let's try to get our history back. Antiprops johnjamesjacoby.
[4637] johnjamesjacoby Revert r4625, as it could cause spam topics to become published. Will need to rethink/revisit this in 2.4. See #2125.
[3472] johnjamesjacoby Revert r3471 as it introduced added layer of complexity and potentially confusing function names.
[3408] johnjamesjacoby Revert r3407 and r3405 and move overflow styling into correct locations.
[3377] johnjamesjacoby Revert r3369.
[3258] johnjamesjacoby Revert r3257 for something more elegant.
[2961] johnjamesjacoby Revert previous admin menu separator sanity checks until it can be researched further.
[6568] johnjamesjacoby Revert part of r6567, and instead skip the page condition completely. This makes sure that forms are made available to moderators regardless of the page condition, and fixes a situation where per-forum moderators couldn't publish to forums or topics that were closed.
[5165] johnjamesjacoby Revert part of r5164 that moved the `$r` array within a `bbp_is_forum_category()` check in `bbp_get_forum_subscription_link()`, as it caused debug notices from `$r` not being defined. See #2475.
[5124] johnjamesjacoby Revert part of r5060. Fixes issues with setting forum statuses. Props netweb. (2.4.1)
[5000] johnjamesjacoby Revert part of r4995 that introduced strict comparisons in bbp_get_time_since() against return values of floor(), which returns a float. See #2358.
[4599] johnjamesjacoby Revert part of r4594, and move #post ID to bbp-reply-header element. Fixes regression with not being taken to #post-ID on reply publish and edit.
[3937] johnjamesjacoby Revert part of r3936 and use correct parent class for reply permalinks.
[3725] johnjamesjacoby Revert part of r3703 as it was causing comment forms and page edit links to reappear in some themes. Instead, introduce bbp_reset_post_data() and use it when the_content has been replaced and the $post global has been unset.
[3601] johnjamesjacoby Revert part of r3600 and change logic. See #1678. (2.1)
[3497] johnjamesjacoby Revert part of r3487 and use post_parent for Akisment permalink parameter.
[3299] johnjamesjacoby Revert part of r3195. Fixes #1532. Props GautamGupta.
[2941] johnjamesjacoby Revert part of r2940 and instead use bbp_is_forum() to check if 'any' or bbp_get_forum_id() should be used in default post_parent in bbp_has_topics()
[2573] johnjamesjacoby Revert part of 2572.
[3085] johnjamesjacoby Revert most of r3054. $wp_query needs to be explicitly checked to guarantee we are not checking the $post global from a different internal loop. Change from post_meta based _bbp_visibility to custom forum post status for private and hidden forums. This allows for easier exclusion without the need for slower meta queries. Add wp_reset_postdata() through-out loop and template files where the post global might have been altered by an external plugin. Add bbp_exclude_forum_ids() function, to explicitly exclude forums based on user capabilities.
[2474] chrishajer Revert mistakenly changed db-version. Props !GautamGupta
[5360] johnjamesjacoby Revert indentation change in r5357. Props netweb. See: http://yaml.org/spec/1.2/spec.html#id2777534
[2748] johnjamesjacoby Revert extra voice-counts in single-bbp_topic.php that reappeared in r2746
[4129] johnjamesjacoby Revert debug cruft from r4128.
[4130] johnjamesjacoby Revert debug cruft from r4127.
[3615] johnjamesjacoby Revert cruft from bbp_get_forum_edit_template() from r3614.
[4475] johnjamesjacoby Revert clear removal on topic and reply lists. Force none in profiles. Fixes #1964 (trunk)
[4476] johnjamesjacoby Revert clear removal on topic and reply lists. Force none in profiles. Fixes #1964 (2.2 branch)
[3820] johnjamesjacoby Revert bbp-twentyten back to table based layout: * bbp-theme-compat retains tableless layout, and is canonical backup for missing template files * Avoid back-compat issues with installs that have modified bbPress 2.0 CSS * Fixes #1796
[4492] johnjamesjacoby Revert back to compact() in statistics.
[2605] johnjamesjacoby Revert accidentally deleted uninstall procedure from r2604
[4980] johnjamesjacoby Revert accidental test field change from r4979. See #1999.
[5061] johnjamesjacoby Revert accidental removal of threaded replies dropdown pre-option disabled check from r5060.
[5602] johnjamesjacoby Revert accidental line-change from r5601, #2747.
[5063] johnjamesjacoby Revert accidental change to forum query 'orderby' args from r5060.
[5062] johnjamesjacoby Revert accidental change to bbp_remove_roles() from r5060.
[2855] mdawaffe Revert a piece of [2800]. bbPress (unlike WordPress), uses term taxonomy IDs as tag IDs instead of term IDs. I cannot reproduce the reported destroy tag bug, but I would not be surprised if there are still some bugs around this term taxonomy ID v. term ID mess. See #1353
[4780] johnjamesjacoby Revert WordPress 3.6 slash-compat. See r4771, #WP21767.
[3206] johnjamesjacoby Revert 3139. Move .pot file back into bbp-languages folder for improved GlotPress integration. Props vanillalounge, westi.
[2761] johnjamesjacoby Revert r2759 and correct path in r2755. Props westi
[3470] johnjamesjacoby Reverse the admin.css and admin-2.css relative image depth.
[2533] johnjamesjacoby Reverse tabindexes on login form for rememberme and submit.
[4736] johnjamesjacoby Reverse single/double quote usage in bbp_mention_filter(); also use sprintf() to place variable data. See #2185.
[3700] johnjamesjacoby Return passed value if not applicable in bbp_admin_custom_menu_order()
[6936] johnjamesjacoby Retro TV styling for contributor avatars. 📺
[3532] johnjamesjacoby Retagging 1.1 (See r3529)
[3535] johnjamesjacoby Retagging 0.9.0.7 (See r3435)
[5617] netweb Restore PHP 5.2 to Travis CI * Travis restored PHP 5.2 support late last week. Fixes #2753
Note: See TracReports for help on using and creating reports.