Skip to:
Content

bbPress.org

{33} Commit Messages, Current Release (4934 matches)

Report designed to help manage the list of contributors.

Note: If you'd like a RSS feed of the changesets a they happen, Please use the timeline rss feed instead.

Results (901 - 1000 of 4934)

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
Changeset Author Message
[7175] johnjamesjacoby Theme Compatibility: improve handling of shortcodes in some template functions. This commit swaps out `is_page() || is_single()` for `is_singular()` which is easier to understand, and also raises the priority of that conditional check inside `bbp_get_topics_pagination_base()`, allowing it to work as intended inside of topic views and tags shortcode usages. In trunk for 2.7.0. See #3358.
[7176] johnjamesjacoby Theme Compatibility: improve handling of shortcodes in some template functions. This commit swaps out `is_page() || is_single()` for `is_singular()` which is easier to understand, and also raises the priority of that conditional check inside `bbp_get_topics_pagination_base()`, allowing it to work as intended inside of topic views and tags shortcode usages. In branches/2.6 for 2.6.7. Fixes #3358.
[6112] netweb Theme Compatibility: Parameter `$in_footer` in `bbp_enqueue_script()` should be boolean. This changeset updates copy-pasta introduced in [5181], `bbp_enqueue_script()` is a wrapper for `wp_enqueue_script()`, `$in_footer` boolean parameter introduced in wp:changeset:10367. Whether on purpose, or inadvertently, our scripts where being added in the footer, this commit explicitly maintains this behavior. Props thebrandonallen. Fixes #3013.
[7363] johnjamesjacoby Theme Compatibility: Make sure topic archive titles use the WordPress Page title, if one exists. This commit modifies `bbp_template_include_theme_compat()` to use the existing `$new_title` variable logic instead of the hard-coded Topic Archive title, allowing for the Page title to take its place. Props rollybueno. In trunk, for 2.7. Fixes #3604.
[7099] johnjamesjacoby Theme Compatibility: Avoid compatibility issues between MySQL versions. This commit introduces a new function - `bbp_get_empty_datetime()` - which returns a valid, filterable, "empty" MySQL formatted datetime value. This new function is used inside the theme compatibility API to ensure that global `WP_Post` datetime values are not "0" to better support MySQL 8 and higher, which is dropping support for `NO_ZERO_DATES`. Props GDragoN. In trunk, for 2.7.0. See #3354.
[7100] johnjamesjacoby Theme Compatibility: Avoid compatibility issues between MySQL versions. This commit introduces a new function - `bbp_get_empty_datetime()` - which returns a valid, filterable, "empty" MySQL formatted datetime value. This new function is used inside the theme compatibility API to ensure that global `WP_Post` datetime values are not "0" to better support MySQL 8 and higher, which is dropping support for `NO_ZERO_DATES`. Props GDragoN. In branches/2.6, for 2.6.6. Fixes #3354.
[5950] netweb Theme Compatibility: Add support for `singular.php` in the root template hierarchy. This changeset adds upport for the `singular.php` fallback template introduced in [WP22314] Props mercime Fixes #2868
[4762] johnjamesjacoby Theme Compatibility: * When locating template files, filter 'bbp_get_template_stack' rather than 'bbp_get_template_part' * Fixes bug where using bbp_locate_template() directly would result in missing subdirectory locations.
[3972] johnjamesjacoby Theme Compatibility: * Update lead-topic footer text to match header text.
[3970] johnjamesjacoby Theme Compatibility: * Uncomment post_author for forum edits in bbp_template_include_theme_compat().
[3925] johnjamesjacoby Theme Compatibility: * Skip extra enqueue_scripts logic for multiple _is_ checks. * Clean up get_current_theme() check. * See #1832.
[3984] johnjamesjacoby Theme Compatibility: * Revert bbp_get_query_template() logic introduced in r3971. * See: #1854.
[3923] johnjamesjacoby Theme Compatibility: * Only run bbp_template_include_theme_compat() on main loop.
[3983] johnjamesjacoby Theme Compatibility: * Move root-level templates into an /extras folder in bbp-theme-compat. * Revert extra logic introduced in r3971. * Theme compat can still allow for theme packs with root template files this way. * Replace reverted logic with 1 variable check, if a bbPress template file was found in the loader process. * See: #1854
[3969] johnjamesjacoby Theme Compatibility: * Invert bbp_is_theme_compat_original_template() check in bbp_template_include_theme_compat(). * Fixes issue with root template files being skipped over. * Fixes #1854.
[3927] johnjamesjacoby Theme Compatibility: * Introduce bbp_is_theme_compat_original_template() and bbp_set_theme_compat_original_template() functions, to allow the template loader to properly use custom post type templates. * Refactor BBP_Theme_Compat to use magic methods. * Reorder bbp_template_include_theme_supports() to put _edit() checks before single/archive checks, to prevent them from being stomped. * Clean up BBP_Theme_Compat usage to work with refactored approach. * Fixes #1833.
[3924] johnjamesjacoby Theme Compatibility: * Improvements to head script and RTL/LTR css enqueuing. * Backwards compat for get_current_theme(). * Fixes #1832.
[3942] johnjamesjacoby Theme Compatibility: * Fix issues with 'the_content' and bbp_replace_the_content() causing infinite loops, duplicate filters, no filters, etc... * Add 'the_content' adds/removes to BBP_Shortcode where needed. * Remove unneeded calls to do_shortcode(). * Fixes #1844.
[3928] johnjamesjacoby Theme Compatibility: * Clean up bbpress-functions.php for Twenty Ten and Default theme packages. * Simplify bbp_register_theme_package() to accept an array or a BBP_Theme_Compat object. * Update bbPress::register_theme_packages() to use new style above.
[3971] johnjamesjacoby Theme Compatibility: * Allow root level templates to bypass the_content overriding if child/parent templates are found. * Introduces two functions and new theme_compat functionality, that modifies bbp_get_query_template() to tell bbp_locate_template() to not override the_content. * Reverts r3969. * Fixes #1854 correctly.
[3943] johnjamesjacoby Theme Compatibility: * Add support for plugin-bbpress.php and generic.php in the root template hierarchy. * See: http://core.trac.wordpress.org/ticket/20509
[3985] johnjamesjacoby Theme Compatibility: * Add feedback template part for when there are no replies in the specific view.
[4975] johnjamesjacoby Theme Compatibility improvements: * Introduce helper functions to set and check a located root template, to aid in turning off theme-compat. * Introduce bbp_do_theme_compat() which checks if we're in the main loop, and the $post global has been primed with theme-compat dummy data. * Use WP_Post in bbp_theme_compat_reset_post(), and clean up this function a bit. * Set theme_compat active to false after bbp_replace_the_content() has started, to avoid recursing through nested 'the_content' filter usages. * Refactor output buffering used in bbp_replace_the_content() to clean up shortcode usages. * See #2343.
[3634] johnjamesjacoby Theme Compatibility Updates: * Tableless layout, fixes #1586, props mercime * Introduce content-single-reply and content-topic-tag-edit templates * Update shortcodes to use content templates * Update theme compatibility to include single reply shortcode * @todo CSS audit, RTL audit, shortcode audit
[6952] johnjamesjacoby Theme Compat: resolve a number of issues brought up after 2.6 was released. This commit does the following: * Sets min and max heights on img.avatar elements to avoid them being super huge in Twenty Twenty * Restores text-underline styling for topic & reply content for Twenty Seventeen * Removes text-underline for revisions * Fixes padding & margins on small screens across all themes See #3281. For 2.7, trunk.
[6951] johnjamesjacoby Theme Compat: resolve a number of issues brought up after 2.6 was released. This commit does the following: * Sets min and max heights on img.avatar elements to avoid them being super huge in Twenty Twenty * Restores text-underline styling for topic & reply content for Twenty Seventeen * Removes text-underline for revisions * Fixes padding & margins on small screens across all themes See #3281. For 2.6.1, branches/2.6.
[7329] johnjamesjacoby Theme Compat: remove reference to non-existent function. This change removes a function call to `display_reply_index()` which does not exist, and replaces it with an empty string. This condition will not fire under normal circumstances as the Reply post type does not support archives by default. The chances of this fatal error happening are near zero, but we can easily avoid it fully by returning an empty string instead. Props sirlouen. In trunk, for 2.7. Fixes #3616.
[7328] johnjamesjacoby Theme Compat: remove reference to non-existent function. This change removes a function call to `display_reply_index()` which does not exist, and replaces it with an empty string. This condition will not fire under normal circumstances as the Reply post type does not support archives by default. The chances of this fatal error happening are near zero, but we can easily avoid it fully by returning an empty string instead. Props sirlouen. In branches/2.6, for 2.6.14. Fixes #3616.
[7167] johnjamesjacoby Theme Compat: pass `$page->ID` into `the_title` filter inside `bbp_template_include_theme_compat()`. This commit fixes potential PHP notices and third-party plugin compatibility issues (specifically with MemberPress, but could be anything really) and ensures that the `the_title` filter parameters match what WordPress itself includes. In trunk for 2.7.0. See #3415. Props lyndseyh.
[7168] johnjamesjacoby Theme Compat: pass `$page->ID` into `the_title` filter inside `bbp_template_include_theme_compat()`. This commit fixes potential PHP notices and third-party plugin compatibility issues (specifically with MemberPress, but could be anything really) and ensures that the `the_title` filter parameters match what WordPress itself includes. In branches/2.6 for 2.6.6. Fixes #3415. Props lyndseyh.
[6987] johnjamesjacoby Theme Compat: more styling tweaks to default theme. This commit adds more aggressive targeting to UL elements within the main `bbpress-forums` wrapper element, to ensure that themes choosing to also style unordered lists do not add margins & paddings to these default wrappers. It also forces all default styling fonts to `sans-serif`, regardless of the parent theme. Serif fonts were never meant to be inherited, usually are difficult to read in small sizes, and many themes use broad styling for serifs that conflict with bbPress default styling elements. Includes a few responsive improvements for smaller screens where author information gets displayed vertically. For 2.6.3, branches/2.6.
[6986] johnjamesjacoby Theme Compat: more styling tweaks to default theme. This commit adds more aggressive targeting to UL elements within the main `bbpress-forums` wrapper element, to ensure that themes choosing to also style unordered lists do not add margins & paddings to these default wrappers. It also forces all default styling fonts to `sans-serif`, regardless of the parent theme. Serif fonts were never meant to be inherited, usually are difficult to read in small sizes, and many themes use broad styling for serifs that conflict with bbPress default styling elements. Includes a few responsive improvements for smaller screens where author information gets displayed vertically.
[6862] johnjamesjacoby Theme Compat: introduce `bbp_locate_enqueueable()` and `bbp_urlize_enqueueable()`. These functions are used to help make locating enqueueable assets easier, and use `bbp_locate_template()` interntally, now accepting an array of files. In addition, `bbp_locate_enqueueable()` also internally juggles minimized file variations, and stacks them according to the `SCRIPT_DEBUG` constant. This ensures that both minimized and unminimized file variants are in the array in the preferred order. This fixes a regression between bbPress 2.5 and 2.6 caused by the bundling of minimized assets in theme compatibility, and ensures that sites with their own `bbpress.css` files in their own locations will continue to get loaded, regardless of the `SCRIPT_DEBUG` setting. Fixes #3218.
[7231] johnjamesjacoby Theme Compat: improve "no-js" body class swapping. This change introduces a new helper function (`bbp_swap_no_js_body_class()`) which is used to output the `<script>` tag that was previously inside of the single template part that needed it. It also adds a prefix (`bbp`) to those "no-js" body classes, with the intention of avoiding conflicts with other plugins & themes that may also be using the `no-js` body class for their own purposes. Props dd32, r-a-y. In trunk for 2.7.0. Fixes #3445.
[7230] johnjamesjacoby Theme Compat: improve "no-js" body class swapping. This change introduces a new helper function (`bbp_swap_no_js_body_class()`) which is used to output the `<script>` tag that was previously inside of the single template part that needed it. It also adds a prefix (`bbp`) to those "no-js" body classes, with the intention of avoiding conflicts with other plugins & themes that may also be using the `no-js` body class for their own purposes. Props dd32, r-a-y. In branches/2.6 for 2.6.10. Fixes #3445.
[7073] johnjamesjacoby Theme Compat: conditionally unhook adjacent posts. This commit adds a new function that is used to conditionally unhook a WordPress core action, and is necessary to prevent debug notices from adjacent posts and Theme Compatibility making `post_date` a `0` value. Props r-a-y. For 2.6.15, branches/2.6.
[7072] johnjamesjacoby Theme Compat: conditionally unhook adjacent posts. This commit adds a new function that is used to conditionally unhook a WordPress core action, and is necessary to prevent debug notices from adjacent posts and Theme Compatibility making `post_date` a `0` value. Props r-a-y. For 2.6.15, branches/2.6.
[6295] netweb Theme Compat: Use tabs not spaces for indentation in `BBP_Theme_Compat`
[6549] johnjamesjacoby Theme Compat: Update `bbp_get_query_template()` to work a bit more simply. This change removes using the returned results from the stash functions, and uses the local variables instead.
[6119] johnjamesjacoby Theme Compat: Support `WP_Hook` class in 2.5 branch. See #2871, r5945.
[6314] johnjamesjacoby Theme Compat: Revert part of r5470, causing user profiles to output comment sections. Fixes #3050. See #2545.
[7000] johnjamesjacoby Theme Compat: Revert `sans-serif` override from r6987. This commit fixes a regression causing theme styling to to be applied, while also overriding some styling that was intentional.
[7001] johnjamesjacoby Theme Compat: Revert `sans-serif` override from r6986. This commit fixes a regression causing theme styling to to be applied, while also overriding some styling that was intentional.
[6963] netweb Theme Compat: Remove duplicate `border-radius` added in [6952] See #3281. For 2.7, trunk.
[6253] johnjamesjacoby Theme Compat: Improved Twenty Seventeen support: * Add supplemental `bbpress-wrapper` class to `#bbpress-forums` div elements * Remove box-shadow styling form bbPress's `entry-content` section links * Provides middle-of-the-road targeting of bbPress template content, for complex styling relationships where ID's may be too powerful and classes may not have existed previously
[6551] johnjamesjacoby Theme Compat: Improve loading & support for external template packs. * Better error handling if tempate pack is broken, unloaded, or missing * Consolidate favs & subs code to use the same central handlers, by passing an `object_id` and `object_type` around (for future support of term subscriptions) * Rename data addtributes from previous BuddyPress favs & subs fixes * Adjust load order of template pack setup so that it's as late as possible, allowing template pack authors more time to get registered * Automatically add the current template pack to the template stack (multiple packs can still be layered, and this improves support for that) * Merge `topic.js` and `forum.js` in "bbPress Default" template pack to use the same `engagements.js` script, which simplifies localization & uses 1 less script between pages This change puts the finishing touches on favs & subs consolidation for 2.6, and updates several related & surrounding functions to better support the necessary mark-up changes.
[6956] johnjamesjacoby Theme Compat: Fix CSS overlapping border-radius from r6951. Also bump package-lock.json.
[6998] johnjamesjacoby Theme Compat: Don't override elements that are explicitly using `.dashicons`. This commit prevents styling conflicts with third party plugins that are using Dashicons in elements. See r6987.
[6999] johnjamesjacoby Theme Compat: Don't override elements that are explicitly using `.dashicons`. This commit prevents styling conflicts with third party plugins that are using Dashicons in elements. See r6986.
[6996] johnjamesjacoby Theme Compat: Add back original `ul` styling. This commit fixes an unintentional styling change. The original rule should not have been removed. See r6987.
[6997] johnjamesjacoby Theme Compat: Add back original `ul` styling. This commit fixes an unintentional styling change. The original rule should not have been removed. See r6986.
[6288] johnjamesjacoby Theme Compat: Add `is_` parameters to various query-reset procedures. This ensures the state of the `wp_query` global is what someone can safely expect for it to be. It also is used through-out WordPress as a way to auto-assign body classes and various other environmental tweaks. Fixes #3055. Props sergeybiryukov.
[4088] johnjamesjacoby Theme Compat: * phpdoc improvements. * Fixes #1899 (2.2 branch). * Props jaredatch.
[4087] johnjamesjacoby Theme Compat: * phpdoc improvements. * Fixes #1899 (2.1 branch). * Props jaredatch.
[4220] johnjamesjacoby Theme Compat: * Use theme directory functions instead of constants in bbp_locate_template(). * Fixes #1950. * Props mordauk.
[3968] johnjamesjacoby Theme Compat: * Trim off left-slash from template name to prevent duplicate slashes.
[4377] johnjamesjacoby Theme Compat: * Set post_excerpt when setting the dummy post. * Fixes issue with unset $post->post_excerpt warnings. * For 2.1 branch.
[4376] johnjamesjacoby Theme Compat: * Set post_excerpt when setting the dummy post. * Fixes issue with unset $post->post_excerpt warnings.
[4326] johnjamesjacoby Theme Compat: * Reverse the look-up of bbp_locate_template() and check $template_names first. * When a template is located, break out of both loops. * See #1968.
[4123] johnjamesjacoby Theme Compat: * Reset reply height to auto, to prevent conflicts with some themes. * Fixes #1819. * For 2.2 branch. * Props jaredatch.
[4122] johnjamesjacoby Theme Compat: * Reset reply height to auto, to prevent conflicts with some themes. * Fixes #1819. * For 2.1 branch. * Props jaredatch.
[4328] johnjamesjacoby Theme Compat: * Remove single- fallback from forum/topic/reply/topic-tag edit templates. * See #1968.
[4146] johnjamesjacoby Theme Compat: * Remove list styling from all list items * It is put back later in the stack. * For 2.2 branch
[4145] johnjamesjacoby Theme Compat: * Remove list styling from all list items * It is put back later in the stack. * For 2.1 branch
[4535] johnjamesjacoby Theme Compat: * Remove is_main_query() usage in bbp_replace_the_content(). * Fixes some themes misbehaving with theme-compat, causing it not to work as intended. * For 2.2 branch.
[4534] johnjamesjacoby Theme Compat: * Remove is_main_query() usage in bbp_replace_the_content(). * Fixes some themes misbehaving with theme-compat, causing it not to work as intended. * /me shakes fist at query_posts().
[4152] johnjamesjacoby Theme Compat: * Remove $post/$withcomments global noop, replace with wp_reset_postdata(). * Fixes issues with debug notices in some themes. * For 2.2 branch. * See r4150.
[4151] johnjamesjacoby Theme Compat: * Rearrange content injection to improve readability. * Includes additional post reset information for single f/t/r's. * Remove $post/$withcomments global noop, replace with wp_reset_postdata(). * Fixes issues with debug notices in some themes. * For 2.1 branch. * See r4148.
[4148] johnjamesjacoby Theme Compat: * Rearrange content injection to improve readability. * Includes additional post reset information for single f/t/r's.
[4144] johnjamesjacoby Theme Compat: * RTL improvements. * See #1897. * For 2.2 branch.
[4269] johnjamesjacoby Theme Compat: * Prefix the bbp-default container and content div ID's with 'bbp-'
[4257] johnjamesjacoby Theme Compat: * Pass integer into status_header() instead of string. * See #1973.
[4411] johnjamesjacoby Theme Compat: * Only replace the content if in a main query loop. * Fixes possible incompatibilities with alternate loops and calling 'the_content' filters in strange places. * For 2.2.
[4327] johnjamesjacoby Theme Compat: * Only iterate through bbp_get_template_stack() one time per call to bbp_locate_template(). * See #1968.
[4324] johnjamesjacoby Theme Compat: * Introduce bbp_get_template_stack() and bbp_register_template_stack(). * Used to provide an accurate hierarchy to individual template locations. * Also enables an unlimited number of parent/child template relationships to be registered. * See #1968.
[4106] johnjamesjacoby Theme Compat: * Fix logic on theme compat override. * Props DJPaul. * Fixes #1912. * For 2.2 branch.
[4107] johnjamesjacoby Theme Compat: * Fix logic on theme compat override. * Props DJPaul. * Fixes #1912. * For 2.1 branch.
[3892] johnjamesjacoby Theme Compat: * Fix form class on last password template part. * Tweak form/widget styling to be more consistent.
[4437] johnjamesjacoby Theme Compat: * Fix bug causing first iteration of theme stack to be skipped.
[4231] johnjamesjacoby Theme Compat: * Do not set script charset, since we are sot setting a src. * Fixes #1959. * Props plescheff.
[4155] johnjamesjacoby Theme Compat: * Defaults and dummy data for entire single-post schema.
[4142] johnjamesjacoby Theme Compat: * Additional CSS to prevent gaps in list items. * Fixes #1926. * See #1897. * For 2.2. * Props mamaduka.
[4143] johnjamesjacoby Theme Compat: * Additional CSS to prevent gaps in list items. * Fixes #1926. * See #1897. * For 2.1 branch. * Props mamaduka.
[4264] johnjamesjacoby Theme Compat: * Add 'bbp_add_template_locations' filter to 'bbp_locate_template' filter. * Add array_unique() to bbp_add_template_locations() to remove possible duplicates.
[3906] johnjamesjacoby Theme Actions: * Swap incorrect before/after actions in topic-lead and loop-single-reply templates. * Props sorich87. * Fixes #1825.
[4109] johnjamesjacoby Theme Actions: * Add back 'bbp_template_before_single_forum' action. * Fixes #1909. * For 2.2 branch.
[4108] johnjamesjacoby Theme Actions: * Add back 'bbp_template_before_single_forum' action. * Fixes #1909. * For 2.1 branch.
[3213] johnjamesjacoby The root forum no longer requires a WordPress page - the archive-forum.php template file will take care of this going forward.
[6846] johnjamesjacoby Tests: use correct post type and factory in `test_bbp_clean_post_cache()`.
[6801] johnjamesjacoby Tests: update default text to match what's new for 2.6.0.
[6436] johnjamesjacoby Tests: update `test_bbp_get_topic_last_reply_permalink()` to use `bbp_get_forum_last_topic_permalink()`.
[6847] johnjamesjacoby Tests: unset meta data from `$args` in factories. This just keeps the arrays a bit more clean, and makes it clear these keys are not used.
[6849] johnjamesjacoby Tests: revert accidental test group change from r6848. (I need unit tests probably more than most, but this is neither the time nor the place for that.)
[6802] johnjamesjacoby Tests: remove slashes from unpretty URLs before `#` anchor links.
[6848] johnjamesjacoby Tests: get all post type/status counts using `bbp_get_child_counts()`. * Fix a broken test, and improve a few others * Update several `count()` instances that were doing expensive `_ids()` counts * Strategically bust the `bbpress_posts` query cache group on updates This change improves general performance and count reliability by ensuring the accuracy of forum/topic/reply relationship totals.
[5863] netweb Tests: When creating posts that use date/time assertions use a concise post date/time. This changeset prevents the related unit test from incorrectly failing by ensuring that no content is created 1 second after any other.
[5879] netweb Tests: Various topic template tests for `BBP_Tests_Topics_Template_Topic`
[5875] netweb Tests: Various reply template tests for `BBP_Tests_Replies_Template_Reply`
[5874] netweb Tests: Various forum template tests for `BBP_Tests_Forums_Template_Forum_Last_Thing`
[5928] netweb Tests: User subscription and user favorites tests in `BBP_Tests_Users_Functions_Subscriptions` and `BBP_Tests_Users_Functions_Favorites` Props thebrandonallen. Fixes #2855.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
Note: See TracReports for help on using and creating reports.