| [5956]
|
netweb
|
Shortcodes: Remove superfluous `@param` PHPDoc instances from various shortcode functions
Props casiepa.
|
| [5955]
|
netweb
|
Tests: Fix failing `BBP_Tests_Topics_Functions_Update_Topic_Last_Thing` tests
* Pass the active id as the 2nd parameter to `bbp_update_topic_last_active_id()` in `test_bbp_update_topic_last_active_id()`
* Pass the reply id as the 2nd parameter to `bbp_update_topic_last_reply_id()` in `test_bbp_update_topic_last_reply_id()`
This fixes the current two failing unit tests by passing what should be optional paremeters to their respceptive functions.
See #1799, [5954]
|
| [5954]
|
netweb
|
Performance: Replace direct SQL queries with `WP_Query()` objects in the following functions:
* `bbp_update_forum_topic_count()`
* `bbp_update_forum_topic_count_hidden()`
* `bbp_update_forum_reply_count()`
* `bbp_get_public_child_last_id()`
* `bbp_get_public_child_count()`
* `bbp_get_public_child_ids()`
Props johnjamesjacoby.
See #1799.
|
| [5953]
|
netweb
|
Tests: More tests for the common component query functions:
* `test_bbp_query_post_parent__in()` for `bbp_query_post_parent__in()`
* `test_bbp_get_public_child_last_id()` for `bbp_get_public_child_last_id()`
See #1799
|
| [5952]
|
netweb
|
Credits: Update H4 to H3
This changeset improves accessibility and brings bbPress' credits area headers up to par with WordPress 4.4.
Fixes #2890. See #WP34263.
|
| [5951]
|
netweb
|
Standardize `@since` PHPDoc tags style and format
* e.g. `@since 2.6.0 bbPress (r5951) YOLO`
* See http://phpdoc.org/docs/latest/references/phpdoc/tags/since.html
This changeset updates the style and formatting of all of our `@since` instances for compatibility with phpDocumentor 2 and WP-Parser as we move toward implementing the bbPress developer code reference.
Props thebrandonallen
Fixes #2879
|
| [5950]
|
netweb
|
Theme Compatibility: Add support for `singular.php` in the root template hierarchy.
This changeset adds upport for the `singular.php` fallback template introduced in [WP22314]
Props mercime
Fixes #2868
|
| [5949]
|
netweb
|
Users: In `BBP_Default::enqueue_scripts` remove rogue script dependency for single user edits
This changeset removes the `user-query` dependency that was accidentally introduced in r5183
Props tharsheblows
Fixes #2877
|
| [5948]
|
netweb
|
Accessibility: Include input labels for field titles in bbPress settings
This changeset aligns bbPress input label fields with current WordPress standard for improved accessibility
Props ankit-k-gupta, thebrandonallen
Fixes #2866
|
| [5947]
|
netweb
|
Tests: Updated bbPress PHPUnit test suite compatibility with upstream WordPress changes.
* [WP34802], [WP34803], [WP34807], and [WP34810] introduced `set_permalink_structure`, it's implementation broke bbPress',
* [WP35244] `WP_UnitTest_Generator_Sequence` needs a static incrementer - otherwise, it assumes every test class is a reset, which it no longer is (it is now static), updated bbPress unit tests where explicitly set content and titles are required.
Props thebrandonallen. Fixes #2883
|
| [5946]
|
netweb
|
Users: Update `$_SERVER['REMOTE_ADDR']` IP adress check to `127.0.0.1` in `bbp_current_author_ip()`
This changeset updates our unit tests and ensures compatability with WordPress test suite where in [WP34172] `$_SERVER[ 'REMOTE_ADDR' ]` is now initialised during the test bootstrap so individual tests need not.
Props thebrandonallen. See #2883.
|
| [5945]
|
netweb
|
Core: Restore empty `$wp_filter[ $tag ]` check and update PHPDoc in `bbp_get_template_stack()`
See #2871
|
| [5944]
|
netweb
|
Core: Support for `WP_Hook` in `bbp_get_template_stack()`
The proposed `WP_Hook` #WP17817 breaks backward compatibility for plugins that
attempt to manipulate `$wp_filter` in certain ways. For bbPress, it means
that we cannot directly modify the callbacks that are currently registered as
an array at `$wp_filter[ $tag ]`, in `bbp_get_template_stack()`. Instead, when
`WP_Hook` is not available, we assign the callbacks to a variable (leveraging
`WP_Hook`'s `ArrayAccess`) and manipulate the variable.
Props jbrinley. Fixes #2871
|
| [5943]
|
netweb
|
Tests: Temorarily remove `fast_finish: true` from Travis CI configuration for now.
Upstream: https://github.com/travis-ci/travis-ci/issues/4928
See also: https://core.trac.wordpress.org/changeset/35150
|
| [5942]
|
netweb
|
Tests: Include WordPress 4.3 in Travis CI test matrix
|
| [5941]
|
netweb
|
Tests: Use `assertEqualSets()` in:
* `BBP_Tests_Forums_Functions_Query::test_bbp_forum_query_topic_ids`
* `BBP_Tests_Forums_Functions_Query::test_bbp_forum_query_subforum_ids`
This changeset improves array comparisons where that arrays may not be in the same order.
Props thebrandonallen. See #2883
|
| [5940]
|
netweb
|
i18n: Merge similar translation strings
This changset brings consistency to failed warning strings in our repair tools and removes extra whitespace in two strings. This reduces the number of strings that our translation volunteers need to translate.
Props ramiy. Fixes #2880
|
| [5939]
|
netweb
|
Update `readme.txt` installation steps with correctly formatted markdown. (2.5 branch)
This changeset fixes an issue where incorrectly formatted markdown list items would not display as expected in the w.org plugin readme.
Props ramiy. See #2884
|
| [5938]
|
netweb
|
Update `readme.txt` installation steps with correctly formatted markdown. (trunk)
This changeset fixes an issue where incorrectly formatted markdown list items would not display as expected in the w.org plugin readme.
Props ramiy. See #2884
|
| [5937]
|
netweb
|
Bump tested-up-to version to 4.3. (2.5 branch)
|
| [5936]
|
netweb
|
Bump tested-up-to version to 4.3. (trunk)
|
| [5934]
|
netweb
|
Tests: Fix incorrect assertion type in `test_bbp_forum_query_topic_ids()` and `test_bbp_forum_query_subforum_ids()`, also now includes topic meta for topics in `test_bbp_forum_query_topic_ids()()`
|
| [5931]
|
netweb
|
Tests: Add topic and topic reply spam/unspam tests `test_bbp_spam_topic()`, `test_bbp_spam_topic_replies()`, `test_bbp_unspam_topic()`, and `test_bbp_unspam_topic_replies()`
Props netweb. See #2494.
|
| [5929]
|
netweb
|
Tests: Fix incorrect reply post date time assertion in `test_bbp_get_topic_last_active_time()`
|
| [5928]
|
netweb
|
Tests: User subscription and user favorites tests in `BBP_Tests_Users_Functions_Subscriptions` and `BBP_Tests_Users_Functions_Favorites`
Props thebrandonallen. Fixes #2855.
|
| [5927]
|
netweb
|
Build Tools: Update `grunt-contrib-uglify` to `v0.9.2`
This changeset includes an update to the parent dependency UglifyJS v2.4.24 which fixes a bug that can cause logic bugs to be introduced into minified JS.
Hat-tip pento. Fixes #2856.
|
| [5925]
|
netweb
|
Tests: Ensure bbPress' custom post types posts are created with a unique GUID.
Props tharsheblows, netweb. Fixes #2844, see also #WP5305 / wp:changeset:33630.
|
| [5924]
|
netweb
|
Replies: Improve type-casting in `bbp_update_reply_topic_id()` missed in r5737
Props thebrandonallen. See #2801.
|
| [5923]
|
netweb
|
Forums: Improve type-casting in forum functions.
Props thebrandonallen. See #2801.
|
| [5922]
|
netweb
|
Tests: Remove erroneous `bbp_clean_post_cache()` from `test_bbp_topic_new_reply_counts()` test
|
| [5921]
|
netweb
|
Tests: Introduce generic tests to test forum counts with various new, spam, trash, and approve topic actions
Props thebrandonallen. See #2801.
|
| [5920]
|
netweb
|
Tests: Introduce generic tests to test topic counts with various new, spam, trash, delete, and approve reply actions
Props thebrandonallen. See #2801.
|
| [5919]
|
netweb
|
Tests: Use multiple replies in test `test_bbp_get_user_replies_created()`, this was accidently introcuced in r5890
|
| [5918]
|
netweb
|
Forums: Updated PHPDocs and unit tests for `bbp_update_forum_last_*()` functions.
Props thebrandonallen. Fixes #2811
|
| [5917]
|
netweb
|
Topics: Return `string` in `bbp_update_forum_last_active_time()`
Includes updated PHPdocs and unit tests for `bbp_update_topic_last_*()` functions.
Props thebrandonallen. See #2811
|
| [5916]
|
netweb
|
Tools: Include pending replies in the count when running the "Count pending, spammed, & trashed replies in each topic" repair tool
This changeset ensures that pending replies are included in the topic meta `_bbp_reply_count_hidden` count after running the repair tool `bbp_admin_repair_topic_hidden_reply_count()`, includes unit tests.
Props netweb. Fixes #2849
|
| [5915]
|
netweb
|
Tests: Add `test_bbp_delete_topic_replies()` topics function test
|
| [5914]
|
netweb
|
Tests: Don't use hardcoded `example.org` domain is test assertions.
This changeset allows the default domain used in tests to be overridden using `WP_TESTS_DOMAIN` in `wp-tests-config.php`
|
| [5913]
|
netweb
|
Tools: Update `grunt-contrib-cssmin` to v0.13.0
Changelog: https://github.com/gruntjs/grunt-contrib-cssmin/compare/v0.11.0...v0.13.0
Testing `grunt cssmin` and related bbPress Grunt tasks show no issues with `grunt-contrib-cssmin`
Note: Requires `npm install` to update dependencies
See #2738
|
| [5912]
|
netweb
|
Tools: Remove banners added to minified CSS files and simplified JS banner
This changeset removes the banners that were previously added to minified CSS files as `grunt-contrib-cssmin` deprecated this in v0.11.0.
The banner added to minified JS files has also been simplified by removing the time/date so that unnecessarily merges/updates do not trigger unneeded changes when using version control. The banner added to minified JS files is now static without the date/time, this fixes an issue where the minified file would always change because of the compiled date/time even when there were no code changes, this was causing unneeded changes when merging/updating when using version control external to bbPress.
Props netweb. Fixes #2738
|
| [5911]
|
netweb
|
Tools: RTL CSS generation: Switch from CSSJanus to RTLCSS
* If you have used `grunt cssjanus` before, use `grunt rtlcss` now.
* Requires `npm install` to update dependancies
Props netweb. Fixes #2848, see #WP31332 and wp:changeset:31573
|
| [5910]
|
netweb
|
Tests: Restore original testcase $_SERVER during teardown in `BBP_Tests_Core_Functions_BBPVerifyNonceRequest::during tearDown()`
|
| [5898]
|
netweb
|
Tests: Skeleton test placeholders for core abstraction function wrappers
|
| [5897]
|
netweb
|
Tests: Initial unit tests for /includes/users/template.php
Props netweb. See #2831
|
| [5896]
|
netweb
|
Tests: If we add filters in tests, we need to also remove them for WordPress < 4.0 compatability
Props thebrandonallen. See #2845
|
| [5895]
|
netweb
|
Tests: Update PHPUnit bootstrap instructions for executing bbPress' BuddyPress tests
Props thebrandonallen. Fixes #2846
|
| [5894]
|
netweb
|
Replies: Clarify inline doc surrounding `bbp_show_lead_topic()` in `bbp_get_reply_position()`
This changest clarify's the docs on how `bbp_show_lead_topic()` affects a reply's menu order in a topics reply loop and determining the correct pagination of reply URL's.
Includes unit tests for `bbp_reply_position()` and `bbp_get_reply_url()`
Fixes #2845
|
| [5893]
|
netweb
|
Topics: Fix incorrect PHPDoc references to `bbp_show_lead_topic()` in `bbp_display_topics_feed_rss2()` and `bbp_display_replies_feed_rss2()`
|
| [5891]
|
netweb
|
Replies: Remove previous `menu_order` default from `bbp_insert_reply()` missed in r5889
Antiprops netweb. See #2843.
|
| [5890]
|
netweb
|
Tests: Update tests to always include a parent topic for replies
This changeset ensures replies always have a parent topic which in turn ensures each reply is created with an accurate `menu_order` position.
Fixes #2843
|
| [5889]
|
netweb
|
Replies: Include replies menu order when creating replies with `bbp_insert_reply()` improving reply unit tests
See #2843
|
| [5888]
|
netweb
|
Bumps: Normalize type-casting in `bbp_bump_user_reply_count()` missed in r5732
See #2801
|
| [5887]
|
netweb
|
Tests: Skeleton test placeholders for user options functions
|
| [5883]
|
netweb
|
Installation: When creating initial content, use different times for forum, topic, and reply post times.
This changeset builds on r5843 to allow improved tests in `test_bbp_create_initial_content()` of forum and topic last active times.
|
| [5882]
|
netweb
|
Updated `_admin.scss` via WP:changeset:33067, WP:changeset:33284, WP:changeset:33285, WP:changeset:33289, WP:changeset:33409, and WP:changeset:33453
See #2583
|
| [5881]
|
netweb
|
Tests: Remove debug fragment leftover in `test_bbp_get_topic_freshness_link()` missed in r5880
|
| [5880]
|
netweb
|
Replies: In `bbp_update_reply_walker()` always update the topics last active time with `bbp_update_topic_last_active_time()` regardless of reply's published status.
This changeset including unit tests ensures that when calling reply actions spam/unspam, trash/untrash, approve/unapprove the reply's parent topic's last active time is updated to the time of the last published reply.
Props netweb. See #2838
|
| [5879]
|
netweb
|
Tests: Various topic template tests for `BBP_Tests_Topics_Template_Topic`
|
| [5878]
|
netweb
|
Tests: Add `test_bbp_get_topic_favorite_link()` topic templates test
|
| [5877]
|
netweb
|
Tests: Add `test_bbp_approve_reply()` and `test_bbp_unapprove_reply()` reply functions tests
|
| [5876]
|
netweb
|
Tests: Revert incorectly formatted PHPUnit `@covers` doc blocks that slipped in via r5875
|
| [5875]
|
netweb
|
Tests: Various reply template tests for `BBP_Tests_Replies_Template_Reply`
|
| [5874]
|
netweb
|
Tests: Various forum template tests for `BBP_Tests_Forums_Template_Forum_Last_Thing`
|
| [5873]
|
netweb
|
Tests: Complete topic template tests in `BBP_Tests_Topics_Template_Get_Topic_Last_Thing`
|
| [5872]
|
netweb
|
Tests: Include `bbp_get_forum_last_reply_id()` assertions in `test_bbp_get_forum_and_topic_last_topic_id_and_last_reply_id()` missed in r5844
See #2806
|
| [5871]
|
netweb
|
Tests: Add forum last active id test `test_bbp_get_forum_last_active_id_with_pending_reply()`.
This test tests the forums last active id to ensure replies with post status `pending` are not used as the forums last active id until the reply is approved.
See #meta1140
|
| [5870]
|
netweb
|
Tests: Add topic voice count test `test_bbp_get_topic_voice_count_with_pending_reply()`.
This test tests the voice count of a topic to ensure replies with post status `pending` are not included in the voice count until approved.
See #meta1140
|
| [5869]
|
netweb
|
Travis-CI: Include WordPress v4.2 in test matrix
|
| [5865]
|
netweb
|
Tests: In `test_bbp_get_forum_freshness_link()` create posts using a concise post date/time.
This changeset prevents the related unit test from incorrectly failing by ensuring that no content is created 1 second after any other.
|
| [5864]
|
netweb
|
Travis-CI: Remove HHVM-Nightly, HHVM nightly packages for Ubuntu Precise have been discontinued.
|
| [5863]
|
netweb
|
Tests: When creating posts that use date/time assertions use a concise post date/time.
This changeset prevents the related unit test from incorrectly failing by ensuring that no content is created 1 second after any other.
|
| [5862]
|
netweb
|
Moderators: Add missing @since PHPDoc missed in `bbp_map_forum_mod_meta_caps()` via r5834
|
| [5861]
|
netweb
|
Tests: Remove unused test assertion `test_bbp_get_forum_last_reply_id()`
|
| [5831]
|
netweb
|
Tests: Add admin tools test `test_bbp_admin_repair_topic_voice_count()` for `bbp_admin_repair_topic_voice_count()`
Props netweb. See #2533
|
| [5830]
|
netweb
|
Bump tested-up-to version to 4.2. (trunk)
|
| [5819]
|
netweb
|
Include 2.5.8 in readme.txt changelog (for trunk) and bump stable tag
|
| [5818]
|
netweb
|
Create tag 2.5.8.
|
| [5817]
|
netweb
|
Update bbpress.pot in 2.5 branch.
|
| [5816]
|
netweb
|
Bump 2.5 branch to 2.5.8.
|
| [5812]
|
netweb
|
Tests: Tests for the common component common functions
Props netweb
|
| [5811]
|
netweb
|
Topics: Fix `bbp_get_topic_post_date()` default GMT date format copy pasta introduced in r4647, includes unit tests.
Props tobyhawkins. Fixes #2697
|
| [5810]
|
netweb
|
Admin: Updated Topic and Reply contextual help
Props robkk. Fixes #2824
|
| [5804]
|
netweb
|
Update Grunt dependencies in package.json:
* `grunt-checktextdomain` major version update (Improved task error handing)
* `grunt-contrib-jshint` patch version update
* `grunt-contrib-uglify` minor version update (causes some changes to minified JS)
* `grunt-sass` major version update ( underlying libsass update )
* `grunt-wp-i18n` patch version update
Fixes #2821
|
| [5803]
|
netweb
|
Updated admin base SCSS styles:
* `_admin.scss` via WP:changeset:31747, WP:changeset:31952, and WP:changeset:32075
* `_variables.scss` via WP:changeset:32051
See #2583
|
| [5801]
|
netweb
|
Tests: Update `test_bbp_create_initial_content()` to not use hard coded forum, topic and reply id's.
|
| [5800]
|
netweb
|
Importers: Updated AIM, YIM, and Jabber user meta key prefixes importer user profile fields for AEF, FluxBB, Kunena3, MyBB, PunBB, SMF, XMB, vBulletin and vBulletin3 importers
Props netweb. Fixes #2815
|
| [5799]
|
netweb
|
Example importer: Change AIM, YIM, and Jabber profile fields to generic examples with meta key prefixes
Props netweb. See #2815
|
| [5798]
|
netweb
|
phpBB Importer: Missed forum total topic and total reply count schema change
See #2716
|
| [5797]
|
netweb
|
phpBB importer: Updated AIM, YIM, and Jabber user meta key prefixes
Props netweb. See #2815
|
| [5796]
|
netweb
|
phpBB importer: Include Subscribed Forums, Subscribed Topics and Favourite Topics
Props netweb. See #2668
|
| [5795]
|
netweb
|
Importers: Update phpbB importer to support phpBB 3.1.x database schema changes
* Note: Importing from phpBB 3.0.x is no longer supported, please update to phpBB 3.1.x before importing
Props netweb. Fixes #2716
|
| [5794]
|
netweb
|
Tests: Remove instances of `bbp_clean_post_cache()` no longer required in topic template counts tests
Props thebrandonallen. Fixes #2812
|
| [5793]
|
netweb
|
Add `autocomplete="off"` to password field on login widget, user login form, and converter form.
Props pareshradadiya. Fixes #2772
|
| [5792]
|
netweb
|
Tests: Updated forum component count functions tests
Props thebrandonallen, netweb. See #2801
|
| [5791]
|
netweb
|
Tests: Tests for the common component query functions
* `public function test_bbp_get_public_child_ids()` for `bbp_get_public_child_ids()`
* `public function test_bbp_get_public_child_count()` for `bbp_get_public_child_count()`
Props thebrandonallen, netweb. See #2801
|
| [5790]
|
netweb
|
Common: Updated PHPDocs for `bbp_get_public_child_ids()`
|
| [5789]
|
netweb
|
Tests: Remove erroneous assertion in `test_bbp_get_all_child_ids()`
|
| [5788]
|
netweb
|
Common: Include `bbp_get_pending_status_id()` post status for topic and reply post type cases in `bbp_get_all_child_ids()` and PHPDoc fixes including addition of missing `@since` revision
Props netweb. Fixes #2810
|
| [5787]
|
netweb
|
Tests: Test `test_bbp_get_all_child_ids()` for `bbp_get_all_child_ids()`
Props thebrandonallen, netweb. See #2810, #2801
|
| [5786]
|
netweb
|
Tests: Tests for the `bbp_get_forum_last_*()` template functions.
|