| [5896]
|
netweb
|
Tests: If we add filters in tests, we need to also remove them for WordPress < 4.0 compatability
Props thebrandonallen. See #2845
|
| [5895]
|
netweb
|
Tests: Update PHPUnit bootstrap instructions for executing bbPress' BuddyPress tests
Props thebrandonallen. Fixes #2846
|
| [5894]
|
netweb
|
Replies: Clarify inline doc surrounding `bbp_show_lead_topic()` in `bbp_get_reply_position()`
This changest clarify's the docs on how `bbp_show_lead_topic()` affects a reply's menu order in a topics reply loop and determining the correct pagination of reply URL's.
Includes unit tests for `bbp_reply_position()` and `bbp_get_reply_url()`
Fixes #2845
|
| [5893]
|
netweb
|
Topics: Fix incorrect PHPDoc references to `bbp_show_lead_topic()` in `bbp_display_topics_feed_rss2()` and `bbp_display_replies_feed_rss2()`
|
| [5892]
|
johnjamesjacoby
|
Tools: Add `id` attribute to "Run" link. Props tharsheblows. See #2841.
|
| [5891]
|
netweb
|
Replies: Remove previous `menu_order` default from `bbp_insert_reply()` missed in r5889
Antiprops netweb. See #2843.
|
| [5890]
|
netweb
|
Tests: Update tests to always include a parent topic for replies
This changeset ensures replies always have a parent topic which in turn ensures each reply is created with an accurate `menu_order` position.
Fixes #2843
|
| [5889]
|
netweb
|
Replies: Include replies menu order when creating replies with `bbp_insert_reply()` improving reply unit tests
See #2843
|
| [5888]
|
netweb
|
Bumps: Normalize type-casting in `bbp_bump_user_reply_count()` missed in r5732
See #2801
|
| [5887]
|
netweb
|
Tests: Skeleton test placeholders for user options functions
|
| [5886]
|
johnjamesjacoby
|
Topics: First pass at metabox for replies in single-topic edit
* Includes `topic-replies` list-table class
* Includes helper functions for hooking things in
* Todo: cap checks or row-actions, maybe bulk-actions, formatting clean-up
See #2842.
|
| [5885]
|
johnjamesjacoby
|
Tools: Update "Repair Tools" to use a list-table UI:
* Includes helper functions for: search, filtering, and bulk actions
* Improves tool registration by including strings and feedback into an array stored in `bbpress()->admin->tools`
* Introduces "Overhead" property for alerting Key Masters to the performance impact running each tool
* Introduces "Components" properties for identifying which counts what tools are intersecting
* Todo: use a `WP_List_Table` subclass (which bbPress has avoided needing until now)
See #2841.
|
| [5884]
|
johnjamesjacoby
|
Admin: Update `h2` to `h1` and remove `icon32` compatibility.
This changeset improves accessibility and brings bbPress's admin area headers up to par with WordPress 4.3.
Fixes #2840. See #WP31650.
|
| [5883]
|
netweb
|
Installation: When creating initial content, use different times for forum, topic, and reply post times.
This changeset builds on r5843 to allow improved tests in `test_bbp_create_initial_content()` of forum and topic last active times.
|
| [5882]
|
netweb
|
Updated `_admin.scss` via WP:changeset:33067, WP:changeset:33284, WP:changeset:33285, WP:changeset:33289, WP:changeset:33409, and WP:changeset:33453
See #2583
|
| [5881]
|
netweb
|
Tests: Remove debug fragment leftover in `test_bbp_get_topic_freshness_link()` missed in r5880
|
| [5880]
|
netweb
|
Replies: In `bbp_update_reply_walker()` always update the topics last active time with `bbp_update_topic_last_active_time()` regardless of reply's published status.
This changeset including unit tests ensures that when calling reply actions spam/unspam, trash/untrash, approve/unapprove the reply's parent topic's last active time is updated to the time of the last published reply.
Props netweb. See #2838
|
| [5879]
|
netweb
|
Tests: Various topic template tests for `BBP_Tests_Topics_Template_Topic`
|
| [5878]
|
netweb
|
Tests: Add `test_bbp_get_topic_favorite_link()` topic templates test
|
| [5877]
|
netweb
|
Tests: Add `test_bbp_approve_reply()` and `test_bbp_unapprove_reply()` reply functions tests
|
| [5876]
|
netweb
|
Tests: Revert incorectly formatted PHPUnit `@covers` doc blocks that slipped in via r5875
|
| [5875]
|
netweb
|
Tests: Various reply template tests for `BBP_Tests_Replies_Template_Reply`
|
| [5874]
|
netweb
|
Tests: Various forum template tests for `BBP_Tests_Forums_Template_Forum_Last_Thing`
|
| [5873]
|
netweb
|
Tests: Complete topic template tests in `BBP_Tests_Topics_Template_Get_Topic_Last_Thing`
|
| [5872]
|
netweb
|
Tests: Include `bbp_get_forum_last_reply_id()` assertions in `test_bbp_get_forum_and_topic_last_topic_id_and_last_reply_id()` missed in r5844
See #2806
|
| [5871]
|
netweb
|
Tests: Add forum last active id test `test_bbp_get_forum_last_active_id_with_pending_reply()`.
This test tests the forums last active id to ensure replies with post status `pending` are not used as the forums last active id until the reply is approved.
See #meta1140
|
| [5870]
|
netweb
|
Tests: Add topic voice count test `test_bbp_get_topic_voice_count_with_pending_reply()`.
This test tests the voice count of a topic to ensure replies with post status `pending` are not included in the voice count until approved.
See #meta1140
|
| [5869]
|
netweb
|
Travis-CI: Include WordPress v4.2 in test matrix
|
| [5868]
|
johnjamesjacoby
|
Strings: prefer `—` over parenthesis when wrapping "No" style results.
This changeset normalizes the strings used to pick the parent of a forum, topic, and reply. The `—` may be changed later to improve localization, but for now this provides a good balance of visual separation and familiar UX.
|
| [5867]
|
johnjamesjacoby
|
Strings: Switch from "Freshness" to "Last Post" in the `default` theme-compatibility templates.
This changeset updates the column header text used to describe the last activity of a forum/category or topic in bbPress's `default` theme-compatibility (which includes details beyond just the timestamp) making "Last Post" more contextually accurate compared to "Freshness" which still makes sense within the dashboard (which currently only shows the timestamp.)
Fixes #2031.
|
| [5866]
|
johnjamesjacoby
|
Prefer `current_filter()` over `current_action()` to maintain compatibility with WordPress versions older than 3.9. Fixes #2529.
|
| [5865]
|
netweb
|
Tests: In `test_bbp_get_forum_freshness_link()` create posts using a concise post date/time.
This changeset prevents the related unit test from incorrectly failing by ensuring that no content is created 1 second after any other.
|
| [5864]
|
netweb
|
Travis-CI: Remove HHVM-Nightly, HHVM nightly packages for Ubuntu Precise have been discontinued.
|
| [5863]
|
netweb
|
Tests: When creating posts that use date/time assertions use a concise post date/time.
This changeset prevents the related unit test from incorrectly failing by ensuring that no content is created 1 second after any other.
|
| [5862]
|
netweb
|
Moderators: Add missing @since PHPDoc missed in `bbp_map_forum_mod_meta_caps()` via r5834
|
| [5861]
|
netweb
|
Tests: Remove unused test assertion `test_bbp_get_forum_last_reply_id()`
|
| [5860]
|
johnjamesjacoby
|
Topics: fallback on `post_parent` in `bbp_update_topic_walker()`.
This changeset fixes a bug where forum topic counts were not updated when topics were permanently deleted, causing hidden topic counts to be wildly inaccurate.
Props thebrandonallen. Fixes #2529.
|
| [5859]
|
johnjamesjacoby
|
Replies: fallback on `post_parent` in `bbp_update_reply_walker()`.
This changeset fixes a bug where topic reply counts were not updated when replies were permanently deleted, causing hidden reply counts to be wildly inaccurate.
Props thebrandonallen. Fixes #2529.
|
| [5858]
|
johnjamesjacoby
|
Queries: Clean up post status concatenation in 2 queries.
This changeset moves array of "hidden" type post-statuses into their own variable to better match existing usages.
Fixes #2826.
|
| [5857]
|
johnjamesjacoby
|
BuddyPress: Check for missing activity component when looking for an activity stream item.
This changeset fixes a bug that would result in duplicate activity stream items when editing a topic or reply.
Props r-a-y. Fixes #2690.
|
| [5856]
|
johnjamesjacoby
|
Forums: Introduce `bbp_update_forum_visibility` action in `bbp_save_forum_extras()`
This changeset provides custom visibilites with an execution point to perform their own actions.
Fixes #2740.
|
| [5855]
|
johnjamesjacoby
|
Forums: Fix copy-pasta filter names.
This changeset corrects filters used in 2 `apply_filters()` calls to properly match their function names.
Props netweb. Fixes #2688.
|
| [5854]
|
johnjamesjacoby
|
Templates: Add before & after hooks to user templates parts.
This changeset makes it easier to add custom text & HTML before & after user details.
Props netweb. Fixes #2537.
|
| [5853]
|
johnjamesjacoby
|
Moderation: reduce moderation restriction from `keep-gate` to `moderate` in `bbp_check_for_moderation()`.
This changeset ensures that moderators are able to bypass the forum moderation, seeing as how they can self-approve topics & replies anyways.
Props netweb. Fixes #2726.
|
| [5852]
|
johnjamesjacoby
|
Capabilities: add `delete_posts` mappings to `delete` topic & reply checks.
This changeset ensures that capable users can delete their own topics & replies, when these capabilities are explicitly allowed already.
Props netweb, gusrb84. Fixes #2685.
|
| [5851]
|
johnjamesjacoby
|
Admin: Check that the user can view the About page before adding the toolbar item.
This changeset ensures that only capable users will see the link to bbPress's admin-area "About" page.
Props ocean90. Fixes #2836.
|
| [5850]
|
johnjamesjacoby
|
Admin: Add `hidden_post_status` field back to topic & reply metaboxes, and use `draft` or current post status as value.
This changeset fixes a bug that caused topics & replies to be marked as edited when moderated via `wp-admin`.
Hat-tip tharsheblows. Fixes #2741.
|
| [5849]
|
johnjamesjacoby
|
BuddyPress: Add all topic statuses to `bbp_filter_modify_page_title()`.
This changeset fixes a bug that only allowed published topics to be queried in group forums.
Props netweb. Fixes #2699.
|
| [5848]
|
johnjamesjacoby
|
BuddyPress: Pass the currently logged in user ID when creating toolbar links. See #2713.
|
| [5847]
|
johnjamesjacoby
|
BuddyPress: Do not filter admin toolbar URLs if not on BuddyPress root blog.
This changeset addresses a multisite implementation issue where user profiles would link to invalid URLs when BuddyPress is network activated and bbPress is active on the non-root blog.
Props imath. Fixes #2713.
|
| [5846]
|
johnjamesjacoby
|
BuddyPress: Do not filter profile URLs if not on BuddyPress root blog.
This changeset addresses a multisite implementation issue where user profiles would link to invalid URLs when BuddyPress was network activated and bbPress was active on the non-root blog.
Props imath. See #2713.
|
| [5845]
|
johnjamesjacoby
|
Widgets: Add class to forum widget to indicate if item in list is the current forum being viewed.
Props dimitrov.adrian, netweb. Fixes #2536.
|
| [5844]
|
johnjamesjacoby
|
Add unit test for last topic & reply ID's for topics & forums. Fixes #2806. Props netweb.
|
| [5843]
|
johnjamesjacoby
|
Installation: When creating initial content, use the same `current_time( 'mysql' )` for all new posts.
This changeset prevents the related unit test from incorrectly failing by ensuring that no initial content is created 1 second after any other.
|
| [5842]
|
johnjamesjacoby
|
IDs: Some reply functions still default to their topics if no replies are present. This functionality has slowly been removed over time and built into respective functions. In this changeset, we remove those leftover assignments and update a few phpdoc descriptions as needed.
Hat-tip netweb. See #2806.
|
| [5841]
|
johnjamesjacoby
|
Moderation: Fix some copy-pasta and make sure form terms are formatted correctly. See #459.
|
| [5840]
|
johnjamesjacoby
|
In `BBP_Akismet::filter_post_terms()` use `bbp_get_topic_tag_names()` to use cached function instead of querying for object terms.
|
| [5839]
|
johnjamesjacoby
|
Moderators: Rename `bbp_get_forum_mod_ids()` to `bbp_get_forum_moderator_ids()` to better match unabbreviated forum equivalent. Also update phpdoc & refactor some logic to use cached functions. See #459.
|
| [5838]
|
johnjamesjacoby
|
Moderators: Introduce functions for theme-side setting & getting of forum mods for `form-forum.php`. See #459.
|
| [5837]
|
johnjamesjacoby
|
Terms: Update functions for getting terms & term names to be more flexible & reusable by other functions. See #459.
|
| [5836]
|
johnjamesjacoby
|
Moderators: Add forum moderators field to `form-forum.php` template part. See #459.
|
| [5835]
|
johnjamesjacoby
|
Moderators: Introduce `none` argument for topic-tags & forum-mods list functions.
This change allows for passing text or HTML to output if no taxonomy terms are found, and uses this new functionality in `wp-admin` to show per-forum moderators in the list-table column, also reducing code duplication.
See #459.
|
| [5834]
|
johnjamesjacoby
|
Moderators: First pass at per-forum moderators.
This commit introduces a powerful feature commonly found in other popular forum software that has been on our wishlist for nearly 9 years. It includes the following changes:
* Custom `forum-mod` taxonomy for assigning user nicenames to forum IDs
* Associated functions for defining capabilities, labels, etc...
* New capability filters for ensuring forum moderators have the ability to moderate forums even without the `moderator` role assignment
* New option for toggling the entire feature on/off (on by default)
Props jmdodd, netweb. See #459.
|
| [5833]
|
johnjamesjacoby
|
Add ability to use icons as column headers ala Comment bubbles (off by default.)
|
| [5832]
|
johnjamesjacoby
|
Add future support for forum/topic/reply dashicon column headers to `admin.css`.
|
| [5831]
|
netweb
|
Tests: Add admin tools test `test_bbp_admin_repair_topic_voice_count()` for `bbp_admin_repair_topic_voice_count()`
Props netweb. See #2533
|
| [5830]
|
netweb
|
Bump tested-up-to version to 4.2. (trunk)
|
| [5829]
|
johnjamesjacoby
|
I think this building should be condemned. There's serious metal fatigue in all the load-bearing members, the wiring is substandard, it's completely inadequate for our power needs, and the neighborhood is like a demilitarized zone.
|
| [5828]
|
johnjamesjacoby
|
Akismet: Clean up potential accidental inline assignment in `BBP_Akismet::check_post()`.
This commit moves a variable assignment out of a comparison to improve code clarity.
|
| [5827]
|
johnjamesjacoby
|
Abstraction: Use `bbp_db()`, `bbp_rewrite()` & friends, introduced in r5823 & r5826.
This commit improves the stability of bbPress in the WordPress environment by reducing global variable exposure. It also comes with minimal opcode improvements in some circumstances where `$GLOBALS` is preferred over defining via `global` statements.
Some additional surrounding cleanup directly related to functions & methods being altered is also being performed here.
Fixes #2786.
|
| [5826]
|
johnjamesjacoby
|
Introduce `bbp_get_global_object()` to help with verifying & retrieving global variables before interacting with them. See #2786.
|
| [5825]
|
johnjamesjacoby
|
Update incorrect phpdoc block in `bbp_update_reply_position()`.
|
| [5824]
|
johnjamesjacoby
|
Remove incorrect `@global` tag in `BBP_Akismet::submit_post()`.
|
| [5823]
|
johnjamesjacoby
|
Introduce `core/abstraction.php` to provide a layer of protection against touching common WordPress global variables directly.
This commit introduces a few new helper functions to protect sensitive global variables, and also introduces the ability to filter and override them explicitly within the scope of the bbPress plugin. These functions will be used in place of existing global touches in future commits.
See #2786.
|
| [5822]
|
johnjamesjacoby
|
BuddyPress: Use `bbp_get_paged_slug()` instead of `$wp_rewrite->pagination_base` directly.
|
| [5821]
|
johnjamesjacoby
|
Make a statement without saying a word. (!)
|
| [5820]
|
johnjamesjacoby
|
Queries: Remove `post_parent__in` query-parameter filter.
This commit removes the `bbp_query_post_parent__in()` filter that was introduced in r2996, and uses WordPress core's built in query parameters introduced in #WP11056.
Fixes #2832.
|
| [5819]
|
netweb
|
Include 2.5.8 in readme.txt changelog (for trunk) and bump stable tag
|
| [5818]
|
netweb
|
Create tag 2.5.8.
|
| [5817]
|
netweb
|
Update bbpress.pot in 2.5 branch.
|
| [5816]
|
netweb
|
Bump 2.5 branch to 2.5.8.
|
| [5815]
|
johnjamesjacoby
|
Users: Use `bbp_get_user_profile_url()` to avoid code duplication.
This commit removes duplicated code used to build user profile URLs & eliminates several superfluous string replacements. It works with pretty & unpretty permalinks, and plays nicely with the BuddyPress extension for linking to a member's forum sections.
Fixes #2831.
|
| [5814]
|
johnjamesjacoby
|
Users: Remove `is_email()` check from user query parsing.
This commit removes the ability to load a user profile via their email address. This feature (added in r2917) was a convenience mechanism to make finding a user within the forums with a known address easier, but times have changed and we now consider this to be a privacy concern by default.
Note: this will break backwards-compatibility for installations that may have used this unpublicized (and regrettably unwise) feature.
Fixes #2828. Hat-tip netweb. For 2.5.8 (2.5 branch)
|
| [5813]
|
johnjamesjacoby
|
Users: Remove `is_email()` check from user query parsing.
This commit removes the ability to load a user profile via their email address. This feature (added in r2917) was a convenience mechanism to make finding a user within the forums with a known address easier, but times have changed and we now consider this to be a privacy concern by default.
Note: this will break backwards-compatibility for installations that may have used this unpublicized (and regrettably unwise) feature.
See #2828. Hat-tip netweb. For 2.6 (trunk)
|
| [5812]
|
netweb
|
Tests: Tests for the common component common functions
Props netweb
|
| [5811]
|
netweb
|
Topics: Fix `bbp_get_topic_post_date()` default GMT date format copy pasta introduced in r4647, includes unit tests.
Props tobyhawkins. Fixes #2697
|
| [5810]
|
netweb
|
Admin: Updated Topic and Reply contextual help
Props robkk. Fixes #2824
|
| [5809]
|
johnjamesjacoby
|
Admin: Remove `_nopriv_` ajax actions.
This commit ensures that admin-area AJAX suggestion results are never presented to logged-out users.
(Note: these requests already have nonce & capability checks on them, so this bit of hardening is only useful to installations that have modified roles & capabilities outside of what is considered to be normal operating parameters, allowing logged-out users to also be forum moderators.)
Hat-tip glynwintle. See #2827. For 2.6.0 (trunk)
|
| [5808]
|
johnjamesjacoby
|
Admin: Remove `_nopriv_` ajax actions.
This commit ensures that admin-area AJAX suggestion results are never presented to logged-out users.
(Note: these requests already have nonce & capability checks on them, so this bit of hardening is only useful to installations that have modified roles & capabilities outside of what is considered to be normal operating parameters, allowing logged-out users to also be forum moderators.)
Hat-tip glynwintle. See #2827. For 2.5.8 (2.5 branch)
|
| [5807]
|
johnjamesjacoby
|
BuddyPress Groups: Backport r5560 to 2.5 branch (for 2.5.8) for improved PHP5 compatibility and to avoid a debug notice.
Props boonebgorges.
|
| [5806]
|
johnjamesjacoby
|
Users: Add hardening to `bbp_edit_user_handler()` super-admin grant/revoke action when editing a user's profile.
This commit ensures only super-administrators that also have the `manage_network_options` capability are able to modify another user's super-administrator privilege.
(Note that `bbp_edit_user_handler()` has several other conditional checks to prevent privilege escalation here, and this change is only useful for installations that modify core role & capability behavior via third-party plugins in such a way as to have bungled the capabilities of multisite super-administrators.)
Props glynwintle. For 2.5.8 (2.5 branch)
|
| [5805]
|
johnjamesjacoby
|
Users: Add hardening to `bbp_edit_user_handler()` super-admin grant/revoke action when editing a user's profile.
This commit ensures only super-administrators that also have the `manage_network_options` capability are able to modify another user's super-administrator privilege.
(Note that `bbp_edit_user_handler()` has several other conditional checks to prevent privilege escalation here, and this change is only useful for installations that modify core role & capability behavior via third-party plugins in such a way as to have bungled the capabilities of multisite super-administrators.)
Props glynwintle. For 2.6 (trunk)
|
| [5804]
|
netweb
|
Update Grunt dependencies in package.json:
* `grunt-checktextdomain` major version update (Improved task error handing)
* `grunt-contrib-jshint` patch version update
* `grunt-contrib-uglify` minor version update (causes some changes to minified JS)
* `grunt-sass` major version update ( underlying libsass update )
* `grunt-wp-i18n` patch version update
Fixes #2821
|
| [5803]
|
netweb
|
Updated admin base SCSS styles:
* `_admin.scss` via WP:changeset:31747, WP:changeset:31952, and WP:changeset:32075
* `_variables.scss` via WP:changeset:32051
See #2583
|
| [5802]
|
johnjamesjacoby
|
Always predefine `$args` as an array, for code consistency across all components.
|
| [5801]
|
netweb
|
Tests: Update `test_bbp_create_initial_content()` to not use hard coded forum, topic and reply id's.
|
| [5800]
|
netweb
|
Importers: Updated AIM, YIM, and Jabber user meta key prefixes importer user profile fields for AEF, FluxBB, Kunena3, MyBB, PunBB, SMF, XMB, vBulletin and vBulletin3 importers
Props netweb. Fixes #2815
|
| [5799]
|
netweb
|
Example importer: Change AIM, YIM, and Jabber profile fields to generic examples with meta key prefixes
Props netweb. See #2815
|
| [5798]
|
netweb
|
phpBB Importer: Missed forum total topic and total reply count schema change
See #2716
|
| [5797]
|
netweb
|
phpBB importer: Updated AIM, YIM, and Jabber user meta key prefixes
Props netweb. See #2815
|