| [5996]
|
netweb
|
Build Tools: Add NPM package `postcss-scss` for styelelint SCSS compatibility
This changeset fixes an idiosyncratic NPM v3.x issue with "flat" folders and sharing dependencies that is not an issue when using NPM v2
See #2924
|
| [5995]
|
netweb
|
Build Tools: Add @stylelint for linting CSS to adhere to WordPress CSS Coding Standards
This changeset adds a new Grunt task `grunt postcss:lint` that runs stylelint on CSS & SCSS files to ensure bbPress' CSS adheres to WordPress CSS Coding Standards.
8 months in the making and is maintained by yours truly @netweb, with stylelint I'm learning JavaScript deeply.
See also:
* http://stylelint.io/
* https://github.com/stylelint/stylelint
* https://github.com/ntwb/stylelint-config-wordpress
* https://make.wordpress.org/core/handbook/best-practices/coding-standards/css/
Hat-tip: David Clark and Richard Hallows for the ongoing help and support.
Props netweb.
Fixes #2924.
|
| [5994]
|
netweb
|
Build Tools: Add Autoprefixer for adding CSS vendor prefixes
This changeset adds a new Grunt task `grunt postcss:core` that runs Autoprefixer on CSS & SCSS files to add or remove any vendor prefixes required by browsers.
Browsers supported are the same as WordPress currently supports which are:
* Android >= 2.1
* Chrome >= 21
* Edge >= 12
* Explorer >= 7
* Firefox >= 17
* Opera >= 12.1
* Safari >= 6.0.
Vendor prefixes are are also added for `templates/default/css/bbpress.css` as this is the only file that requires them at this time.
Fixes #2923.
|
| [5993]
|
netweb
|
Updated admin base SCSS styles:
* `_admin.scss` via WP:changeset:34976, WP:changeset:35265, WP:changeset:36532, and WP:changeset:36619
* `_mixins.scss` via WP:changeset:34948
See #2583
|
| [5992]
|
netweb
|
Build Tools: Update grunt-contrib-watch from 0.6.1 to 1.0.0
See #2918
|
| [5991]
|
netweb
|
Bump minimum WordPress requirement to 4.0.
Fixes #2902.
|
| [5990]
|
netweb
|
bbPress: Bumb readme.txt tested-up-to tags to 4.5.
|
| [5989]
|
netweb
|
Importers: Add support for anonymous topic and reply import support in XenForo (XenForo.php) importer
This changeset adds support for importing topics and replies where the original XenForo author was deleted, this keeps the original author name as the now topic or reply anonymous author name.
Props netweb.
Fixes #2922, See aslo #2347.
|
| [5988]
|
netweb
|
Tools: Use updated meta key `_bbp_old_user_id` to determine imported users in `bbp_admin_reset_handler()`
This changeset updates the meta key used to determine an imported user for handling the deletion of imported users in the reset forums tool, this should have originally been included in r5530 but was missed.
See #2650
|
| [5987]
|
netweb
|
Build Tools: Revert Travis CI TRAVIS_NODE_VERSION environment variable changes from r5984/r5985, installing NodeJS 4.x.x via NVM is sufficient per r5986.
Fixes #2920.
|
| [5986]
|
netweb
|
Build Tools: Install NodeJS 4.x.x using NVM in Travis CI
See #2920
|
| [5985]
|
netweb
|
Build Tools: Define TRAVIS_NODE_VERSION as a global variable for Travis CI
See #2920
|
| [5984]
|
netweb
|
Build Tools: Add minimum NodeJS 4.2.x LTS version
This changeset sets the minimum required NodeJS version supported. This is required as various NPM modules now require a minimum version greater than the default v0.10.x currently in use.
See #2920.
|
| [5983]
|
netweb
|
Build Tools: Renamed `grunt-rtlcss` option `options.config` to RTLCSS v2.x `options.opts` option
See #2918
|
| [5982]
|
netweb
|
Build Tools: Update `grunt-rtlcss` from `1.6.0` to `2.0.1`
Fixes #2918
|
| [5981]
|
netweb
|
Build Tools: Update `grunt-sass` from `1.0.0` to `1.1.0`
See #2918
|
| [5980]
|
netweb
|
Build Tools: Update `matchdep` from `0.3.0` to `1.0.1`
See #2918
|
| [5979]
|
netweb
|
Build Tools: Update `grunt-check-dependencies` from `0.11.2` to `0.12.0`
See #2918
|
| [5978]
|
netweb
|
Build Tools: Update `grunt-contrib-uglify` from `0.9.2` to `1.0.0`
See #2918
|
| [5977]
|
netweb
|
Build Tools: Update `grunt-contrib-jshint` from `0.11.2` to `1.0.0`
See #2918
|
| [5976]
|
netweb
|
Build Tools: Update `grunt-contrib-copy` from `0.8.0` to `1.0.0`
This changeset fixes the "my bad" r5975 commit where the version was accidentally committed as `0.1.0` instead of `1.0.0`
See #2918
|
| [5975]
|
netweb
|
Build Tools: Update `grunt-contrib-copy` from `0.8.0` to `1.0.0`
See #2918
|
| [5974]
|
netweb
|
Build Tools: Update `grunt-contrib-cssmin` from `0.6.0` to `1.0.0`
See #2918
|
| [5973]
|
netweb
|
Build Tools: Update `grunt-contrib-cssmin` from `0.13.0` to `1.0.0`
See #2918
|
| [5972]
|
netweb
|
Use HTTPS for w.org links
|
| [5971]
|
netweb
|
Users: The `user.js` file should have a blank newline at the end of file
Fixes #2907.
|
| [5970]
|
netweb
|
bbPress: Bumb readme.txt tested-up-to tags to 4.4.
|
| [5969]
|
netweb
|
API - Feeds: Use `feed_content_type( 'rss2' )` for RSS feeds.
This changeset updates the RSS 2 native mime type `application/rss+xml`, previously `rss-http` used `text/xml` which was removed from WordPress in [WP36230] and [WP32468].
Props thebrandonallen.
Fixes #2901.
|
| [5968]
|
netweb
|
Tests: Fix copy pasta class name in `@covers` annotation in `test_bbp_admin_repair_forum_topic_count()`
|
| [5967]
|
netweb
|
Tests: Use a category forum as the parent forum in `test_bbp_create_initial_content()` and add test assertions for this parent category forum.
|
| [5966]
|
netweb
|
Tests: Include missing forum meta from category forums added in r5965
|
| [5965]
|
netweb
|
Tests: Add a parent forum category for each test in `::BBP_Tests_Forums_Template_Forum_Last_Thing`
This changeset adds a parent category forum for each forum test to ensure hierarchal forum assertions are tested with parent/child forum relationships for the `bbp_get_forum_last_*()` template functions.
|
| [5964]
|
netweb
|
Tools: Add the `grunt-check-dependencies` npm module.
This changeset adds the Grunt task `checkDependencies` via https://www.npmjs.com/package/grunt-check-dependencies to check the currently npm installed modules against the required modules semantic version listed in `package.json`, if the check fails a prompt to update installed npm modules is displayed and is required before other Grunt tasks can be run.
Run `npm install` after updating your repo to install the module and task.
Props netweb.
Fixes #2893.
|
| [5963]
|
netweb
|
Tools: Update the `priority` array values of individual repair tools in `bbp_register_default_repair_tools()`
This changeset fixes an issue where the `bbp_admin_repair_topic_meta()` repair tool was not included in the list table.
Props netweb, thebrandonallen.
Fixes #2859.
|
| [5962]
|
netweb
|
Tests: Improved private and hidden status forum permalink tests in `test_bbp_get_forum_permalink()`
This changeset improves `test_bbp_get_forum_permalink()` tests by adding assertions for `private` and
`hidden` posts statuses with hierarchal nested forum URL's using `bbp_get_forum_permalink()`.
This regression was introduced with WordPress 4.4 in [wordpress:changeset:34001]
See: #WP35804
|
| [5961]
|
netweb
|
Build Tools: Add WordPress 4.4 to the Travis CI build matrix
|
| [5960]
|
netweb
|
Tools: Include `forum-mod` taxonomy code in `bbp_admin_reset_handler()`
This changeset adds support for deleting the forum moderator taxonomy when running the bbPress "Reset Forums" tool.
Props netweb.
Fixes #2898.
|
| [5959]
|
netweb
|
Tools: Travis CI: Only test PHP 7 against WordPress 4.3 or greater
This changeset updates the Travis CI test matrix to match WordPress' PHP 7 compatability, which was only added in version 4.3 so lets not let those errors in versions before 4.3 bother us ;)
See #2895.
|
| [5958]
|
netweb
|
Tools: Travis CI: Remove PHP7 from allowed failures list and test PHP nightly builds
PHP 7 was released today, congratulations to everyone involved in the release :)
Props netweb.
Fixes #2895.
|
| [5957]
|
netweb
|
Shortcodes: Fix `@return` type shring/string typo in `display_stats()`
|
| [5956]
|
netweb
|
Shortcodes: Remove superfluous `@param` PHPDoc instances from various shortcode functions
Props casiepa.
|
| [5955]
|
netweb
|
Tests: Fix failing `BBP_Tests_Topics_Functions_Update_Topic_Last_Thing` tests
* Pass the active id as the 2nd parameter to `bbp_update_topic_last_active_id()` in `test_bbp_update_topic_last_active_id()`
* Pass the reply id as the 2nd parameter to `bbp_update_topic_last_reply_id()` in `test_bbp_update_topic_last_reply_id()`
This fixes the current two failing unit tests by passing what should be optional paremeters to their respceptive functions.
See #1799, [5954]
|
| [5954]
|
netweb
|
Performance: Replace direct SQL queries with `WP_Query()` objects in the following functions:
* `bbp_update_forum_topic_count()`
* `bbp_update_forum_topic_count_hidden()`
* `bbp_update_forum_reply_count()`
* `bbp_get_public_child_last_id()`
* `bbp_get_public_child_count()`
* `bbp_get_public_child_ids()`
Props johnjamesjacoby.
See #1799.
|
| [5953]
|
netweb
|
Tests: More tests for the common component query functions:
* `test_bbp_query_post_parent__in()` for `bbp_query_post_parent__in()`
* `test_bbp_get_public_child_last_id()` for `bbp_get_public_child_last_id()`
See #1799
|
| [5952]
|
netweb
|
Credits: Update H4 to H3
This changeset improves accessibility and brings bbPress' credits area headers up to par with WordPress 4.4.
Fixes #2890. See #WP34263.
|
| [5951]
|
netweb
|
Standardize `@since` PHPDoc tags style and format
* e.g. `@since 2.6.0 bbPress (r5951) YOLO`
* See http://phpdoc.org/docs/latest/references/phpdoc/tags/since.html
This changeset updates the style and formatting of all of our `@since` instances for compatibility with phpDocumentor 2 and WP-Parser as we move toward implementing the bbPress developer code reference.
Props thebrandonallen
Fixes #2879
|
| [5950]
|
netweb
|
Theme Compatibility: Add support for `singular.php` in the root template hierarchy.
This changeset adds upport for the `singular.php` fallback template introduced in [WP22314]
Props mercime
Fixes #2868
|
| [5949]
|
netweb
|
Users: In `BBP_Default::enqueue_scripts` remove rogue script dependency for single user edits
This changeset removes the `user-query` dependency that was accidentally introduced in r5183
Props tharsheblows
Fixes #2877
|
| [5948]
|
netweb
|
Accessibility: Include input labels for field titles in bbPress settings
This changeset aligns bbPress input label fields with current WordPress standard for improved accessibility
Props ankit-k-gupta, thebrandonallen
Fixes #2866
|
| [5947]
|
netweb
|
Tests: Updated bbPress PHPUnit test suite compatibility with upstream WordPress changes.
* [WP34802], [WP34803], [WP34807], and [WP34810] introduced `set_permalink_structure`, it's implementation broke bbPress',
* [WP35244] `WP_UnitTest_Generator_Sequence` needs a static incrementer - otherwise, it assumes every test class is a reset, which it no longer is (it is now static), updated bbPress unit tests where explicitly set content and titles are required.
Props thebrandonallen. Fixes #2883
|
| [5946]
|
netweb
|
Users: Update `$_SERVER['REMOTE_ADDR']` IP adress check to `127.0.0.1` in `bbp_current_author_ip()`
This changeset updates our unit tests and ensures compatability with WordPress test suite where in [WP34172] `$_SERVER[ 'REMOTE_ADDR' ]` is now initialised during the test bootstrap so individual tests need not.
Props thebrandonallen. See #2883.
|
| [5945]
|
netweb
|
Core: Restore empty `$wp_filter[ $tag ]` check and update PHPDoc in `bbp_get_template_stack()`
See #2871
|
| [5944]
|
netweb
|
Core: Support for `WP_Hook` in `bbp_get_template_stack()`
The proposed `WP_Hook` #WP17817 breaks backward compatibility for plugins that
attempt to manipulate `$wp_filter` in certain ways. For bbPress, it means
that we cannot directly modify the callbacks that are currently registered as
an array at `$wp_filter[ $tag ]`, in `bbp_get_template_stack()`. Instead, when
`WP_Hook` is not available, we assign the callbacks to a variable (leveraging
`WP_Hook`'s `ArrayAccess`) and manipulate the variable.
Props jbrinley. Fixes #2871
|
| [5943]
|
netweb
|
Tests: Temorarily remove `fast_finish: true` from Travis CI configuration for now.
Upstream: https://github.com/travis-ci/travis-ci/issues/4928
See also: https://core.trac.wordpress.org/changeset/35150
|
| [5942]
|
netweb
|
Tests: Include WordPress 4.3 in Travis CI test matrix
|
| [5941]
|
netweb
|
Tests: Use `assertEqualSets()` in:
* `BBP_Tests_Forums_Functions_Query::test_bbp_forum_query_topic_ids`
* `BBP_Tests_Forums_Functions_Query::test_bbp_forum_query_subforum_ids`
This changeset improves array comparisons where that arrays may not be in the same order.
Props thebrandonallen. See #2883
|
| [5940]
|
netweb
|
i18n: Merge similar translation strings
This changset brings consistency to failed warning strings in our repair tools and removes extra whitespace in two strings. This reduces the number of strings that our translation volunteers need to translate.
Props ramiy. Fixes #2880
|
| [5939]
|
netweb
|
Update `readme.txt` installation steps with correctly formatted markdown. (2.5 branch)
This changeset fixes an issue where incorrectly formatted markdown list items would not display as expected in the w.org plugin readme.
Props ramiy. See #2884
|
| [5938]
|
netweb
|
Update `readme.txt` installation steps with correctly formatted markdown. (trunk)
This changeset fixes an issue where incorrectly formatted markdown list items would not display as expected in the w.org plugin readme.
Props ramiy. See #2884
|
| [5937]
|
netweb
|
Bump tested-up-to version to 4.3. (2.5 branch)
|
| [5936]
|
netweb
|
Bump tested-up-to version to 4.3. (trunk)
|
| [5935]
|
johnjamesjacoby
|
Add Composer support. Fixes #2712.
|
| [5934]
|
netweb
|
Tests: Fix incorrect assertion type in `test_bbp_forum_query_topic_ids()` and `test_bbp_forum_query_subforum_ids()`, also now includes topic meta for topics in `test_bbp_forum_query_topic_ids()()`
|
| [5933]
|
johnjamesjacoby
|
Akismet: include title with content. Props cfinke. Fixes #2858.
|
| [5932]
|
johnjamesjacoby
|
Admin: Swap `%d` for `%s` in `bbp_filter_dashboard_glance_items()`.
This changeset fixes a bug causing numbers to be truncated at the first non-numeric character.
Fixes #2857.
|
| [5931]
|
netweb
|
Tests: Add topic and topic reply spam/unspam tests `test_bbp_spam_topic()`, `test_bbp_spam_topic_replies()`, `test_bbp_unspam_topic()`, and `test_bbp_unspam_topic_replies()`
Props netweb. See #2494.
|
| [5930]
|
johnjamesjacoby
|
Topics: sanity check `$_REQUEST` and introduce list-table methods for reply table-navigation.
This changeset fixes a potential debug notice introduced in r5886, and removes unused functionality inherited from `WP_List_Table`.
Fixes #2842. See #2587.
|
| [5929]
|
netweb
|
Tests: Fix incorrect reply post date time assertion in `test_bbp_get_topic_last_active_time()`
|
| [5928]
|
netweb
|
Tests: User subscription and user favorites tests in `BBP_Tests_Users_Functions_Subscriptions` and `BBP_Tests_Users_Functions_Favorites`
Props thebrandonallen. Fixes #2855.
|
| [5927]
|
netweb
|
Build Tools: Update `grunt-contrib-uglify` to `v0.9.2`
This changeset includes an update to the parent dependency UglifyJS v2.4.24 which fixes a bug that can cause logic bugs to be introduced into minified JS.
Hat-tip pento. Fixes #2856.
|
| [5926]
|
johnjamesjacoby
|
Favorites: Purge cache when adding/removing a favorite.
This changeset fixes a bug where cache was not busted, causing incorrect results to be returned & displayed.
Props thebrandonallen. See #2855.
|
| [5925]
|
netweb
|
Tests: Ensure bbPress' custom post types posts are created with a unique GUID.
Props tharsheblows, netweb. Fixes #2844, see also #WP5305 / wp:changeset:33630.
|
| [5924]
|
netweb
|
Replies: Improve type-casting in `bbp_update_reply_topic_id()` missed in r5737
Props thebrandonallen. See #2801.
|
| [5923]
|
netweb
|
Forums: Improve type-casting in forum functions.
Props thebrandonallen. See #2801.
|
| [5922]
|
netweb
|
Tests: Remove erroneous `bbp_clean_post_cache()` from `test_bbp_topic_new_reply_counts()` test
|
| [5921]
|
netweb
|
Tests: Introduce generic tests to test forum counts with various new, spam, trash, and approve topic actions
Props thebrandonallen. See #2801.
|
| [5920]
|
netweb
|
Tests: Introduce generic tests to test topic counts with various new, spam, trash, delete, and approve reply actions
Props thebrandonallen. See #2801.
|
| [5919]
|
netweb
|
Tests: Use multiple replies in test `test_bbp_get_user_replies_created()`, this was accidently introcuced in r5890
|
| [5918]
|
netweb
|
Forums: Updated PHPDocs and unit tests for `bbp_update_forum_last_*()` functions.
Props thebrandonallen. Fixes #2811
|
| [5917]
|
netweb
|
Topics: Return `string` in `bbp_update_forum_last_active_time()`
Includes updated PHPdocs and unit tests for `bbp_update_topic_last_*()` functions.
Props thebrandonallen. See #2811
|
| [5916]
|
netweb
|
Tools: Include pending replies in the count when running the "Count pending, spammed, & trashed replies in each topic" repair tool
This changeset ensures that pending replies are included in the topic meta `_bbp_reply_count_hidden` count after running the repair tool `bbp_admin_repair_topic_hidden_reply_count()`, includes unit tests.
Props netweb. Fixes #2849
|
| [5915]
|
netweb
|
Tests: Add `test_bbp_delete_topic_replies()` topics function test
|
| [5914]
|
netweb
|
Tests: Don't use hardcoded `example.org` domain is test assertions.
This changeset allows the default domain used in tests to be overridden using `WP_TESTS_DOMAIN` in `wp-tests-config.php`
|
| [5913]
|
netweb
|
Tools: Update `grunt-contrib-cssmin` to v0.13.0
Changelog: https://github.com/gruntjs/grunt-contrib-cssmin/compare/v0.11.0...v0.13.0
Testing `grunt cssmin` and related bbPress Grunt tasks show no issues with `grunt-contrib-cssmin`
Note: Requires `npm install` to update dependencies
See #2738
|
| [5912]
|
netweb
|
Tools: Remove banners added to minified CSS files and simplified JS banner
This changeset removes the banners that were previously added to minified CSS files as `grunt-contrib-cssmin` deprecated this in v0.11.0.
The banner added to minified JS files has also been simplified by removing the time/date so that unnecessarily merges/updates do not trigger unneeded changes when using version control. The banner added to minified JS files is now static without the date/time, this fixes an issue where the minified file would always change because of the compiled date/time even when there were no code changes, this was causing unneeded changes when merging/updating when using version control external to bbPress.
Props netweb. Fixes #2738
|
| [5911]
|
netweb
|
Tools: RTL CSS generation: Switch from CSSJanus to RTLCSS
* If you have used `grunt cssjanus` before, use `grunt rtlcss` now.
* Requires `npm install` to update dependancies
Props netweb. Fixes #2848, see #WP31332 and wp:changeset:31573
|
| [5910]
|
netweb
|
Tests: Restore original testcase $_SERVER during teardown in `BBP_Tests_Core_Functions_BBPVerifyNonceRequest::during tearDown()`
|
| [5909]
|
johnjamesjacoby
|
Add `@package` and `@subpackage` to file headers where missing; rename if inconsistent; move to bottom of PHPDoc blocks where appropriate. See #WP27262.
|
| [5908]
|
johnjamesjacoby
|
Sniffer: Whitespace around variables in arrays.
|
| [5907]
|
johnjamesjacoby
|
Common: bring `bbp_verify_nonce_request()` up to speed with improvments in BuddyPress.
See #buddypress6528. Props r-a-y.
|
| [5906]
|
johnjamesjacoby
|
BuddyPress: Remove `@todo`s that are todone or todon'ts.
|
| [5905]
|
johnjamesjacoby
|
BuddyPress: Introduce `BBP_Forums_Group_Extension::update_group_forum_visibility()` to keep group forum visibility in alignment with BuddyPress Group visibility.
This changeset ensures that when a BuddyPress Group's visibility changes, it's bbPress forum visibility changes along with it. This avoids a UX issue where Group visibility and Forum visibility could become misaligned when updating a Group.
Props boonebgorges. Fixes #2599.
|
| [5904]
|
johnjamesjacoby
|
Admin: Register color schemes based on bbPress plugin path vs. WordPress source. Fixes #2847.
|
| [5903]
|
johnjamesjacoby
|
Admin: Do not register color schemes when running from source.
This changeset prevents the color picker UI from appearing (and not working) when running WordPress from it's `/src` directory.
See #2847.
|
| [5902]
|
johnjamesjacoby
|
Users: Add tests for user permalink functions. Props thebrandonallen. See #2831.
|
| [5901]
|
johnjamesjacoby
|
Topics: Add `edit_reply` capability check to "Edit" row-action link. See #2842.
|
| [5900]
|
johnjamesjacoby
|
Users: Remove superfluous `home_url()` calls introduced in r5815. Also fixed:
* Replaced `bbp_get_user_profile_url()` with `bbp_get_user_profile_edit_url()` in `bbp_user_profile_edit_link()`
* Fixed `bbp_favorites_permalink()` by using `bbp_get_user_favorites_slug()` instead of `bbp_get_user_favorites_rewrite_id()`
Props thebrandonallen. See #2831.
|
| [5899]
|
johnjamesjacoby
|
Tools: Use `_admin_search_query()`. See #2841.
|
| [5898]
|
netweb
|
Tests: Skeleton test placeholders for core abstraction function wrappers
|
| [5897]
|
netweb
|
Tests: Initial unit tests for /includes/users/template.php
Props netweb. See #2831
|