Changeset 7821

Timestamp:

10/04/2026 06:24:47 PM (3 weeks ago)

Author:

johnjamesjacoby

Message:

Tests: Cover user nicename and author-change helpers.

Exercise nicename lookup and ID conversion, including input sanitization and filters. Assert that changing topic and reply authors recalculates engagement membership, and identify existing profile-permission coverage.

In trunk, for 2.7.

See #3695.

Location:

trunk/tests/phpunit/testcases/users/functions

Files:

• counts.php (modified) (2 diffs)
• functions.php (modified) (1 diff)
• permissions.php (modified) (3 diffs)

trunk/tests/phpunit/testcases/users/functions/counts.php

@@ -654 +654 @@
         /**
          * @covers ::bbp_update_counts_on_post_author_change
+         * @covers ::bbp_recalculate_engagements_on_post_author_change
          */
         public function test_changing_post_authors_updates_user_counts() {
@@ -675 +676 @@
                 wp_update_post( array( 'ID' => $topic_id, 'post_author' => $new_user_id ) );
                 $this->assertSame( 2, bbp_get_topic_voice_count( $topic_id, true ) );
+                $this->assertEqualsCanonicalizing( array( $old_user_id, $new_user_id ), bbp_get_topic_engagements( $topic_id ) );
 
                 wp_update_post( array( 'ID' => $reply_id, 'post_author' => $new_user_id ) );
                 $this->assertSame( 1, bbp_get_topic_voice_count( $topic_id, true ) );
+                $this->assertSame( array( $new_user_id ), bbp_get_topic_engagements( $topic_id ) );
 
                 $this->assertSame( 0, bbp_get_user_topic_count( $old_user_id, true ) );

trunk/tests/phpunit/testcases/users/functions/functions.php

@@ -261 +261 @@
 
                 $this->assertTrue( $r );
+        }
+
+        /**
+         * @covers ::bbp_get_user_ids_from_nicenames
+         */
+        public function test_bbp_get_user_ids_from_nicenames() {
+                $first_id  = $this->factory->user->create( array( 'user_nicename' => 'bbp-nicename-a' ) );
+                $second_id = $this->factory->user->create( array( 'user_nicename' => 'bbp-nicename-b' ) );
+                $seen      = null;
+                $record    = function ( $ids, $nicenames ) use ( &$seen ) {
+                        $seen = $nicenames;
+                        return $ids;
+                };
+
+                $this->assertSame( array(), bbp_get_user_ids_from_nicenames() );
+                $this->assertSame( array(), bbp_get_user_ids_from_nicenames( 'missing-nicename' ) );
+                add_filter( 'bbp_get_user_ids_from_nicenames', $record, 10, 2 );
+
+                try {
+                        $ids = bbp_get_user_ids_from_nicenames( 'BBP NICENAME A,BBP NICENAME B' );
+                        $this->assertEqualsCanonicalizing( array( $first_id, $second_id ), array_map( 'intval', $ids ) );
+                        $this->assertSame( array( 'bbp-nicename-a', 'bbp-nicename-b' ), $seen );
+                } finally {
+                        remove_filter( 'bbp_get_user_ids_from_nicenames', $record, 10 );
+                }
+        }
+
+        /**
+         * @covers ::bbp_get_user_nicenames_from_ids
+         */
+        public function test_bbp_get_user_nicenames_from_ids() {
+                $first_id  = $this->factory->user->create( array( 'user_nicename' => 'bbp-nicename-a' ) );
+                $second_id = $this->factory->user->create( array( 'user_nicename' => 'bbp-nicename-b' ) );
+                $input     = array( $first_id, $second_id );
+                $seen      = null;
+                $record    = function ( $nicenames, $ids ) use ( &$seen ) {
+                        $seen = $ids;
+                        return $nicenames;
+                };
+
+                $this->assertSame( array(), bbp_get_user_nicenames_from_ids() );
+                $this->assertSame( array(), bbp_get_user_nicenames_from_ids( array( PHP_INT_MAX ) ) );
+                add_filter( 'bbp_get_user_nicenames_from_ids', $record, 10, 2 );
+
+                try {
+                        $nicenames = bbp_get_user_nicenames_from_ids( $input );
+                        $this->assertEqualsCanonicalizing( array( 'bbp-nicename-a', 'bbp-nicename-b' ), $nicenames );
+                        $this->assertSame( $input, $seen );
+                } finally {
+                        remove_filter( 'bbp_get_user_nicenames_from_ids', $record, 10 );
+                }
         }
 

trunk/tests/phpunit/testcases/users/functions/permissions.php

@@ -317 +317 @@
         }
 
+        /**
+         * @covers ::bbp_filter_user_edit_post_data
+         */
         public function test_user_edit_post_data_enforces_field_permissions() {
                 $moderator_id = $this->factory->user->create();
@@ -349 +352 @@
         }
 
+        /**
+         * @covers ::bbp_filter_user_edit_post_data
+         */
         public function test_user_edit_post_data_removes_contact_methods_with_profile_fields() {
                 $moderator_id = $this->factory->user->create();
@@ -373 +379 @@
         }
 
+        /**
+         * @covers ::bbp_user_email_change_requires_confirmation
+         */
         public function test_email_confirmation_policy_distinguishes_self_and_moderator_edits() {
                 $moderator_id = $this->factory->user->create();