Changeset 7770

Timestamp:

10/02/2026 04:48:39 PM (3 weeks ago)

Author:

johnjamesjacoby

Message:

Tests: Cover forum last-reply and post-type helpers.

Replace five incomplete tests with coverage of reply permalink and URL behavior, topic-ID and missing-metadata fallbacks, forum post-type defaults and filter hooks. Correct the forum post-type output assertion.

In trunk, for 2.7.
See #3695.

Location:

trunk/tests/phpunit/testcases/forums/template

Files:

• get-last-thing.php (modified) (2 diffs)
• post_type.php (modified) (2 diffs)

trunk/tests/phpunit/testcases/forums/template/get-last-thing.php

@@ -615 +615 @@
          * @covers ::bbp_forum_last_reply_permalink
          * @covers ::bbp_get_forum_last_reply_permalink
-         * @todo   Implement test_bbp_get_forum_last_reply_permalink().
          */
         public function test_bbp_get_forum_last_reply_permalink() {
-                // Remove the following lines when you implement this test.
-                $this->markTestIncomplete(
-                        'This test has not been implemented yet.'
-                );
+                $category_id = $this->factory->forum->create();
+                bbp_categorize_forum( $category_id );
+                $forum_id = $this->factory->forum->create( array( 'post_parent' => $category_id ) );
+                $topic_id = $this->factory->topic->create( array(
+                        'post_parent' => $forum_id,
+                        'topic_meta'  => array( 'forum_id' => $forum_id ),
+                ) );
+                $reply_id = $this->factory->reply->create( array(
+                        'post_parent' => $topic_id,
+                        'reply_meta'  => array( 'forum_id' => $forum_id, 'topic_id' => $topic_id ),
+                ) );
+                $permalink = bbp_get_reply_permalink( $reply_id );
+
+                $this->assertSame( $reply_id, bbp_get_forum_last_reply_id( $forum_id ) );
+                $this->assertSame( $permalink, bbp_get_forum_last_reply_permalink( $forum_id ) );
+                $this->assertSame( $permalink, bbp_get_forum_last_reply_permalink( $category_id ) );
+                $this->expectOutputString( esc_url( $permalink ) );
+                bbp_forum_last_reply_permalink( $forum_id );
+        }
+
+        /**
+         * @covers ::bbp_get_forum_last_reply_permalink
+         */
+        public function test_bbp_get_forum_last_reply_permalink_filter() {
+                $forum_id = $this->factory->forum->create();
+                $topic_id = $this->factory->topic->create( array(
+                        'post_parent' => $forum_id,
+                        'topic_meta'  => array( 'forum_id' => $forum_id ),
+                ) );
+                $reply_id = $this->factory->reply->create( array(
+                        'post_parent' => $topic_id,
+                        'reply_meta'  => array( 'forum_id' => $forum_id, 'topic_id' => $topic_id ),
+                ) );
+                $filter = function( $permalink, $filtered_forum_id, $filtered_reply_id ) use ( $forum_id, $reply_id ) {
+                        $this->assertSame( bbp_get_reply_permalink( $reply_id ), $permalink );
+                        $this->assertSame( $forum_id, $filtered_forum_id );
+                        $this->assertSame( $reply_id, $filtered_reply_id );
+                        return 'https://example.org/last-reply/';
+                };
+                add_filter( 'bbp_get_forum_last_reply_permalink', $filter, 10, 3 );
+                try {
+                        $this->assertSame( 'https://example.org/last-reply/', bbp_get_forum_last_reply_permalink( $forum_id ) );
+                } finally {
+                        remove_filter( 'bbp_get_forum_last_reply_permalink', $filter );
+                }
         }
 
@@ -627 +667 @@
          * @covers ::bbp_forum_last_reply_url
          * @covers ::bbp_get_forum_last_reply_url
-         * @todo   Implement test_bbp_get_forum_last_reply_url().
          */
         public function test_bbp_get_forum_last_reply_url() {
-                // Remove the following lines when you implement this test.
-                $this->markTestIncomplete(
-                        'This test has not been implemented yet.'
-                );
+                $forum_id = $this->factory->forum->create();
+                $this->assertSame( '', bbp_get_forum_last_reply_url( $forum_id ) );
+
+                $topic_id = $this->factory->topic->create( array(
+                        'post_parent' => $forum_id,
+                        'topic_meta'  => array( 'forum_id' => $forum_id ),
+                ) );
+                $this->assertSame( $topic_id, bbp_get_forum_last_reply_id( $forum_id ) );
+                $this->assertSame( bbp_get_reply_url( $topic_id ), bbp_get_forum_last_reply_url( $forum_id ) );
+
+                delete_post_meta( $forum_id, '_bbp_last_reply_id' );
+                $this->assertSame( 0, bbp_get_forum_last_reply_id( $forum_id ) );
+                $this->assertSame( bbp_get_topic_permalink( $topic_id ), bbp_get_forum_last_reply_url( $forum_id ) );
+
+                $reply_id = $this->factory->reply->create( array(
+                        'post_parent' => $topic_id,
+                        'reply_meta'  => array( 'forum_id' => $forum_id, 'topic_id' => $topic_id ),
+                ) );
+                $url = bbp_get_reply_url( $reply_id );
+                $this->assertSame( $reply_id, bbp_get_forum_last_reply_id( $forum_id ) );
+                $this->assertSame( $url, bbp_get_forum_last_reply_url( $forum_id ) );
+                $this->expectOutputString( esc_url( $url ) );
+                bbp_forum_last_reply_url( $forum_id );
+        }
+
+        /**
+         * @covers ::bbp_get_forum_last_reply_url
+         */
+        public function test_bbp_get_forum_last_reply_url_filter() {
+                $forum_id = $this->factory->forum->create();
+                $filter = function( $url, $filtered_forum_id, $reply_id ) use ( $forum_id ) {
+                        $this->assertSame( '', $url );
+                        $this->assertSame( $forum_id, $filtered_forum_id );
+                        $this->assertSame( 0, $reply_id );
+                        return 'https://example.org/forum/last/';
+                };
+                add_filter( 'bbp_get_forum_last_reply_url', $filter, 10, 3 );
+                try {
+                        $this->assertSame( 'https://example.org/forum/last/', bbp_get_forum_last_reply_url( $forum_id ) );
+                } finally {
+                        remove_filter( 'bbp_get_forum_last_reply_url', $filter );
+                }
         }
 

trunk/tests/phpunit/testcases/forums/template/post_type.php

@@ -15 +15 @@
          */
         public function test_bbp_get_forum_post_type() {
-                $f = $this->factory->forum->create();
-
                 $fobj = get_post_type_object( 'forum' );
 
@@ -31 +29 @@
                 $this->assertTrue( is_post_type_hierarchical( 'forum' ) );
 
-                $forum_type = bbp_forum_post_type( $f );
-                $this->expectOutputString( 'forum', $forum_type );
+                $this->assertSame( 'forum', bbp_get_forum_post_type() );
+                $this->expectOutputString( 'forum' );
+                bbp_forum_post_type();
+        }
 
-                $forum_type = bbp_get_forum_post_type( $f );
-                $this->assertSame( 'forum', $forum_type );
+        /**
+         * @covers ::bbp_get_forum_post_type
+         */
+        public function test_bbp_get_forum_post_type_filter() {
+                $filter = function( $post_type ) {
+                        $this->assertSame( 'forum', $post_type );
+                        return 'custom-forum';
+                };
+                add_filter( 'bbp_get_forum_post_type', $filter );
+                try {
+                        $this->assertSame( 'custom-forum', bbp_get_forum_post_type() );
+                } finally {
+                        remove_filter( 'bbp_get_forum_post_type', $filter );
+                }
         }
 
         /**
          * @covers ::bbp_get_forum_post_type_labels
-         * @todo   Implement test_bbp_get_forum_post_type_labels().
          */
         public function test_bbp_get_forum_post_type_labels() {
-                // Remove the following lines when you implement this test.
-                $this->markTestIncomplete(
-                        'This test has not been implemented yet.'
+                $labels = bbp_get_forum_post_type_labels();
+
+                $this->assertSame(
+                        array(
+                                'name', 'menu_name', 'singular_name', 'all_items', 'add_new',
+                                'add_new_item', 'edit', 'edit_item', 'new_item', 'view',
+                                'view_item', 'view_items', 'search_items', 'not_found',
+                                'not_found_in_trash', 'filter_items_list', 'items_list',
+                                'items_list_navigation', 'parent_item_colon', 'archives',
+                                'attributes', 'insert_into_item', 'uploaded_to_this_item',
+                                'featured_image', 'set_featured_image', 'remove_featured_image',
+                                'use_featured_image', 'item_published', 'item_published_privately',
+                                'item_reverted_to_draft', 'item_scheduled', 'item_updated'
+                        ),
+                        array_keys( $labels )
                 );
+                $this->assertSame( 'Forums', $labels['name'] );
+                $this->assertSame( 'Forum', $labels['singular_name'] );
+                $this->assertSame( 'No forums found', $labels['not_found'] );
+                $this->assertSame( 'Forum updated.', $labels['item_updated'] );
+
+                $filter = function( $default ) use ( $labels ) {
+                        $this->assertSame( $labels, $default );
+                        return array( 'name' => 'Discussion areas' );
+                };
+                add_filter( 'bbp_get_forum_post_type_labels', $filter );
+                try {
+                        $this->assertSame( array( 'name' => 'Discussion areas' ), bbp_get_forum_post_type_labels() );
+                } finally {
+                        remove_filter( 'bbp_get_forum_post_type_labels', $filter );
+                }
         }
 
         /**
          * @covers ::bbp_get_forum_post_type_rewrite
-         * @todo   Implement test_bbp_get_forum_post_type_rewrite().
          */
         public function test_bbp_get_forum_post_type_rewrite() {
-                // Remove the following lines when you implement this test.
-                $this->markTestIncomplete(
-                        'This test has not been implemented yet.'
+                $this->assertSame(
+                        array( 'slug' => bbp_get_forum_slug(), 'with_front' => false ),
+                        bbp_get_forum_post_type_rewrite()
                 );
+
+                $filter = function( $rewrite ) {
+                        $this->assertSame( bbp_get_forum_slug(), $rewrite['slug'] );
+                        $this->assertFalse( $rewrite['with_front'] );
+                        $rewrite['slug'] = 'discussion-area';
+                        return $rewrite;
+                };
+                add_filter( 'bbp_get_forum_post_type_rewrite', $filter );
+                try {
+                        $this->assertSame(
+                                array( 'slug' => 'discussion-area', 'with_front' => false ),
+                                bbp_get_forum_post_type_rewrite()
+                        );
+                } finally {
+                        remove_filter( 'bbp_get_forum_post_type_rewrite', $filter );
+                }
         }
 
         /**
          * @covers ::bbp_get_forum_post_type_supports
-         * @todo   Implement test_bbp_get_forum_post_type_supports().
          */
         public function test_bbp_get_forum_post_type_supports() {
-                // Remove the following lines when you implement this test.
-                $this->markTestIncomplete(
-                        'This test has not been implemented yet.'
-                );
+                $this->assertSame( array( 'title', 'editor', 'revisions' ), bbp_get_forum_post_type_supports() );
+
+                $filter = function( $supports ) {
+                        $this->assertSame( array( 'title', 'editor', 'revisions' ), $supports );
+                        return array( 'title', 'comments' );
+                };
+                add_filter( 'bbp_get_forum_post_type_supports', $filter );
+                try {
+                        $this->assertSame( array( 'title', 'comments' ), bbp_get_forum_post_type_supports() );
+                } finally {
+                        remove_filter( 'bbp_get_forum_post_type_supports', $filter );
+                }
         }
 }