Changeset 7759

Timestamp:

09/30/2026 06:13:50 AM (4 weeks ago)

Author:

johnjamesjacoby

Message:

Tests: Stabilize topic activity assertions.

Assert the stored last-active timestamp and update return value instead of comparing relative labels calculated at different seconds. Keep a nonempty freshness check.

In trunk, for 2.7.

File:

• trunk/tests/phpunit/testcases/topics/functions/update-last-thing.php (modified) (2 diffs)

trunk/tests/phpunit/testcases/topics/functions/update-last-thing.php

@@ -81 +81 @@
                 ) );
 
-                $r1_time_raw       = get_post_field( 'post_date', $r1 );
-                $r1_time_formatted = bbp_get_time_since( bbp_convert_date( $r1_time_raw ) );
+                $r1_time_raw = get_post_field( 'post_date', $r1 );
 
                 $time = bbp_update_topic_last_active_time( $t, $r1_time_raw );
                 $this->assertSame( $r1_time_raw, $time );
 
-                $time = bbp_get_topic_last_active_time( $t );
-                $this->assertSame( $r1_time_formatted, $time );
+                $this->assertSame( $r1_time_raw, get_post_meta( $t, '_bbp_last_active_time', true ) );
+                $this->assertNotSame( '', bbp_get_topic_last_active_time( $t ) );
 
                 $r2 = $this->factory->reply->create_many( 2, array(
@@ -98 +97 @@
                 ) );
 
-                $r2_time_raw       = get_post_field( 'post_date', $r2[1] );
-                $r2_time_formatted = bbp_get_time_since( bbp_convert_date( $r2_time_raw ) );
+                $r2_time_raw = get_post_field( 'post_date', $r2[1] );
 
-                bbp_update_topic_last_active_time( $t );
-                $time = bbp_get_topic_last_active_time( $t );
-                $this->assertSame( $r2_time_formatted, $time );
+                $time = bbp_update_topic_last_active_time( $t );
+                $this->assertSame( $r2_time_raw, $time );
+                $this->assertSame( $r2_time_raw, get_post_meta( $t, '_bbp_last_active_time', true ) );
+                $this->assertNotSame( '', bbp_get_topic_last_active_time( $t ) );
         }