Changeset 7602

Timestamp:

09/19/2026 09:12:59 AM (36 hours ago)

Author:

johnjamesjacoby

Message:

Importers: Normalize final compatibility details.

Correct the PHPWind status-map documentation to match its source bitmask, reject malformed scalar values in the example password verifier, and add regression coverage. Align anonymous-author detection with trunk to avoid loose-comparison behavior on PHP 7.2.

In branches/2.6, for 2.6.18.

See #3684.
See #3686.

Location:

branches/2.6

Files:

• src/includes/admin/classes/class-bbp-converter-base.php (modified) (1 diff)
• src/includes/admin/converters/Example.php (modified) (1 diff)
• src/includes/admin/converters/PHPWind.php (modified) (1 diff)
• tests/phpunit/testcases/admin/converters/Example.php (added)

branches/2.6/src/includes/admin/classes/class-bbp-converter-base.php

@@ -1349 +1349 @@
          */
         private function callback_check_anonymous( $field ) {
-                $field = ( $this->callback_userid( $field ) == 0 )
+                $field = ! $this->callback_userid( $field )
                         ? 'true'
                         : 'false';

branches/2.6/src/includes/admin/converters/Example.php

@@ -715 +715 @@
 
                 // Bail if missing values
-                if ( ! is_array( $pass_array ) || ! isset( $pass_array['hash'], $pass_array['salt'] ) ) {
+                if ( ! is_string( $password ) || ! is_array( $pass_array ) || ! isset( $pass_array['hash'], $pass_array['salt'] ) || ! is_string( $pass_array['hash'] ) || ! is_string( $pass_array['salt'] ) ) {
                         return false;
                 }

branches/2.6/src/includes/admin/converters/PHPWind.php

@@ -297 +297 @@
                 );
 
-                // Topic status (Open or Closed, PHPWind v9.x 0=no, 1=closed & 2=open)
+                // Topic status (PHPWind v9.x bitmask: 1=locked & 2=closed)
                 $this->field_map[] = array(
                         'from_tablename'  => 'bbs_threads',